Unreviewed, rolling out r213226.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 1 Mar 2017 21:10:45 +0000 (21:10 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 1 Mar 2017 21:10:45 +0000 (21:10 +0000)
https://bugs.webkit.org/show_bug.cgi?id=169051

Speculative rollout, might be causing several failures and
crashes in WebKitGTK+ (Requested by lajava on #webkit).

Reverted changeset:

"REGRESSION(r213062): [SOUP] UTF-8 filename in Content-
Disposition header incorrectly handled since r213062"
https://bugs.webkit.org/show_bug.cgi?id=169024
http://trac.webkit.org/changeset/213226

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp

index a10bcc7..08153ff 100644 (file)
@@ -1,3 +1,18 @@
+2017-03-01  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r213226.
+        https://bugs.webkit.org/show_bug.cgi?id=169051
+
+        Speculative rollout, might be causing several failures and
+        crashes in WebKitGTK+ (Requested by lajava on #webkit).
+
+        Reverted changeset:
+
+        "REGRESSION(r213062): [SOUP] UTF-8 filename in Content-
+        Disposition header incorrectly handled since r213062"
+        https://bugs.webkit.org/show_bug.cgi?id=169024
+        http://trac.webkit.org/changeset/213226
+
 2017-03-01  James Craig  <jcraig@apple.com>
 
         AX: add role aliases for ARIA DPUB module
index 3b7392c..3a80f25 100644 (file)
@@ -98,8 +98,6 @@ String ResourceResponse::platformSuggestedFilename() const
 {
     SoupMessageHeaders* soupHeaders = soup_message_headers_new(SOUP_MESSAGE_HEADERS_RESPONSE);
     String contentDisposition(httpHeaderField(HTTPHeaderName::ContentDisposition));
-    if (contentDisposition.is8Bit())
-        contentDisposition = String::fromUTF8WithLatin1Fallback(contentDisposition.characters8(), contentDisposition.length());
     soup_message_headers_append(soupHeaders, "Content-Disposition", contentDisposition.utf8().data());
     GRefPtr<GHashTable> params;
     soup_message_headers_get_content_disposition(soupHeaders, nullptr, &params.outPtr());