+2013-04-09 Geoffrey Garen <ggaren@apple.com>
+
+ Removed an annoying message from svn-create-patch
+ https://bugs.webkit.org/show_bug.cgi?id=114332
+
+ Reviewed by Alexey Proskuryakov.
+
+ I see this message basically every time I write a patch, so it must not
+ be true.
+
+ * Scripts/svn-create-patch:
+ (generateDiff):
+
2013-04-10 Anton Obzhirov <a.obzhirov@samsung.com>
[GTK] Add support for Page Visibility
my $svnRoot = determineSVNRoot();
my $prefix = chdirReturningRelativePath($svnRoot);
-my $patchSize = 0;
-
-# Generate the diffs, in a order chosen for easy reviewing.
+# Generate the diffs, in an order chosen for ease of reviewing.
for my $path (sort patchpathcmp values %diffFiles) {
- $patchSize += generateDiff($path, $prefix);
-}
-
-if ($patchSize > 20480) {
- print STDERR "WARNING: Patch's size is " . int($patchSize/1024) . " kbytes.\n";
- print STDERR "Patches 20k or smaller are more likely to be reviewed. Larger patches may sit unreviewed for a long time.\n";
+ generateDiff($path, $prefix);
}
exit 0;
print "\n" if ($patch && $patch =~ m/\n\S+$/m);
outputBinaryContent($file);
}
- return length($patch);
}
sub generateFileList($\%)