Remove an inaccurate comment from RenderTextLineBoxes
authortimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 22 Jul 2017 00:13:11 +0000 (00:13 +0000)
committertimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 22 Jul 2017 00:13:11 +0000 (00:13 +0000)
* rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::absoluteRectsForRange):
This comment has been wrong for at least 4 years.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@219753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderTextLineBoxes.cpp

index dfc7ccf..506109d 100644 (file)
@@ -1,5 +1,13 @@
 2017-07-21  Timothy Horton  <timothy_horton@apple.com>
 
+        Remove an inaccurate comment from RenderTextLineBoxes
+
+        * rendering/RenderTextLineBoxes.cpp:
+        (WebCore::RenderTextLineBoxes::absoluteRectsForRange):
+        This comment has been wrong for at least 4 years.
+
+2017-07-21  Timothy Horton  <timothy_horton@apple.com>
+
         TextIndicator::estimatedTextColorsForRange asserts inside HashSet code (inserting reserved value)
         https://bugs.webkit.org/show_bug.cgi?id=174733
 
index e59f3de..2c48921 100644 (file)
@@ -553,7 +553,6 @@ Vector<IntRect> RenderTextLineBoxes::absoluteRectsForRange(const RenderText& ren
             rects.append(renderer.localToAbsoluteQuad(boundaries, UseTransforms, wasFixed).enclosingBoundingBox());
             continue;
         }
-        // FIXME: This code is wrong. It's converting local to absolute twice. http://webkit.org/b/65722
         FloatRect rect = localQuadForTextBox(*box, start, end, useSelectionHeight);
         if (!rect.isZero())
             rects.append(renderer.localToAbsoluteQuad(rect, UseTransforms, wasFixed).enclosingBoundingBox());