Add *explicit* keyword to constructors in WebCore/accessibility
authorgyuyoung.kim@samsung.com <gyuyoung.kim@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Aug 2012 08:41:07 +0000 (08:41 +0000)
committergyuyoung.kim@samsung.com <gyuyoung.kim@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Aug 2012 08:41:07 +0000 (08:41 +0000)
https://bugs.webkit.org/show_bug.cgi?id=93067

Reviewed by Kentaro Hara.

As a step to add *explicit* keyword to constructors which have a parameter,
*explicit* keyword is added to Source/WebCore/accessibility in order to avoid
implicit type conversion.

No new tests. Covered by existing tests.

* accessibility/AXObjectCache.h:
(AXObjectCache):
* accessibility/AccessibilityARIAGrid.h:
(AccessibilityARIAGrid):
* accessibility/AccessibilityARIAGridCell.h:
(AccessibilityARIAGridCell):
* accessibility/AccessibilityARIAGridRow.h:
(AccessibilityARIAGridRow):
* accessibility/AccessibilityList.h:
(AccessibilityList):
* accessibility/AccessibilityListBox.h:
(AccessibilityListBox):
* accessibility/AccessibilityMediaControls.h:
(AccessibilityMediaControl):
(AccessibilityMediaTimeline):
(AccessibilityMediaControlsContainer):
(AccessibilityMediaTimeDisplay):
* accessibility/AccessibilityMenuList.h:
(AccessibilityMenuList):
* accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
* accessibility/AccessibilityProgressIndicator.h:
(AccessibilityProgressIndicator):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/AccessibilityScrollView.h:
(AccessibilityScrollView):
* accessibility/AccessibilityScrollbar.h:
(AccessibilityScrollbar):
* accessibility/AccessibilitySlider.h:
(AccessibilitySlider):
* accessibility/AccessibilityTable.h:
(AccessibilityTable):
* accessibility/AccessibilityTableCell.h:
(AccessibilityTableCell):
* accessibility/AccessibilityTableRow.h:
(AccessibilityTableRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 files changed:
Source/WebCore/ChangeLog
Source/WebCore/accessibility/AXObjectCache.h
Source/WebCore/accessibility/AccessibilityARIAGrid.h
Source/WebCore/accessibility/AccessibilityARIAGridCell.h
Source/WebCore/accessibility/AccessibilityARIAGridRow.h
Source/WebCore/accessibility/AccessibilityList.h
Source/WebCore/accessibility/AccessibilityListBox.h
Source/WebCore/accessibility/AccessibilityMediaControls.h
Source/WebCore/accessibility/AccessibilityMenuList.h
Source/WebCore/accessibility/AccessibilityNodeObject.h
Source/WebCore/accessibility/AccessibilityProgressIndicator.h
Source/WebCore/accessibility/AccessibilityRenderObject.h
Source/WebCore/accessibility/AccessibilityScrollView.h
Source/WebCore/accessibility/AccessibilityScrollbar.h
Source/WebCore/accessibility/AccessibilitySlider.h
Source/WebCore/accessibility/AccessibilityTable.h
Source/WebCore/accessibility/AccessibilityTableCell.h
Source/WebCore/accessibility/AccessibilityTableRow.h

index 4980d06..69a287e 100644 (file)
@@ -1,3 +1,54 @@
+2012-08-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        Add *explicit* keyword to constructors in WebCore/accessibility
+        https://bugs.webkit.org/show_bug.cgi?id=93067
+
+        Reviewed by Kentaro Hara.
+
+        As a step to add *explicit* keyword to constructors which have a parameter,
+        *explicit* keyword is added to Source/WebCore/accessibility in order to avoid
+        implicit type conversion.
+
+        No new tests. Covered by existing tests.
+
+        * accessibility/AXObjectCache.h:
+        (AXObjectCache):
+        * accessibility/AccessibilityARIAGrid.h:
+        (AccessibilityARIAGrid):
+        * accessibility/AccessibilityARIAGridCell.h:
+        (AccessibilityARIAGridCell):
+        * accessibility/AccessibilityARIAGridRow.h:
+        (AccessibilityARIAGridRow):
+        * accessibility/AccessibilityList.h:
+        (AccessibilityList):
+        * accessibility/AccessibilityListBox.h:
+        (AccessibilityListBox):
+        * accessibility/AccessibilityMediaControls.h:
+        (AccessibilityMediaControl):
+        (AccessibilityMediaTimeline):
+        (AccessibilityMediaControlsContainer):
+        (AccessibilityMediaTimeDisplay):
+        * accessibility/AccessibilityMenuList.h:
+        (AccessibilityMenuList):
+        * accessibility/AccessibilityNodeObject.h:
+        (AccessibilityNodeObject):
+        * accessibility/AccessibilityProgressIndicator.h:
+        (AccessibilityProgressIndicator):
+        * accessibility/AccessibilityRenderObject.h:
+        (AccessibilityRenderObject):
+        * accessibility/AccessibilityScrollView.h:
+        (AccessibilityScrollView):
+        * accessibility/AccessibilityScrollbar.h:
+        (AccessibilityScrollbar):
+        * accessibility/AccessibilitySlider.h:
+        (AccessibilitySlider):
+        * accessibility/AccessibilityTable.h:
+        (AccessibilityTable):
+        * accessibility/AccessibilityTableCell.h:
+        (AccessibilityTableCell):
+        * accessibility/AccessibilityTableRow.h:
+        (AccessibilityTableRow):
+
 2012-08-03  Abhishek Arya  <inferno@chromium.org>
 
         Regression(r124564): Wrong inlineChildrenBlock->hasLayer() computed in RenderBlock::removeChild.
index b768b7d..603fce0 100644 (file)
@@ -57,7 +57,7 @@ enum PostType { PostSynchronously, PostAsynchronously };
 class AXObjectCache {
     WTF_MAKE_NONCOPYABLE(AXObjectCache); WTF_MAKE_FAST_ALLOCATED;
 public:
-    AXObjectCache(const Document*);
+    explicit AXObjectCache(const Document*);
     ~AXObjectCache();
 
     static AccessibilityObject* focusedUIElementForPage(const Page*);
index 063e18b..67e8804 100644 (file)
@@ -40,7 +40,7 @@ class AccessibilityTableHeaderContainer;
 class AccessibilityARIAGrid : public AccessibilityTable {
     
 private:
-    AccessibilityARIAGrid(RenderObject*);
+    explicit AccessibilityARIAGrid(RenderObject*);
 public:
     static PassRefPtr<AccessibilityARIAGrid> create(RenderObject*);
     virtual ~AccessibilityARIAGrid();
index 2923de8..53efa48 100644 (file)
@@ -36,7 +36,7 @@ namespace WebCore {
 class AccessibilityARIAGridCell : public AccessibilityTableCell {
     
 private:
-    AccessibilityARIAGridCell(RenderObject*);
+    explicit AccessibilityARIAGridCell(RenderObject*);
 public:
     static PassRefPtr<AccessibilityARIAGridCell> create(RenderObject*);
     virtual ~AccessibilityARIAGridCell();
index f89ea92..69af63b 100644 (file)
@@ -36,7 +36,7 @@ namespace WebCore {
 class AccessibilityARIAGridRow : public AccessibilityTableRow {
     
 private:
-    AccessibilityARIAGridRow(RenderObject*);
+    explicit AccessibilityARIAGridRow(RenderObject*);
 public:
     static PassRefPtr<AccessibilityARIAGridRow> create(RenderObject*);
     virtual ~AccessibilityARIAGridRow();
index 3cfde0b..1e07a31 100644 (file)
@@ -42,7 +42,7 @@ namespace WebCore {
 class AccessibilityList : public AccessibilityRenderObject {
     
 private:
-    AccessibilityList(RenderObject*);
+    explicit AccessibilityList(RenderObject*);
 public:
     static PassRefPtr<AccessibilityList> create(RenderObject*);
     virtual ~AccessibilityList();
index e6113f2..4f00094 100644 (file)
@@ -36,7 +36,7 @@ namespace WebCore {
 class AccessibilityListBox : public AccessibilityRenderObject {
 
 private:
-    AccessibilityListBox(RenderObject*);
+    explicit AccessibilityListBox(RenderObject*);
 public:
     static PassRefPtr<AccessibilityListBox> create(RenderObject*);
     virtual ~AccessibilityListBox();
index 6f51b2c..05c03ee 100644 (file)
@@ -51,7 +51,7 @@ public:
     virtual String helpText() const;
 
 protected:
-    AccessibilityMediaControl(RenderObject*);
+    explicit AccessibilityMediaControl(RenderObject*);
     MediaControlElementType controlType() const;
     String controlTypeName() const;
 };
@@ -70,7 +70,7 @@ public:
     const AtomicString& getAttribute(const QualifiedName& attribute) const;
 
 private:
-    AccessibilityMediaTimeline(RenderObject*);
+    explicit AccessibilityMediaTimeline(RenderObject*);
 };
 
 
@@ -87,7 +87,7 @@ public:
     virtual String accessibilityDescription() const;
 
 private:
-    AccessibilityMediaControlsContainer(RenderObject*);
+    explicit AccessibilityMediaControlsContainer(RenderObject*);
     bool controllingVideoElement() const;
     const String elementTypeName() const;
 };
@@ -106,7 +106,7 @@ public:
     virtual String accessibilityDescription() const;
 
 private:
-    AccessibilityMediaTimeDisplay(RenderObject*);
+    explicit AccessibilityMediaTimeDisplay(RenderObject*);
 };
 
 
index 281d736..3ea8ffd 100644 (file)
@@ -45,7 +45,7 @@ public:
     void didUpdateActiveOption(int optionIndex);
 
 private:
-    AccessibilityMenuList(RenderMenuList*);
+    explicit AccessibilityMenuList(RenderMenuList*);
 
     virtual bool isMenuList() const { return true; }
     virtual AccessibilityRole roleValue() const { return PopUpButtonRole; }
index 9082f8b..b0e1f1f 100644 (file)
@@ -57,7 +57,7 @@ class Widget;
     
 class AccessibilityNodeObject : public AccessibilityObject {
 protected:
-    AccessibilityNodeObject(Node*);
+    explicit AccessibilityNodeObject(Node*);
 public:
     static PassRefPtr<AccessibilityNodeObject> create(Node*);
     virtual ~AccessibilityNodeObject();
index af8bc20..d60bb2c 100644 (file)
@@ -42,7 +42,7 @@ private:
     virtual float maxValueForRange() const;
     virtual float minValueForRange() const;
 
-    AccessibilityProgressIndicator(RenderProgress*);
+    explicit AccessibilityProgressIndicator(RenderProgress*);
 
     HTMLProgressElement* element() const;
     virtual bool accessibilityIsIgnored() const;
index 264e70b..8fe0afe 100644 (file)
@@ -57,7 +57,7 @@ class Widget;
     
 class AccessibilityRenderObject : public AccessibilityNodeObject {
 protected:
-    AccessibilityRenderObject(RenderObject*);
+    explicit AccessibilityRenderObject(RenderObject*);
 public:
     static PassRefPtr<AccessibilityRenderObject> create(RenderObject*);
     virtual ~AccessibilityRenderObject();
index 912f53d..9953164 100644 (file)
@@ -45,7 +45,7 @@ protected:
     virtual void scrollTo(const IntPoint&) const;
     
 private:
-    AccessibilityScrollView(ScrollView*);
+    explicit AccessibilityScrollView(ScrollView*);
     
     virtual bool accessibilityIsIgnored() const;
     virtual bool isAccessibilityScrollView() const { return true; }
index fc44fd2..840b797 100644 (file)
@@ -42,7 +42,7 @@ public:
     Scrollbar* scrollbar() const { return m_scrollbar.get(); }
     
 private:
-    AccessibilityScrollbar(Scrollbar*);
+    explicit AccessibilityScrollbar(Scrollbar*);
 
     virtual bool accessibilityIsIgnored() const { return false; }
     virtual bool canSetValueAttribute() const { return true; }
index 81fe918..94c4316 100644 (file)
@@ -43,7 +43,7 @@ public:
     virtual ~AccessibilitySlider() { }
 
 protected:
-    AccessibilitySlider(RenderObject*);
+    explicit AccessibilitySlider(RenderObject*);
 
 private:
     HTMLInputElement* element() const;
index 2ee1bc0..9f28f41 100644 (file)
@@ -45,7 +45,7 @@ class AccessibilityTableCell;
 class AccessibilityTable : public AccessibilityRenderObject {
 
 protected:
-    AccessibilityTable(RenderObject*);
+    explicit AccessibilityTable(RenderObject*);
 public:
     static PassRefPtr<AccessibilityTable> create(RenderObject*);
     virtual ~AccessibilityTable();
index e4a201f..0430715 100644 (file)
@@ -36,7 +36,7 @@ namespace WebCore {
 class AccessibilityTableCell : public AccessibilityRenderObject {
     
 protected:
-    AccessibilityTableCell(RenderObject*);
+    explicit AccessibilityTableCell(RenderObject*);
 public:
     static PassRefPtr<AccessibilityTableCell> create(RenderObject*);
     virtual ~AccessibilityTableCell();
index 80bfbf6..18c25ac 100644 (file)
@@ -36,7 +36,7 @@ namespace WebCore {
 class AccessibilityTableRow : public AccessibilityRenderObject {
     
 protected:
-    AccessibilityTableRow(RenderObject*);
+    explicit AccessibilityTableRow(RenderObject*);
 public:
     static PassRefPtr<AccessibilityTableRow> create(RenderObject*);
     virtual ~AccessibilityTableRow();