Remove ENABLE_OPENCL fully
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 5 Nov 2018 02:15:48 +0000 (02:15 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 5 Nov 2018 02:15:48 +0000 (02:15 +0000)
https://bugs.webkit.org/show_bug.cgi?id=191172

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-04
Reviewed by Yusuke Suzuki.

Forgot to simplify this, no need for applyAll anymore
since it just calls apply.

No new tests since no change in functionality.

* platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::applyAll): Deleted.
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/filters/FilterEffect.h
Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp

index f01b6f0..a80a5f2 100644 (file)
@@ -1,3 +1,20 @@
+2018-11-04  Rob Buis  <rbuis@igalia.com>
+
+        Remove ENABLE_OPENCL fully
+        https://bugs.webkit.org/show_bug.cgi?id=191172
+
+        Reviewed by Yusuke Suzuki.
+
+        Forgot to simplify this, no need for applyAll anymore
+        since it just calls apply.
+
+        No new tests since no change in functionality.
+
+        * platform/graphics/filters/FilterEffect.h:
+        (WebCore::FilterEffect::applyAll): Deleted.
+        * rendering/svg/RenderSVGResourceFilter.cpp:
+        (WebCore::RenderSVGResourceFilter::postApplyResource):
+
 2018-11-04  Zalan Bujtas  <zalan@apple.com>
 
         [iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired.
index 8c26e2b..9b006e3 100644 (file)
@@ -93,7 +93,6 @@ public:
     void setMaxEffectRect(const FloatRect& maxEffectRect) { m_maxEffectRect = maxEffectRect; } 
 
     void apply();
-    inline void applyAll() { apply(); }
 
     // Correct any invalid pixels, if necessary, in the result of a filter operation.
     // This method is used to ensure valid pixel values on filter inputs and the final result.
index 35826a0..dea282c 100644 (file)
@@ -268,7 +268,7 @@ void RenderSVGResourceFilter::postApplyResource(RenderElement& renderer, Graphic
         // Always true if filterData is just built (filterData->state == FilterData::Built).
         if (!lastEffect->hasResult()) {
             filterData.state = FilterData::Applying;
-            lastEffect->applyAll();
+            lastEffect->apply();
             lastEffect->correctFilterResultIfNeeded();
             lastEffect->transformResultColorSpace(ColorSpaceSRGB);
         }