[Android] DOMWrapperMap::Visitor needs virtual destructor
authorbenm@google.com <benm@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 18 Jan 2010 12:54:08 +0000 (12:54 +0000)
committerbenm@google.com <benm@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 18 Jan 2010 12:54:08 +0000 (12:54 +0000)
https://bugs.webkit.org/show_bug.cgi?id=33675

Patch by Andrei Popescu <andreip@google.com> on 2010-01-18
Reviewed by Adam Barth.

Add protected virtual dtor to DOMWrapperMap::Visitor. See bug for further discussion.

No new tests needed, functionality not changed.

* bindings/v8/V8DOMMap.h:
(WebCore::DOMWrapperMap::Visitor::~Visitor): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/bindings/v8/V8DOMMap.h

index 9ed3731..87492f7 100644 (file)
@@ -1,3 +1,17 @@
+2010-01-18  Andrei Popescu  <andreip@google.com>
+
+        Reviewed by Adam Barth.
+
+        [Android] DOMWrapperMap::Visitor needs virtual destructor
+        https://bugs.webkit.org/show_bug.cgi?id=33675
+
+        Add protected virtual dtor to DOMWrapperMap::Visitor. See bug for further discussion.
+
+        No new tests needed, functionality not changed.
+
+        * bindings/v8/V8DOMMap.h:
+        (WebCore::DOMWrapperMap::Visitor::~Visitor): Added.
+
 2010-01-18  Simon Hausmann  <simon.hausmann@nokia.com>
 
         Unreviewed Symbian build fix.
index 3a197fa..cddb0a4 100644 (file)
@@ -102,6 +102,8 @@ namespace WebCore {
         class Visitor {
         public:
             virtual void visitDOMWrapper(KeyType*, v8::Persistent<ValueType>) = 0;
+        protected:
+            virtual ~Visitor() { }
         };
 
         virtual void visit(Visitor* visitor)