Reviewed by Maciej.
authorweinig <weinig@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 24 Feb 2007 02:22:55 +0000 (02:22 +0000)
committerweinig <weinig@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 24 Feb 2007 02:22:55 +0000 (02:22 +0000)
        - fix http://bugs.webkit.org/show_bug.cgi?id=11573
          REGRESSION: pressing option-left arrow while in suggestion popup moves the insertion point to the left

        * WebView/WebHTMLView.mm:
        (-[WebTextCompleteController endRevertingChange:moveLeft:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/ChangeLog
WebKit/WebView/WebHTMLView.mm

index 1f9eb9e..da49cff 100644 (file)
@@ -1,3 +1,13 @@
+2007-02-23  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Maciej.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=11573
+          REGRESSION: pressing option-left arrow while in suggestion popup moves the insertion point to the left
+
+        * WebView/WebHTMLView.mm:
+        (-[WebTextCompleteController endRevertingChange:moveLeft:]):
+
 2007-02-23  Timothy Hatcher  <timothy@apple.com>
 
         Reviewed by Brady.
index 6aac092..36a04bf 100644 (file)
@@ -5762,10 +5762,11 @@ static CGPoint coreGraphicsScreenPointForAppKitScreenPoint(NSPoint point)
         if (revertChange) {
             WebFrameBridge *bridge = [_view _bridge];
             [bridge replaceSelectionWithText:_originalString selectReplacement:YES smartReplace:NO];
-        } else if (goLeft) {
-            [_view moveBackward:nil];
-        } else {
-            [_view moveForward:nil];
+        } else if ([_view _hasSelection]) {
+            if (goLeft)
+                [_view moveBackward:nil];
+            else
+                [_view moveForward:nil];
         }
         [_originalString release];
         _originalString = nil;