[V8] Pass Isolate to remaining toV8()
authorharaken@chromium.org <haraken@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 17 May 2012 02:21:10 +0000 (02:21 +0000)
committerharaken@chromium.org <haraken@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 17 May 2012 02:21:10 +0000 (02:21 +0000)
https://bugs.webkit.org/show_bug.cgi?id=86570

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to toV8(). I've landed a bunch of
patches to pass Isolate to toV8(), and this would be the last
patch for passing Isolate to toV8().

No tests. No change in behavior.

* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp
Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp

index 96a025f..b6f4d7f 100644 (file)
@@ -1,3 +1,22 @@
+2012-05-16  Kentaro Hara  <haraken@chromium.org>
+
+        [V8] Pass Isolate to remaining toV8()
+        https://bugs.webkit.org/show_bug.cgi?id=86570
+
+        Reviewed by Nate Chapin.
+
+        The objective is to pass Isolate around in V8 bindings.
+        This patch passes Isolate to toV8(). I've landed a bunch of
+        patches to pass Isolate to toV8(), and this would be the last
+        patch for passing Isolate to toV8().
+
+        No tests. No change in behavior.
+
+        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
+        (WebCore::getNamedItems):
+        * bindings/v8/custom/V8IDBAnyCustom.cpp:
+        (WebCore::toV8):
+
 2012-05-16  James Robinson  <jamesr@chromium.org>
 
         GraphicsContext3D interface should not be aware of CanvasRenderingContext
 2012-05-16  James Robinson  <jamesr@chromium.org>
 
         GraphicsContext3D interface should not be aware of CanvasRenderingContext
index d2416e8..2f1ea54 100644 (file)
@@ -55,7 +55,7 @@ static v8::Handle<v8::Value> getNamedItems(HTMLCollection* collection, AtomicStr
         return toV8(namedItems.at(0).release(), isolate);
 
     if (collection->type() == FormControls)
         return toV8(namedItems.at(0).release(), isolate);
 
     if (collection->type() == FormControls)
-        return toV8(collection->base()->radioNodeList(name).get());
+        return toV8(collection->base()->radioNodeList(name).get(), isolate);
 
     return toV8(V8NamedNodesCollection::create(namedItems), isolate);
 }
 
     return toV8(V8NamedNodesCollection::create(namedItems), isolate);
 }
index 1733ec8..1434054 100644 (file)
@@ -55,23 +55,23 @@ v8::Handle<v8::Value> toV8(IDBAny* impl, v8::Isolate* isolate)
     case IDBAny::NullType:
         return v8::Null();
     case IDBAny::DOMStringListType:
     case IDBAny::NullType:
         return v8::Null();
     case IDBAny::DOMStringListType:
-        return toV8(impl->domStringList());
+        return toV8(impl->domStringList(), isolate);
     case IDBAny::IDBCursorType:
     case IDBAny::IDBCursorType:
-        return toV8(impl->idbCursor());
+        return toV8(impl->idbCursor(), isolate);
     case IDBAny::IDBCursorWithValueType:
     case IDBAny::IDBCursorWithValueType:
-        return toV8(impl->idbCursorWithValue());
+        return toV8(impl->idbCursorWithValue(), isolate);
     case IDBAny::IDBDatabaseType:
     case IDBAny::IDBDatabaseType:
-        return toV8(impl->idbDatabase());
+        return toV8(impl->idbDatabase(), isolate);
     case IDBAny::IDBFactoryType:
     case IDBAny::IDBFactoryType:
-        return toV8(impl->idbFactory());
+        return toV8(impl->idbFactory(), isolate);
     case IDBAny::IDBIndexType:
     case IDBAny::IDBIndexType:
-        return toV8(impl->idbIndex());
+        return toV8(impl->idbIndex(), isolate);
     case IDBAny::IDBKeyType:
     case IDBAny::IDBKeyType:
-        return toV8(impl->idbKey());
+        return toV8(impl->idbKey(), isolate);
     case IDBAny::IDBObjectStoreType:
     case IDBAny::IDBObjectStoreType:
-        return toV8(impl->idbObjectStore());
+        return toV8(impl->idbObjectStore(), isolate);
     case IDBAny::IDBTransactionType:
     case IDBAny::IDBTransactionType:
-        return toV8(impl->idbTransaction());
+        return toV8(impl->idbTransaction(), isolate);
     case IDBAny::SerializedScriptValueType:
         return impl->serializedScriptValue()->deserialize(0, isolate);
     }
     case IDBAny::SerializedScriptValueType:
         return impl->serializedScriptValue()->deserialize(0, isolate);
     }