https://bugs.webkit.org/show_bug.cgi?id=105122
Reviewed by Andreas Kling.
Source/WebCore:
Rename FrameLoaderClient::download to convertMainResourceLoadToDownload and change it to take a MainResourceLoader instead
of a ResourceHandle, since resource handles may not exist when loading isn't done in the web process.
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* loader/EmptyClients.h:
* loader/FrameLoaderClient.h:
(WebCore):
(FrameLoaderClient):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::continueAfterContentPolicy):
Source/WebKit/blackberry:
Update for WebCore changes.
* Api/WebPage.h:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):
Source/WebKit/chromium:
Update for WebCore changes.
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::convertMainResourceLoadToDownload):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
Source/WebKit/efl:
Update for WebCore changes.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::convertMainResourceLoadToDownload):
* WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):
Source/WebKit/gtk:
Update for WebCore changes.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::convertMainResourceLoadToDownload):
* WebCoreSupport/FrameLoaderClientGtk.h:
(FrameLoaderClient):
Source/WebKit/mac:
Update for WebCore changes.
* WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::convertMainResourceLoadToDownload):
Source/WebKit/qt:
Update for WebCore changes.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::convertMainResourceLoadToDownload):
* WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):
Source/WebKit/win:
Update for WebCore changes.
* WebFrame.cpp:
(WebFrame::convertMainResourceLoadToDownload):
* WebFrame.h:
Source/WebKit/wince:
Update for WebCore changes.
* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::convertMainResourceLoadToDownload):
* WebCoreSupport/FrameLoaderClientWinCE.h:
(FrameLoaderClientWinCE):
Source/WebKit/wx:
Update for WebCore changes.
* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::convertMainResourceLoadToDownload):
* WebKitSupport/FrameLoaderClientWx.h:
(FrameLoaderClientWx):
Source/WebKit2:
Update for WebCore changes.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::convertMainResourceLoadToDownload):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2012-12-15 Anders Carlsson <andersca@apple.com>
+
+ Rename FrameLoaderClient::download to convertMainResourceLoadToDownload
+ https://bugs.webkit.org/show_bug.cgi?id=105122
+
+ Reviewed by Andreas Kling.
+
+ Rename FrameLoaderClient::download to convertMainResourceLoadToDownload and change it to take a MainResourceLoader instead
+ of a ResourceHandle, since resource handles may not exist when loading isn't done in the web process.
+
+ * WebCore.exp.in:
+ * WebCore.xcodeproj/project.pbxproj:
+ * loader/EmptyClients.h:
+ * loader/FrameLoaderClient.h:
+ (WebCore):
+ (FrameLoaderClient):
+ * loader/MainResourceLoader.cpp:
+ (WebCore::MainResourceLoader::continueAfterContentPolicy):
+
2012-12-16 Eric Carlson <eric.carlson@apple.com>
Remove in-band text tracks when media element's src changes
__ZNK7WebCore17RegularExpression5matchERKN3WTF6StringEiPi
__ZNK7WebCore17RegularExpression9searchRevERKN3WTF6StringE
__ZNK7WebCore17ResourceErrorBase8lazyInitEv
+__ZNK7WebCore18MainResourceLoader6loaderEv
__ZNK7WebCore18PlatformPasteboard11changeCountEv
__ZNK7WebCore19AnimationController24numberOfActiveAnimationsEPNS_8DocumentE
__ZNK7WebCore19InspectorController12getHighlightEPNS_9HighlightE
1C5FAED10DCFD90100D58F78 /* JSJavaScriptCallFrame.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1C5FAECF0DCFD90100D58F78 /* JSJavaScriptCallFrame.cpp */; };
1C5FAED20DCFD90100D58F78 /* JSJavaScriptCallFrame.h in Headers */ = {isa = PBXBuildFile; fileRef = 1C5FAED00DCFD90100D58F78 /* JSJavaScriptCallFrame.h */; };
1C5FAEE70DCFDA6800D58F78 /* JSJavaScriptCallFrameCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1C5FAEE60DCFDA6800D58F78 /* JSJavaScriptCallFrameCustom.cpp */; };
- 1C63A2480F71646600C09D5A /* RunLoopTimer.h in Headers */ = {isa = PBXBuildFile; fileRef = 1C63A2460F71646600C09D5A /* RunLoopTimer.h */; };
+ 1C63A2480F71646600C09D5A /* RunLoopTimer.h in Headers */ = {isa = PBXBuildFile; fileRef = 1C63A2460F71646600C09D5A /* RunLoopTimer.h */; settings = {ATTRIBUTES = (Private, ); }; };
1C63A2490F71646600C09D5A /* RunLoopTimerCF.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1C63A2470F71646600C09D5A /* RunLoopTimerCF.cpp */; };
1C81B95A0E97330800266E07 /* InspectorController.h in Headers */ = {isa = PBXBuildFile; fileRef = 1C81B9560E97330800266E07 /* InspectorController.h */; settings = {ATTRIBUTES = (Private, ); }; };
1C81B95B0E97330800266E07 /* InspectorController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1C81B9570E97330800266E07 /* InspectorController.cpp */; };
656D373C0ADBA5DE00A4554D /* FrameLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 656D37240ADBA5DE00A4554D /* FrameLoader.h */; settings = {ATTRIBUTES = (Private, ); }; };
656D373E0ADBA5DE00A4554D /* FrameLoaderClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 656D37260ADBA5DE00A4554D /* FrameLoaderClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
656D373F0ADBA5DE00A4554D /* ResourceLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 656D37270ADBA5DE00A4554D /* ResourceLoader.h */; settings = {ATTRIBUTES = (Private, ); }; };
- 656D37410ADBA5DE00A4554D /* MainResourceLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 656D37290ADBA5DE00A4554D /* MainResourceLoader.h */; };
+ 656D37410ADBA5DE00A4554D /* MainResourceLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 656D37290ADBA5DE00A4554D /* MainResourceLoader.h */; settings = {ATTRIBUTES = (Private, ); }; };
656D37430ADBA5DE00A4554D /* NetscapePlugInStreamLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 656D372B0ADBA5DE00A4554D /* NetscapePlugInStreamLoader.h */; settings = {ATTRIBUTES = (Private, ); }; };
656D37480ADBA5DE00A4554D /* SubresourceLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 656D37300ADBA5DE00A4554D /* SubresourceLoader.h */; settings = {ATTRIBUTES = (Private, ); }; };
6571DCC81385E6A400702DD0 /* MemoryPressureHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = 657EDA071385CB97004E0645 /* MemoryPressureHandler.h */; settings = {ATTRIBUTES = (Private, ); }; };
D0CE58F8125E4CC200F3F199 /* ResourceLoadScheduler.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D0CE58F6125E4CC200F3F199 /* ResourceLoadScheduler.cpp */; };
D0CE58F9125E4CC200F3F199 /* ResourceLoadScheduler.h in Headers */ = {isa = PBXBuildFile; fileRef = D0CE58F7125E4CC200F3F199 /* ResourceLoadScheduler.h */; settings = {ATTRIBUTES = (Private, ); }; };
D0EDA774143E303C0028E383 /* CachedRawResource.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D0EDA772143E303C0028E383 /* CachedRawResource.cpp */; };
- D0EDA775143E303C0028E383 /* CachedRawResource.h in Headers */ = {isa = PBXBuildFile; fileRef = D0EDA773143E303C0028E383 /* CachedRawResource.h */; };
+ D0EDA775143E303C0028E383 /* CachedRawResource.h in Headers */ = {isa = PBXBuildFile; fileRef = D0EDA773143E303C0028E383 /* CachedRawResource.h */; settings = {ATTRIBUTES = (Private, ); }; };
D0FF2A5D11F8C45A007E74E0 /* PingLoader.cpp in Sources */ = {isa = PBXBuildFile; fileRef = D0FF2A5B11F8C45A007E74E0 /* PingLoader.cpp */; };
D0FF2A5E11F8C45A007E74E0 /* PingLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = D0FF2A5C11F8C45A007E74E0 /* PingLoader.h */; };
D23CA55D0AB0EAAE005108A5 /* JSRangeException.h in Headers */ = {isa = PBXBuildFile; fileRef = D23CA55C0AB0EAAE005108A5 /* JSRangeException.h */; };
virtual void detachedFromParent2() { }
virtual void detachedFromParent3() { }
- virtual void download(ResourceHandle*, const ResourceRequest&, const ResourceResponse&) { }
+ virtual void convertMainResourceLoadToDownload(MainResourceLoader*, const ResourceRequest&, const ResourceResponse&) OVERRIDE { }
virtual void assignIdentifierToInitialRequest(unsigned long, DocumentLoader*, const ResourceRequest&) { }
virtual bool shouldUseCredentialStorage(DocumentLoader*, unsigned long) { return false; }
class IntentRequest;
#endif
class KURL;
+ class MainResourceLoader;
class MessageEvent;
class NavigationAction;
class Page;
virtual void dispatchDidBecomeFrameset(bool) = 0; // Can change due to navigation or DOM modification.
virtual bool canCachePage() const = 0;
- virtual void download(ResourceHandle*, const ResourceRequest&, const ResourceResponse&) = 0;
+ virtual void convertMainResourceLoadToDownload(MainResourceLoader*, const ResourceRequest&, const ResourceResponse&) = 0;
virtual PassRefPtr<Frame> createFrame(const KURL& url, const String& name, HTMLFrameOwnerElement* ownerElement, const String& referrer, bool allowsScrolling, int marginWidth, int marginHeight) = 0;
virtual PassRefPtr<Widget> createPlugin(const IntSize&, HTMLPlugInElement*, const KURL&, const Vector<String>&, const Vector<String>&, const String&, bool loadManually) = 0;
ResourceRequest request = this->request();
frameLoader()->setOriginalURLForDownloadRequest(request);
- frameLoader()->client()->download(loader()->handle(), request, r);
+ frameLoader()->client()->convertMainResourceLoadToDownload(this, request, r);
// It might have gone missing
if (frameLoader())
void loadString(const BlackBerry::Platform::String&, const BlackBerry::Platform::String& baseURL, const BlackBerry::Platform::String& contentType = "text/html", const BlackBerry::Platform::String& failingURL = BlackBerry::Platform::String::emptyString());
- void download(const Platform::NetworkRequest&);
+ void convertMainResourceLoadToDownload(const Platform::NetworkRequest&);
bool executeJavaScript(const BlackBerry::Platform::String& script, JavaScriptDataType& returnType, BlackBerry::Platform::String& returnValue);
+2012-12-15 Anders Carlsson <andersca@apple.com>
+
+ Rename FrameLoaderClient::download to convertMainResourceLoadToDownload
+ https://bugs.webkit.org/show_bug.cgi?id=105122
+
+ Reviewed by Andreas Kling.
+
+ Update for WebCore changes.
+
+ * Api/WebPage.h:
+ * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+ (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
+ * WebCoreSupport/FrameLoaderClientBlackBerry.h:
+ (FrameLoaderClientBlackBerry):
+
2012-12-16 Jacky Jiang <zhajiang@rim.com>
[BlackBerry] GUIMark3 page is rendered at a large scale during history navigation back
#include "Image.h"
#include "InputHandler.h"
#include "MIMETypeRegistry.h"
+#include "MainResourceLoader.h"
#include "NativeImageSkia.h"
#include "NetworkManager.h"
#include "NodeList.h"
m_webPagePrivate->load(request.url().string(), BlackBerry::Platform::String::emptyString(), "GET", NetworkRequest::UseProtocolCachePolicy, 0, 0, 0, 0, false, false, true, "", suggestedName);
}
-void FrameLoaderClientBlackBerry::download(ResourceHandle* handle, const ResourceRequest&, const ResourceRequest&, const ResourceResponse& r)
+void FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload(MainResourceLoader* mainResourceLoader, const ResourceRequest&, const ResourceRequest&, const ResourceResponse& r)
{
- BlackBerry::Platform::FilterStream* stream = NetworkManager::instance()->streamForHandle(handle);
+ BlackBerry::Platform::FilterStream* stream = NetworkManager::instance()->streamForHandle(mainResourceLoader->loader()->handle());
ASSERT(stream);
m_webPagePrivate->m_client->downloadRequested(stream, r.suggestedFilename());
virtual void didSaveToPageCache();
virtual void didRestoreFromPageCache();
virtual void dispatchDidBecomeFrameset(bool) { }
- virtual void download(ResourceHandle*, const ResourceRequest&, const ResourceRequest&, const ResourceResponse&);
+ virtual void convertMainResourceLoadToDownload(MainResourceLoader*, const ResourceRequest&, const ResourceRequest&, const ResourceResponse&);
virtual PassRefPtr<Frame> createFrame(const KURL&, const String&, HTMLFrameOwnerElement*, const String&, bool, int, int);
virtual PassRefPtr<Widget> createPlugin(const IntSize&, HTMLPlugInElement*, const KURL&, const Vector<String>&, const Vector<String>&, const String&, bool);
virtual void redirectDataToPlugin(Widget*);
+2012-12-15 Anders Carlsson <andersca@apple.com>
+
+ Rename FrameLoaderClient::download to convertMainResourceLoadToDownload
+ https://bugs.webkit.org/show_bug.cgi?id=105122
+
+ Reviewed by Andreas Kling.
+
+ Update for WebCore changes.
+
+ * src/FrameLoaderClientImpl.cpp:
+ (WebKit::FrameLoaderClientImpl::convertMainResourceLoadToDownload):
+ * src/FrameLoaderClientImpl.h:
+ (FrameLoaderClientImpl):
+
2012-12-15 Simon Fraser <simon.fraser@apple.com>
Fix repaint issues when resizing a window with centered content, for platforms with a tile cache
// Downloading is handled in the browser process, not WebKit. If we get to this
// point, our download detection code in the ResourceDispatcherHost is broken!
-void FrameLoaderClientImpl::download(ResourceHandle* handle,
+void FrameLoaderClientImpl::convertMainResourceLoadToDownload(MainResourceLoader* mainResourceLoader,
const ResourceRequest& request,
const ResourceResponse& response)
{
virtual void didRestoreFromPageCache();
virtual void dispatchDidBecomeFrameset(bool);
virtual bool canCachePage() const;
- virtual void download(
- WebCore::ResourceHandle*, const WebCore::ResourceRequest&,
+ virtual void convertMainResourceLoadToDownload(
+ WebCore::MainResourceLoader*, const WebCore::ResourceRequest&,
const WebCore::ResourceResponse&);
virtual PassRefPtr<WebCore::Frame> createFrame(
const WebCore::KURL& url, const WTF::String& name,
+2012-12-15 Anders Carlsson <andersca@apple.com>
+
+ Rename FrameLoaderClient::download to convertMainResourceLoadToDownload
+ https://bugs.webkit.org/show_bug.cgi?id=105122
+
+ Reviewed by Andreas Kling.
+
+ Update for WebCore changes.
+
+ * WebCoreSupport/FrameLoaderClientEfl.cpp:
+ (WebCore::FrameLoaderClientEfl::convertMainResourceLoadToDownload):
+ * WebCoreSupport/FrameLoaderClientEfl.h:
+ (FrameLoaderClientEfl):
+
2012-12-15 Mark Lam <mark.lam@apple.com>
Re-landing patch for "Introducing the DatabaseStrategy and database servers".
err.failingURL().utf8().data());
}
-void FrameLoaderClientEfl::download(ResourceHandle*, const ResourceRequest& request, const ResourceResponse&)
+void FrameLoaderClientEfl::convertMainResourceLoadToDownload(MainResourceLoader*, const ResourceRequest& request, const ResourceResponse&)
{
if (!m_view)
return;
virtual void dispatchDidBecomeFrameset(bool);
virtual bool canCachePage() const;
- virtual void download(ResourceHandle*, const ResourceRequest&, const ResourceResponse&);
+ virtual void convertMainResourceLoadToDownload(MainResourceLoader*, const ResourceRequest&, const ResourceResponse&);
virtual PassRefPtr<WebCore::FrameNetworkingContext> createNetworkingContext();
private:
+2012-12-15 Anders Carlsson <andersca@apple.com>
+
+ Rename FrameLoaderClient::download to convertMainResourceLoadToDownload
+ https://bugs.webkit.org/show_bug.cgi?id=105122
+
+ Reviewed by Andreas Kling.
+
+ Update for WebCore changes.
+
+ * WebCoreSupport/FrameLoaderClientGtk.cpp:
+ (WebKit::FrameLoaderClient::convertMainResourceLoadToDownload):
+ * WebCoreSupport/FrameLoaderClientGtk.h:
+ (FrameLoaderClient):
+
2012-12-15 Mark Lam <mark.lam@apple.com>
Re-landing patch for "Introducing the DatabaseStrategy and database servers".
#include "JSDOMWindow.h"
#include "Language.h"
#include "MIMETypeRegistry.h"
+#include "MainResourceLoader.h"
#include "MouseEvent.h"
#include "NotImplemented.h"
#include "Page.h"
g_error_free(webError);
}
-void FrameLoaderClient::download(ResourceHandle* handle, const ResourceRequest& request, const ResourceResponse& response)
+void FrameLoaderClient::convertMainResourceLoadToDownload(MainResourceLoader* mainResourceLoader, const ResourceRequest& request, const ResourceResponse& response)
{
GRefPtr<WebKitNetworkRequest> networkRequest(adoptGRef(kitNew(request)));
WebKitWebView* view = getViewFromFrame(m_frame);
- webkit_web_view_request_download(view, networkRequest.get(), response, handle);
+ webkit_web_view_request_download(view, networkRequest.get(), response, mainResourceLoader->loader()->handle());
}
ResourceError FrameLoaderClient::cancelledError(const ResourceRequest& request)
virtual void dispatchDidBecomeFrameset(bool);
virtual bool canCachePage() const;
- virtual void download(WebCore::ResourceHandle*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&);
+ virtual void convertMainResourceLoadToDownload(WebCore::MainResourceLoader*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&);
virtual PassRefPtr<WebCore::FrameNetworkingContext> createNetworkingContext();
+2012-12-15 Anders Carlsson <andersca@apple.com>
+
+ Rename FrameLoaderClient::download to convertMainResourceLoadToDownload
+ https://bugs.webkit.org/show_bug.cgi?id=105122
+
+ Reviewed by Andreas Kling.
+
+ Update for WebCore changes.
+
+ * WebCoreSupport/WebFrameLoaderClient.h:
+ (WebFrameLoaderClient):
+ * WebCoreSupport/WebFrameLoaderClient.mm:
+ (WebFrameLoaderClient::convertMainResourceLoadToDownload):
+
2012-12-15 Mark Lam <mark.lam@apple.com>
Re-landing patch for "Introducing the DatabaseStrategy and database servers".
virtual void detachedFromParent2() OVERRIDE;
virtual void detachedFromParent3() OVERRIDE;
- virtual void download(WebCore::ResourceHandle*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&) OVERRIDE;
+ virtual void convertMainResourceLoadToDownload(WebCore::MainResourceLoader*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&) OVERRIDE;
virtual void assignIdentifierToInitialRequest(unsigned long identifier, WebCore::DocumentLoader*, const WebCore::ResourceRequest&) OVERRIDE;
#import <WebCore/IconDatabase.h>
#import <WebCore/LoaderNSURLExtras.h>
#import <WebCore/MIMETypeRegistry.h>
+#import <WebCore/MainResourceLoader.h>
#import <WebCore/MouseEvent.h>
#import <WebCore/Page.h>
#import <WebCore/PluginViewBase.h>
m_webFrame->_private->webFrameView = nil;
}
-void WebFrameLoaderClient::download(ResourceHandle* handle, const ResourceRequest& request, const ResourceResponse& response)
+void WebFrameLoaderClient::convertMainResourceLoadToDownload(MainResourceLoader* mainResourceLoader, const ResourceRequest& request, const ResourceResponse& response)
{
+ ResourceHandle* handle = mainResourceLoader->loader()->handle();
+
#if USE(CFNETWORK)
ASSERT([WebDownload respondsToSelector:@selector(_downloadWithLoadingCFURLConnection:request:response:delegate:proxy:)]);
WebView *webView = getWebView(m_webFrame.get());
+2012-12-15 Anders Carlsson <andersca@apple.com>
+
+ Rename FrameLoaderClient::download to convertMainResourceLoadToDownload
+ https://bugs.webkit.org/show_bug.cgi?id=105122
+
+ Reviewed by Andreas Kling.
+
+ Update for WebCore changes.
+
+ * WebCoreSupport/FrameLoaderClientQt.cpp:
+ (WebCore::FrameLoaderClientQt::convertMainResourceLoadToDownload):
+ * WebCoreSupport/FrameLoaderClientQt.h:
+ (FrameLoaderClientQt):
+
2012-12-15 Mark Lam <mark.lam@apple.com>
Re-landing patch for "Introducing the DatabaseStrategy and database servers".
#endif
#include "JSDOMWindowBase.h"
#include "MIMETypeRegistry.h"
+#include "MainResourceLoader.h"
#include "MouseEvent.h"
#include "NotImplemented.h"
#include "Page.h"
return loader.release();
}
-void FrameLoaderClientQt::download(WebCore::ResourceHandle* handle, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&)
+void FrameLoaderClientQt::convertMainResourceLoadToDownload(WebCore::MainResourceLoader* mainResourceLoader, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&)
{
if (!m_webFrame)
return;
- QNetworkReplyHandler* handler = handle->getInternal()->m_job;
+ QNetworkReplyHandler* handler = mainResourceLoader->loader()->handle()->getInternal()->m_job;
QNetworkReply* reply = handler->release();
if (reply) {
if (m_webFrame->pageAdapter->forwardUnsupportedContent)
virtual void dispatchDidBecomeFrameset(bool);
virtual bool canCachePage() const;
- virtual void download(WebCore::ResourceHandle*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&);
+ virtual void convertMainResourceLoadToDownload(WebCore::MainResourceLoader*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&);
virtual PassRefPtr<Frame> createFrame(const KURL&, const String& name, HTMLFrameOwnerElement*, const String& referrer, bool allowsScrolling, int marginWidth, int marginHeight);
virtual PassRefPtr<Widget> createPlugin(const IntSize&, HTMLPlugInElement*, const KURL&, const Vector<String>&, const Vector<String>&, const String&, bool);
+2012-12-15 Anders Carlsson <andersca@apple.com>
+
+ Rename FrameLoaderClient::download to convertMainResourceLoadToDownload
+ https://bugs.webkit.org/show_bug.cgi?id=105122
+
+ Reviewed by Andreas Kling.
+
+ Update for WebCore changes.
+
+ * WebFrame.cpp:
+ (WebFrame::convertMainResourceLoadToDownload):
+ * WebFrame.h:
+
2012-12-15 Mark Lam <mark.lam@apple.com>
Re-landing patch for "Introducing the DatabaseStrategy and database servers".
#include <WebCore/HTMLPlugInElement.h>
#include <WebCore/JSDOMWindow.h>
#include <WebCore/KeyboardEvent.h>
+#include <WebCore/MainResourceLoader.h>
#include <WebCore/MouseRelatedEvent.h>
#include <WebCore/NotImplemented.h>
#include <WebCore/Page.h>
policyDelegate->unableToImplementPolicyWithError(d->webView, webError.get(), this);
}
-void WebFrame::download(ResourceHandle* handle, const ResourceRequest& request, const ResourceResponse& response)
+void WebFrame::convertMainResourceLoadToDownload(MainResourceLoader* mainResourceLoader, const ResourceRequest& request, const ResourceResponse& response)
{
COMPtr<IWebDownloadDelegate> downloadDelegate;
COMPtr<IWebView> webView;
// Its the delegate's job to ref the WebDownload to keep it alive - otherwise it will be destroyed
// when this method returns
COMPtr<WebDownload> download;
- download.adoptRef(WebDownload::createInstance(handle, request, response, downloadDelegate.get()));
+ download.adoptRef(WebDownload::createInstance(mainResourceLoader->loader()->handle(), request, response, downloadDelegate.get()));
}
bool WebFrame::dispatchDidLoadResourceFromMemoryCache(DocumentLoader*, const ResourceRequest&, const ResourceResponse&, int /*length*/)
virtual void dispatchDecidePolicyForNewWindowAction(WebCore::FramePolicyFunction, const WebCore::NavigationAction&, const WebCore::ResourceRequest&, PassRefPtr<WebCore::FormState>, const WTF::String& frameName);
virtual void dispatchDecidePolicyForNavigationAction(WebCore::FramePolicyFunction, const WebCore::NavigationAction&, const WebCore::ResourceRequest&, PassRefPtr<WebCore::FormState>);
virtual void dispatchUnableToImplementPolicy(const WebCore::ResourceError&);
- virtual void download(WebCore::ResourceHandle*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&);
+ virtual void convertMainResourceLoadToDownload(WebCore::MainResourceLoader*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&);
virtual bool dispatchDidLoadResourceFromMemoryCache(WebCore::DocumentLoader*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&, int length);
virtual void dispatchDidFailProvisionalLoad(const WebCore::ResourceError&);
+2012-12-15 Anders Carlsson <andersca@apple.com>
+
+ Rename FrameLoaderClient::download to convertMainResourceLoadToDownload
+ https://bugs.webkit.org/show_bug.cgi?id=105122
+
+ Reviewed by Andreas Kling.
+
+ Update for WebCore changes.
+
+ * WebCoreSupport/FrameLoaderClientWinCE.cpp:
+ (WebKit::FrameLoaderClientWinCE::convertMainResourceLoadToDownload):
+ * WebCoreSupport/FrameLoaderClientWinCE.h:
+ (FrameLoaderClientWinCE):
+
2012-12-15 Mark Lam <mark.lam@apple.com>
Re-landing patch for "Introducing the DatabaseStrategy and database servers".
notImplemented();
}
-void FrameLoaderClientWinCE::download(ResourceHandle*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&)
+void FrameLoaderClientWinCE::convertMainResourceLoadToDownload(WebCore::MainResourceLoader*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&)
{
notImplemented();
}
virtual void dispatchDidBecomeFrameset(bool);
virtual bool canCachePage() const;
- virtual void download(WebCore::ResourceHandle*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&);
+ virtual void convertMainResourceLoadToDownload(WebCore::MainResourceLoader*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&);
virtual PassRefPtr<WebCore::FrameNetworkingContext> createNetworkingContext();
+2012-12-15 Anders Carlsson <andersca@apple.com>
+
+ Rename FrameLoaderClient::download to convertMainResourceLoadToDownload
+ https://bugs.webkit.org/show_bug.cgi?id=105122
+
+ Reviewed by Andreas Kling.
+
+ Update for WebCore changes.
+
+ * WebKitSupport/FrameLoaderClientWx.cpp:
+ (WebCore::FrameLoaderClientWx::convertMainResourceLoadToDownload):
+ * WebKitSupport/FrameLoaderClientWx.h:
+ (FrameLoaderClientWx):
+
2012-12-12 Mark Lam <mark.lam@apple.com>
Encapsulate externally used webdatabase APIs in DatabaseManager.
return DocumentLoader::create(request, substituteData);
}
-void FrameLoaderClientWx::download(ResourceHandle*, const ResourceRequest&, const ResourceResponse&)
+void FrameLoaderClientWx::convertMainResourceLoadToDownload(WebCore::MainResourceLoader*, const ResourceRequest&, const ResourceResponse&)
{
notImplemented();
}
virtual ResourceError fileDoesNotExistError(const ResourceResponse&);
virtual bool shouldFallBack(const ResourceError&);
virtual WTF::PassRefPtr<DocumentLoader> createDocumentLoader(const ResourceRequest&, const SubstituteData&);
- virtual void download(ResourceHandle*, const ResourceRequest&, const ResourceResponse&);
+ virtual void convertMainResourceLoadToDownload(MainResourceLoader*, const ResourceRequest&, const ResourceResponse&);
virtual void assignIdentifierToInitialRequest(unsigned long identifier, DocumentLoader*, const ResourceRequest&);
2012-12-15 Anders Carlsson <andersca@apple.com>
+ Rename FrameLoaderClient::download to convertMainResourceLoadToDownload
+ https://bugs.webkit.org/show_bug.cgi?id=105122
+
+ Reviewed by Andreas Kling.
+
+ Update for WebCore changes.
+
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+ (WebKit::WebFrameLoaderClient::convertMainResourceLoadToDownload):
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
+ (WebFrameLoaderClient):
+
+2012-12-15 Anders Carlsson <andersca@apple.com>
+
Another build fix.
* UIProcess/WebContext.cpp:
#include <WebCore/HTMLFormElement.h>
#include <WebCore/HistoryItem.h>
#include <WebCore/MIMETypeRegistry.h>
+#include <WebCore/MainResourceLoader.h>
#include <WebCore/MouseEvent.h>
#include <WebCore/NotImplemented.h>
#include <WebCore/Page.h>
return !m_frameHasCustomRepresentation;
}
-void WebFrameLoaderClient::download(ResourceHandle* handle, const ResourceRequest& request, const ResourceResponse& response)
+void WebFrameLoaderClient::convertMainResourceLoadToDownload(MainResourceLoader *mainResourceLoader, const ResourceRequest& request, const ResourceResponse& response)
{
- m_frame->convertHandleToDownload(handle, request, response);
+ m_frame->convertHandleToDownload(mainResourceLoader->loader()->handle(), request, response);
}
PassRefPtr<Frame> WebFrameLoaderClient::createFrame(const KURL& url, const String& name, HTMLFrameOwnerElement* ownerElement,
virtual void dispatchDidBecomeFrameset(bool) OVERRIDE;
virtual bool canCachePage() const OVERRIDE;
- virtual void download(WebCore::ResourceHandle*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&) OVERRIDE;
+ virtual void convertMainResourceLoadToDownload(WebCore::MainResourceLoader*, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&) OVERRIDE;
virtual PassRefPtr<WebCore::Frame> createFrame(const WebCore::KURL& url, const String& name, WebCore::HTMLFrameOwnerElement* ownerElement,
const String& referrer, bool allowsScrolling, int marginWidth, int marginHeight) OVERRIDE;