Remove Adobe SSO exception now that StorageAccess API is available
authorbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 18 Aug 2018 00:09:32 +0000 (00:09 +0000)
committerbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 18 Aug 2018 00:09:32 +0000 (00:09 +0000)
https://bugs.webkit.org/show_bug.cgi?id=188710
<rdar://problem/35056707>

Reviewed by Alex Christensen.

Remove custom quirk now that proper API exists to allow the same functions.

* loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::logSubresourceLoading): Remove unneeded quirk.
(WebCore::resourceNeedsSSOQuirk): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/loader/ResourceLoadObserver.cpp

index fced65a..7b95b72 100644 (file)
@@ -1,3 +1,17 @@
+2018-08-17  Brent Fulgham  <bfulgham@apple.com>
+
+        Remove Adobe SSO exception now that StorageAccess API is available
+        https://bugs.webkit.org/show_bug.cgi?id=188710
+        <rdar://problem/35056707>
+
+        Reviewed by Alex Christensen.
+
+        Remove custom quirk now that proper API exists to allow the same functions.
+
+        * loader/ResourceLoadObserver.cpp:
+        (WebCore::ResourceLoadObserver::logSubresourceLoading): Remove unneeded quirk.
+        (WebCore::resourceNeedsSSOQuirk): Deleted.
+
 2018-08-17  Ryosuke Niwa  <rniwa@webkit.org>
 
         Replace canBubble and cancelable booleans in Event by enum classes
index 8b9836e..511b912 100644 (file)
@@ -104,15 +104,6 @@ bool ResourceLoadObserver::shouldLog(Page* page) const
     return DeprecatedGlobalSettings::resourceLoadStatisticsEnabled() && !page->usesEphemeralSession() && m_notificationCallback;
 }
 
-// FIXME: This quirk was added to address <rdar://problem/33325881> and should be removed once content is fixed.
-static bool resourceNeedsSSOQuirk(Page* page, const URL& url)
-{
-    if (!shouldEnableSiteSpecificQuirks(page))
-        return false;
-
-    return equalIgnoringASCIICase(url.host(), "sp.auth.adobe.com");
-}
-
 void ResourceLoadObserver::logSubresourceLoading(const Frame* frame, const ResourceRequest& newRequest, const ResourceResponse& redirectResponse)
 {
     ASSERT(frame->page());
@@ -139,9 +130,6 @@ void ResourceLoadObserver::logSubresourceLoading(const Frame* frame, const Resou
     if (areDomainsAssociated(page, targetPrimaryDomain, mainFramePrimaryDomain) || (isRedirect && areDomainsAssociated(page, targetPrimaryDomain, sourcePrimaryDomain)))
         return;
 
-    if (resourceNeedsSSOQuirk(page, targetURL))
-        return;
-
     bool shouldCallNotificationCallback = false;
     {
         auto& targetStatistics = ensureResourceStatisticsForPrimaryDomain(targetPrimaryDomain);