[CMake] Use lowercase for local variables in macros
authormcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 22 Apr 2015 19:01:37 +0000 (19:01 +0000)
committermcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 22 Apr 2015 19:01:37 +0000 (19:01 +0000)
https://bugs.webkit.org/show_bug.cgi?id=144059

Reviewed by Martin Robinson.

Convert some variable names to lowercase.

* Source/cmake/WebKitFeatures.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@183120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
Source/cmake/WebKitFeatures.cmake

index 2c2acc7..341cea4 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [CMake] Use lowercase for local variables in macros
+        https://bugs.webkit.org/show_bug.cgi?id=144059
+
+        Reviewed by Martin Robinson.
+
+        Convert some variable names to lowercase.
+
+        * Source/cmake/WebKitFeatures.cmake:
+
 2015-04-22  Commit Queue  <commit-queue@webkit.org>
 
         Unreviewed, rolling out r183116.
index 54fe327..423852e 100644 (file)
@@ -168,9 +168,9 @@ macro(WEBKIT_OPTION_END)
     list(SORT _WEBKIT_AVAILABLE_OPTIONS)
     set(_MAX_FEATURE_LENGTH 0)
     foreach (_name ${_WEBKIT_AVAILABLE_OPTIONS})
-        string(LENGTH ${_name} _NAME_LENGTH)
-        if (_NAME_LENGTH GREATER _MAX_FEATURE_LENGTH)
-            set(_MAX_FEATURE_LENGTH ${_NAME_LENGTH})
+        string(LENGTH ${_name} _name_length)
+        if (_name_length GREATER _MAX_FEATURE_LENGTH)
+            set(_MAX_FEATURE_LENGTH ${_name_length})
         endif ()
 
         option(${_name} "${_WEBKIT_AVAILABLE_OPTIONS_DESCRIPTION_${_name}}" ${_WEBKIT_AVAILABLE_OPTIONS_INITIAL_VALUE_${_name}})
@@ -195,25 +195,25 @@ endmacro()
 macro(PRINT_WEBKIT_OPTIONS)
     message(STATUS "Enabled features:")
 
-    set(_SHOULD_PRINT_DOTS ON)
+    set(_should_print_dots ON)
     foreach (_name ${_WEBKIT_AVAILABLE_OPTIONS})
         if (${_WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name}})
-            string(LENGTH ${_name} _NAME_LENGTH)
-            set(_MESSAGE " ${_name} ")
+            string(LENGTH ${_name} _name_length)
+            set(_message " ${_name} ")
 
             # Print dots on every other row, for readability.
-            foreach (IGNORE RANGE ${_NAME_LENGTH} ${_MAX_FEATURE_LENGTH})
-                if (${_SHOULD_PRINT_DOTS})
-                    set(_MESSAGE "${_MESSAGE}.")
+            foreach (IGNORE RANGE ${_name_length} ${_MAX_FEATURE_LENGTH})
+                if (${_should_print_dots})
+                    set(_message "${_message}.")
                 else ()
-                    set(_MESSAGE "${_MESSAGE} ")
+                    set(_message "${_message} ")
                 endif ()
             endforeach ()
 
-            set(_SHOULD_PRINT_DOTS (NOT ${_SHOULD_PRINT_DOTS}))
+            set(_should_print_dots (NOT ${_should_print_dots}))
 
-            set(_MESSAGE "${_MESSAGE} ${${_name}}")
-            message(STATUS "${_MESSAGE}")
+            set(_message "${_message} ${${_name}}")
+            message(STATUS "${_message}")
         endif ()
     endforeach ()
 endmacro()