Web Inspector: remove Node parameter from the InspectorClient::highlight
authorpfeldman@chromium.org <pfeldman@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 3 Aug 2011 08:28:40 +0000 (08:28 +0000)
committerpfeldman@chromium.org <pfeldman@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 3 Aug 2011 08:28:40 +0000 (08:28 +0000)
https://bugs.webkit.org/show_bug.cgi?id=65549

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-08-03
Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/InspectorClient.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlight):
* loader/EmptyClients.h:
(WebCore::EmptyInspectorClient::highlight):

Source/WebKit/chromium:

* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::highlight):
* src/InspectorClientImpl.h:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::highlight):
* src/WebDevToolsAgentImpl.h:

Source/WebKit/efl:

* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::highlight):
* WebCoreSupport/InspectorClientEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::highlight):
* WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/haiku:

* WebCoreSupport/InspectorClientHaiku.cpp:
(WebCore::InspectorClientHaiku::highlight):
* WebCoreSupport/InspectorClientHaiku.h:

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::highlight):
* WebInspector/WebNodeHighlighter.h:
* WebInspector/WebNodeHighlighter.mm:
(-[WebNodeHighlighter highlight]):

Source/WebKit/qt:

* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::highlight):
* WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::highlight):
* WebCoreSupport/WebInspectorClient.h:

Source/WebKit/wince:

* WebCoreSupport/InspectorClientWinCE.cpp:
(WebKit::InspectorClientWinCE::highlight):
* WebCoreSupport/InspectorClientWinCE.h:

Source/WebKit/wx:

* WebKitSupport/InspectorClientWx.cpp:
(WebCore::InspectorClientWx::highlight):
* WebKitSupport/InspectorClientWx.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight):
* WebProcess/WebCoreSupport/WebInspectorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

38 files changed:
Source/WebCore/ChangeLog
Source/WebCore/inspector/InspectorClient.h
Source/WebCore/inspector/InspectorDOMAgent.cpp
Source/WebCore/loader/EmptyClients.h
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/InspectorClientImpl.cpp
Source/WebKit/chromium/src/InspectorClientImpl.h
Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp
Source/WebKit/chromium/src/WebDevToolsAgentImpl.h
Source/WebKit/efl/ChangeLog
Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp
Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h
Source/WebKit/gtk/ChangeLog
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h
Source/WebKit/haiku/ChangeLog
Source/WebKit/haiku/WebCoreSupport/InspectorClientHaiku.cpp
Source/WebKit/haiku/WebCoreSupport/InspectorClientHaiku.h
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h
Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm
Source/WebKit/mac/WebInspector/WebNodeHighlighter.h
Source/WebKit/mac/WebInspector/WebNodeHighlighter.mm
Source/WebKit/qt/ChangeLog
Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp
Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h
Source/WebKit/win/ChangeLog
Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp
Source/WebKit/win/WebCoreSupport/WebInspectorClient.h
Source/WebKit/wince/ChangeLog
Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.cpp
Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h
Source/WebKit/wx/ChangeLog
Source/WebKit/wx/WebKitSupport/InspectorClientWx.cpp
Source/WebKit/wx/WebKitSupport/InspectorClientWx.h
Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp
Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h

index aaf71d1..6d72791 100644 (file)
@@ -1,3 +1,16 @@
+2011-08-03  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: remove Node parameter from the InspectorClient::highlight
+        https://bugs.webkit.org/show_bug.cgi?id=65549
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/InspectorClient.h:
+        * inspector/InspectorDOMAgent.cpp:
+        (WebCore::InspectorDOMAgent::highlight):
+        * loader/EmptyClients.h:
+        (WebCore::EmptyInspectorClient::highlight):
+
 2011-08-03  Antti Koivisto  <antti@apple.com>
 
         https://bugs.webkit.org/show_bug.cgi?id=65599
index a2b1d24..93b5b10 100644 (file)
@@ -44,7 +44,7 @@ public:
 
     virtual void openInspectorFrontend(InspectorController*) = 0;
 
-    virtual void highlight(Node*) = 0;
+    virtual void highlight() = 0;
     virtual void hideHighlight() = 0;
 
     // Navigation can cause some WebKit implementations to change the view / page / inspector controller instance.
index 6a1b150..d349734 100644 (file)
@@ -1009,7 +1009,7 @@ void InspectorDOMAgent::highlight(ErrorString*, Node* node, const String& mode)
     ASSERT_ARG(node, node);
     m_highlightedNode = node;
     m_highlightMode = mode;
-    m_client->highlight(node);
+    m_client->highlight();
 }
 
 void InspectorDOMAgent::highlightNode(ErrorString* error, int nodeId, String* mode)
index f2dc8a4..b409756 100644 (file)
@@ -589,7 +589,7 @@ public:
     
     virtual void openInspectorFrontend(InspectorController*) { }
 
-    virtual void highlight(Node*) { }
+    virtual void highlight() { }
     virtual void hideHighlight() { }
 
     virtual bool sendMessageToFrontend(const String&) { return false; }
index beb68e3..2b9395e 100644 (file)
@@ -1,3 +1,17 @@
+2011-08-03  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: remove Node parameter from the InspectorClient::highlight
+        https://bugs.webkit.org/show_bug.cgi?id=65549
+
+        Reviewed by Yury Semikhatsky.
+
+        * src/InspectorClientImpl.cpp:
+        (WebKit::InspectorClientImpl::highlight):
+        * src/InspectorClientImpl.h:
+        * src/WebDevToolsAgentImpl.cpp:
+        (WebKit::WebDevToolsAgentImpl::highlight):
+        * src/WebDevToolsAgentImpl.h:
+
 2011-08-02  David Reveman  <reveman@chromium.org>
 
         [Chromium] Remove outer border from TilingData as it's no longer needed by layer compositor for anti-aliasing.
index 0f59454..18e4045 100644 (file)
@@ -69,10 +69,10 @@ void InspectorClientImpl::openInspectorFrontend(InspectorController* controller)
         agent->openInspectorFrontend(controller);
 }
 
-void InspectorClientImpl::highlight(Node* node)
+void InspectorClientImpl::highlight()
 {
     if (WebDevToolsAgentImpl* agent = devToolsAgent())
-        agent->highlight(node);
+        agent->highlight();
 }
 
 void InspectorClientImpl::hideHighlight()
index 2b3a80b..fd3339a 100644 (file)
@@ -50,7 +50,7 @@ public:
     virtual void inspectorDestroyed();
     virtual void openInspectorFrontend(WebCore::InspectorController*);
 
-    virtual void highlight(WebCore::Node*);
+    virtual void highlight();
     virtual void hideHighlight();
 
     virtual bool sendMessageToFrontend(const WTF::String&);
index a953dc2..57419b7 100644 (file)
@@ -282,7 +282,7 @@ void WebDevToolsAgentImpl::paintPageOverlay(GraphicsContext& gc)
         ic->drawNodeHighlight(gc);
 }
 
-void WebDevToolsAgentImpl::highlight(Node* node)
+void WebDevToolsAgentImpl::highlight()
 {
     m_webViewImpl->setPageOverlayClient(this);
 }
index 4f3d022..3e335a3 100644 (file)
@@ -86,7 +86,7 @@ public:
     // InspectorClient implementation.
     virtual void inspectorDestroyed();
     virtual void openInspectorFrontend(WebCore::InspectorController*);
-    virtual void highlight(WebCore::Node*);
+    virtual void highlight();
     virtual void hideHighlight();
     virtual void updateInspectorStateCookie(const WTF::String&);
     virtual bool sendMessageToFrontend(const WTF::String&);
index 0d15cf1..6eb0447 100755 (executable)
@@ -1,3 +1,14 @@
+2011-08-03  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: remove Node parameter from the InspectorClient::highlight
+        https://bugs.webkit.org/show_bug.cgi?id=65549
+
+        Reviewed by Yury Semikhatsky.
+
+        * WebCoreSupport/InspectorClientEfl.cpp:
+        (WebCore::InspectorClientEfl::highlight):
+        * WebCoreSupport/InspectorClientEfl.h:
+
 2011-08-02  Raphael Kubo da Costa  <kubo@profusion.mobi>
 
         [EFL] Ignore empty requests on policy decisions.
index 6bfd6ad..061c4b1 100644 (file)
@@ -38,7 +38,7 @@ void InspectorClientEfl::openInspectorFrontend(InspectorController*)
     notImplemented();
 }
 
-void InspectorClientEfl::highlight(Node* node)
+void InspectorClientEfl::highlight()
 {
     notImplemented();
 }
index 0c283d8..7ea7d69 100644 (file)
@@ -36,7 +36,6 @@
 #include <wtf/Forward.h>
 
 namespace WebCore {
-class Node;
 class Page;
 
 class InspectorClientEfl : public WebCore::InspectorClient {
@@ -45,7 +44,7 @@ public:
 
     virtual void openInspectorFrontend(InspectorController*);
 
-    virtual void highlight(Node*);
+    virtual void highlight();
     virtual void hideHighlight();
 
     virtual void populateSetting(const String& key, String* value);
index 4a121b6..e76285d 100644 (file)
@@ -1,3 +1,14 @@
+2011-08-03  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: remove Node parameter from the InspectorClient::highlight
+        https://bugs.webkit.org/show_bug.cgi?id=65549
+
+        Reviewed by Yury Semikhatsky.
+
+        * WebCoreSupport/InspectorClientGtk.cpp:
+        (WebKit::InspectorClient::highlight):
+        * WebCoreSupport/InspectorClientGtk.h:
+
 2011-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [GTK] Reorganize pkg-config files
index 82b28e6..8fd019f 100644 (file)
@@ -161,7 +161,7 @@ void InspectorClient::releaseFrontendPage()
     m_frontendPage = 0;
 }
 
-void InspectorClient::highlight(Node*)
+void InspectorClient::highlight()
 {
     hideHighlight();
 }
index fb8c735..309a1fe 100644 (file)
@@ -37,7 +37,6 @@
 #include <wtf/Forward.h>
 
 namespace WebCore {
-    class Node;
     class Page;
 }
 
@@ -56,7 +55,7 @@ namespace WebKit {
 
         virtual void openInspectorFrontend(WebCore::InspectorController*);
 
-        virtual void highlight(WebCore::Node*);
+        virtual void highlight();
         virtual void hideHighlight();
 
         virtual bool sendMessageToFrontend(const WTF::String&);
index 1f19be8..02a5f00 100644 (file)
@@ -1,3 +1,14 @@
+2011-08-03  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: remove Node parameter from the InspectorClient::highlight
+        https://bugs.webkit.org/show_bug.cgi?id=65549
+
+        Reviewed by Yury Semikhatsky.
+
+        * WebCoreSupport/InspectorClientHaiku.cpp:
+        (WebCore::InspectorClientHaiku::highlight):
+        * WebCoreSupport/InspectorClientHaiku.h:
+
 2011-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
 
         Add support for download='filename' attribute in anchors.
index 883fcd3..50b8f49 100644 (file)
@@ -47,7 +47,7 @@ void InspectorClientHaiku::openInspectorFrontend(WebCore::InspectorController*)
     notImplemented();
 }
 
-void InspectorClientHaiku::highlight(Node* node)
+void InspectorClientHaiku::highlight()
 {
     notImplemented();
 }
index d6df4c6..0e6e4de 100644 (file)
@@ -43,7 +43,7 @@ namespace WebCore {
 
         virtual void openInspectorFrontend(WebCore::InspectorController*);
 
-        virtual void highlight(Node*);
+        virtual void highlight();
         virtual void hideHighlight();
 
         virtual void populateSetting(const WTF::String& key, WTF::String* value);
index f65cde2..8a80a84 100644 (file)
@@ -1,3 +1,17 @@
+2011-08-03  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: remove Node parameter from the InspectorClient::highlight
+        https://bugs.webkit.org/show_bug.cgi?id=65549
+
+        Reviewed by Yury Semikhatsky.
+
+        * WebCoreSupport/WebInspectorClient.h:
+        * WebCoreSupport/WebInspectorClient.mm:
+        (WebInspectorClient::highlight):
+        * WebInspector/WebNodeHighlighter.h:
+        * WebInspector/WebNodeHighlighter.mm:
+        (-[WebNodeHighlighter highlight]):
+
 2011-07-30  Patrick Gansterer  <paroga@webkit.org>
 
         Remove inclusion of MainThread.h from Threading.h
index 7d09109..f9cee65 100644 (file)
@@ -59,7 +59,7 @@ public:
 
     virtual void openInspectorFrontend(WebCore::InspectorController*);
 
-    virtual void highlight(WebCore::Node*);
+    virtual void highlight();
     virtual void hideHighlight();
 
     virtual bool sendMessageToFrontend(const WTF::String&);
index af8b7db..20a1b1b 100644 (file)
@@ -97,9 +97,9 @@ void WebInspectorClient::openInspectorFrontend(InspectorController* inspectorCon
     m_frontendPage->inspectorController()->setInspectorFrontendClient(frontendClient.release());
 }
 
-void WebInspectorClient::highlight(Node* node)
+void WebInspectorClient::highlight()
 {
-    [m_highlighter.get() highlightNode:kit(node)];
+    [m_highlighter.get() highlight];
 }
 
 void WebInspectorClient::hideHighlight()
index 4fca732..2add0c2 100644 (file)
@@ -36,6 +36,6 @@
     WebNodeHighlight *_currentHighlight;
 }
 - (id)initWithInspectedWebView:(WebView *)webView;
-- (void)highlightNode:(DOMNode *)node;
+- (void)highlight;
 - (void)hideHighlight;
 @end
index 56bee2e..1d0df83 100644 (file)
@@ -54,7 +54,7 @@
 
 // MARK: -
 
-- (void)highlightNode:(DOMNode *)node
+- (void)highlight
 {
     // The scrollview's content view stays around between page navigations, so target it.
     NSView *view = [[[[[_inspectedWebView mainFrame] frameView] documentView] enclosingScrollView] contentView];
index 5bd88c6..10755d9 100644 (file)
@@ -1,3 +1,14 @@
+2011-08-03  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: remove Node parameter from the InspectorClient::highlight
+        https://bugs.webkit.org/show_bug.cgi?id=65549
+
+        Reviewed by Yury Semikhatsky.
+
+        * WebCoreSupport/InspectorClientQt.cpp:
+        (WebCore::InspectorClientQt::highlight):
+        * WebCoreSupport/InspectorClientQt.h:
+
 2011-08-02  Krist√≥f Koszty√≥  <Kosztyo.Kristof@stud.u-szeged.hu>
 
         [Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
index 1055817..11f7bc1 100644 (file)
@@ -265,7 +265,7 @@ void InspectorClientQt::detachRemoteFrontend()
 #endif
 }
 
-void InspectorClientQt::highlight(Node*)
+void InspectorClientQt::highlight()
 {
     hideHighlight();
 }
index c16fabe..0a03fd9 100644 (file)
@@ -43,7 +43,6 @@ class QWebView;
 namespace WebCore {
 class InspectorFrontendClientQt;
 class InspectorServerRequestHandlerQt;
-class Node;
 class Page;
 class RemoteFrontendChannel;
 
@@ -55,7 +54,7 @@ public:
 
     virtual void openInspectorFrontend(WebCore::InspectorController*);
 
-    virtual void highlight(Node*);
+    virtual void highlight();
     virtual void hideHighlight();
 
     virtual bool sendMessageToFrontend(const String&);
index 9d62d53..046a545 100644 (file)
@@ -1,3 +1,14 @@
+2011-08-03  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: remove Node parameter from the InspectorClient::highlight
+        https://bugs.webkit.org/show_bug.cgi?id=65549
+
+        Reviewed by Yury Semikhatsky.
+
+        * WebCoreSupport/WebInspectorClient.cpp:
+        (WebInspectorClient::highlight):
+        * WebCoreSupport/WebInspectorClient.h:
+
 2011-07-31  Daniel Bates  <dbates@webkit.org>
 
         Attempt to fix the WinCairo Debug build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).
index 8fc910a..12a1087 100644 (file)
@@ -175,7 +175,7 @@ void WebInspectorClient::openInspectorFrontend(InspectorController* inspectorCon
     m_frontendHwnd = frontendHwnd;
 }
 
-void WebInspectorClient::highlight(Node*)
+void WebInspectorClient::highlight()
 {
     bool creatingHighlight = !m_highlight;
 
index 7220a47..60daeb5 100644 (file)
@@ -58,7 +58,7 @@ public:
 
     virtual void openInspectorFrontend(WebCore::InspectorController*);
 
-    virtual void highlight(WebCore::Node*);
+    virtual void highlight();
     virtual void hideHighlight();
 
     virtual bool sendMessageToFrontend(const WTF::String&);
index c268283..7260dda 100644 (file)
@@ -1,3 +1,14 @@
+2011-08-03  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: remove Node parameter from the InspectorClient::highlight
+        https://bugs.webkit.org/show_bug.cgi?id=65549
+
+        Reviewed by Yury Semikhatsky.
+
+        * WebCoreSupport/InspectorClientWinCE.cpp:
+        (WebKit::InspectorClientWinCE::highlight):
+        * WebCoreSupport/InspectorClientWinCE.h:
+
 2011-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
 
         Add support for download='filename' attribute in anchors.
index 5168885..45feb2e 100644 (file)
@@ -55,7 +55,7 @@ void InspectorClientWinCE::releaseFrontendPage()
     notImplemented();
 }
 
-void InspectorClientWinCE::highlight(Node* node)
+void InspectorClientWinCE::highlight()
 {
     notImplemented();
 }
index 37d7577..d8f6b50 100644 (file)
@@ -40,7 +40,7 @@ public:
 
     virtual void openInspectorFrontend(WebCore::InspectorController*);
 
-    virtual void highlight(WebCore::Node*);
+    virtual void highlight();
     virtual void hideHighlight();
 
     virtual void populateSetting(const WTF::String& key, WTF::String* value);
index 7644261..e8dc835 100644 (file)
@@ -1,3 +1,14 @@
+2011-08-03  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: remove Node parameter from the InspectorClient::highlight
+        https://bugs.webkit.org/show_bug.cgi?id=65549
+
+        Reviewed by Yury Semikhatsky.
+
+        * WebKitSupport/InspectorClientWx.cpp:
+        (WebCore::InspectorClientWx::highlight):
+        * WebKitSupport/InspectorClientWx.h:
+
 2011-07-30  Patrick Gansterer  <paroga@webkit.org>
 
         Remove inclusion of MainThread.h from Threading.h
index c949d77..47037c9 100644 (file)
@@ -52,7 +52,7 @@ void InspectorClientWx::openInspectorFrontend(WebCore::InspectorController*)
     notImplemented();
 }
 
-void InspectorClientWx::highlight(Node*)
+void InspectorClientWx::highlight()
 {
     notImplemented();
 }
index 799e954..33c7a8e 100644 (file)
@@ -31,7 +31,6 @@
 
 namespace WebCore {
 
-class Node;
 class Page;
 
 class InspectorClientWx : public InspectorClient {
@@ -43,7 +42,7 @@ public:
 
     virtual void openInspectorFrontend(WebCore::InspectorController*);
 
-    virtual void highlight(Node*);
+    virtual void highlight();
     virtual void hideHighlight();
 
     virtual void populateSetting(const String& key, String* value);
index ef442ab..ed73b67 100644 (file)
@@ -1,3 +1,14 @@
+2011-08-03  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: remove Node parameter from the InspectorClient::highlight
+        https://bugs.webkit.org/show_bug.cgi?id=65549
+
+        Reviewed by Yury Semikhatsky.
+
+        * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
+        (WebKit::WebInspectorClient::highlight):
+        * WebProcess/WebCoreSupport/WebInspectorClient.h:
+
 2011-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [GTK] Reorganize pkg-config files
index 535a187..2f64485 100644 (file)
@@ -54,7 +54,7 @@ void WebInspectorClient::openInspectorFrontend(InspectorController*)
     inspectorPage->corePage()->inspectorController()->setInspectorFrontendClient(adoptPtr(new WebInspectorFrontendClient(m_page, inspectorPage)));
 }
 
-void WebInspectorClient::highlight(Node*)
+void WebInspectorClient::highlight()
 {
     if (!m_highlightOverlay) {
         RefPtr<PageOverlay> highlightOverlay = PageOverlay::create(this);
index 8cddaed..ec1a658 100644 (file)
@@ -54,7 +54,7 @@ private:
 
     virtual void openInspectorFrontend(WebCore::InspectorController*);
 
-    virtual void highlight(WebCore::Node*);
+    virtual void highlight();
     virtual void hideHighlight();
 
     virtual bool sendMessageToFrontend(const String&);