FrameLoaderClient BackForwardList-related methods are unsued
authormihaip@chromium.org <mihaip@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 17 Sep 2011 23:31:52 +0000 (23:31 +0000)
committermihaip@chromium.org <mihaip@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 17 Sep 2011 23:31:52 +0000 (23:31 +0000)
https://bugs.webkit.org/show_bug.cgi?id=68293

Reviewed by Darin Adler.

Source/WebCore:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* history/BackForwardListImpl.cpp:
(WebCore::BackForwardListImpl::addItem):
(WebCore::BackForwardListImpl::goBack):
(WebCore::BackForwardListImpl::goForward):
(WebCore::BackForwardListImpl::goToItem):
(WebCore::BackForwardListImpl::setCapacity):
* loader/EmptyClients.h:
* loader/FrameLoaderClient.h:

Source/WebKit/chromium:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* src/FrameLoaderClientImpl.cpp:
* src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
* WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientGtk.cpp:
* WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientHaiku.cpp:
* WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/mac:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebKit.order:

Source/WebKit/qt:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientQt.cpp:
* WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
* WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebKitSupport/FrameLoaderClientWx.cpp:
* WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

35 files changed:
Source/WebCore/ChangeLog
Source/WebCore/history/BackForwardListImpl.cpp
Source/WebCore/loader/EmptyClients.h
Source/WebCore/loader/FrameLoaderClient.h
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
Source/WebKit/chromium/src/FrameLoaderClientImpl.h
Source/WebKit/efl/ChangeLog
Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp
Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h
Source/WebKit/gtk/ChangeLog
Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp
Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h
Source/WebKit/haiku/ChangeLog
Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp
Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.h
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h
Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
Source/WebKit/mac/WebKit.order
Source/WebKit/qt/ChangeLog
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h
Source/WebKit/win/ChangeLog
Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp
Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h
Source/WebKit/wince/ChangeLog
Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp
Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h
Source/WebKit/wx/ChangeLog
Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp
Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h
Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h

index f4e7c24..1a78b0b 100644 (file)
@@ -1,3 +1,22 @@
+2011-09-17  Mihai Parparita  <mihaip@chromium.org>
+
+        FrameLoaderClient BackForwardList-related methods are unsued
+        https://bugs.webkit.org/show_bug.cgi?id=68293
+
+        Reviewed by Darin Adler.
+
+        Remove FrameLoaderClient methods that were added by r51629, since only
+        the old (since-deleted) Android port needed them.
+
+        * history/BackForwardListImpl.cpp:
+        (WebCore::BackForwardListImpl::addItem):
+        (WebCore::BackForwardListImpl::goBack):
+        (WebCore::BackForwardListImpl::goForward):
+        (WebCore::BackForwardListImpl::goToItem):
+        (WebCore::BackForwardListImpl::setCapacity):
+        * loader/EmptyClients.h:
+        * loader/FrameLoaderClient.h:
+
 2011-09-17  David Hyatt  <hyatt@apple.com>
 
         https://bugs.webkit.org/show_bug.cgi?id=68307
index 6ea8ae0..05b2a0e 100644 (file)
@@ -82,15 +82,11 @@ void BackForwardListImpl::addItem(PassRefPtr<HistoryItem> prpItem)
         m_entryHash.remove(item);
         pageCache()->remove(item.get());
         m_current--;
-        if (m_page)
-            m_page->mainFrame()->loader()->client()->dispatchDidRemoveBackForwardItem(item.get());
     }
 
     m_entryHash.add(prpItem.get());
     m_entries.insert(m_current + 1, prpItem);
     m_current++;
-    if (m_page)
-        m_page->mainFrame()->loader()->client()->dispatchDidAddBackForwardItem(currentItem());
 }
 
 void BackForwardListImpl::goBack()
@@ -98,8 +94,6 @@ void BackForwardListImpl::goBack()
     ASSERT(m_current > 0);
     if (m_current > 0) {
         m_current--;
-        if (m_page)
-            m_page->mainFrame()->loader()->client()->dispatchDidChangeBackForwardIndex();
     }
 }
 
@@ -108,8 +102,6 @@ void BackForwardListImpl::goForward()
     ASSERT(m_current < m_entries.size() - 1);
     if (m_current < m_entries.size() - 1) {
         m_current++;
-        if (m_page)
-            m_page->mainFrame()->loader()->client()->dispatchDidChangeBackForwardIndex();
     }
 }
 
@@ -124,8 +116,6 @@ void BackForwardListImpl::goToItem(HistoryItem* item)
             break;
     if (index < m_entries.size()) {
         m_current = index;
-        if (m_page)
-            m_page->mainFrame()->loader()->client()->dispatchDidChangeBackForwardIndex();
     }
 }
 
@@ -194,8 +184,6 @@ void BackForwardListImpl::setCapacity(int size)
         m_current = NoCurrentItemIndex;
     else if (m_current > m_entries.size() - 1) {
         m_current = m_entries.size() - 1;
-        if (m_page)
-            m_page->mainFrame()->loader()->client()->dispatchDidChangeBackForwardIndex();
     }
     m_capacity = size;
 }
index 59856d0..0de876b 100644 (file)
@@ -367,9 +367,6 @@ public:
     virtual void updateGlobalHistoryRedirectLinks() { }
     virtual bool shouldGoToHistoryItem(HistoryItem*) const { return false; }
     virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const { return false; }
-    virtual void dispatchDidAddBackForwardItem(HistoryItem*) const { }
-    virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const { }
-    virtual void dispatchDidChangeBackForwardIndex() const { }
     virtual void updateGlobalHistoryItemForPage() { }
     virtual void saveViewStateToItem(HistoryItem*) { }
     virtual bool canCachePage() const { return false; }
index d3bdba1..a9d4ed1 100644 (file)
@@ -31,7 +31,6 @@
 
 #include "FrameLoaderTypes.h"
 #include "IconURL.h"
-#include "ScrollTypes.h"
 #include <wtf/Forward.h>
 #include <wtf/Vector.h>
 
@@ -199,9 +198,6 @@ namespace WebCore {
 
         virtual bool shouldGoToHistoryItem(HistoryItem*) const = 0;
         virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const = 0;
-        virtual void dispatchDidAddBackForwardItem(HistoryItem*) const = 0;
-        virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const = 0;
-        virtual void dispatchDidChangeBackForwardIndex() const = 0;
         virtual void updateGlobalHistoryItemForPage() { }
 
         // This frame has displayed inactive content (such as an image) from an
index 330a4e4..5c73911 100644 (file)
@@ -1,3 +1,16 @@
+2011-09-17  Mihai Parparita  <mihaip@chromium.org>
+
+        FrameLoaderClient BackForwardList-related methods are unsued
+        https://bugs.webkit.org/show_bug.cgi?id=68293
+
+        Reviewed by Darin Adler.
+
+        Remove FrameLoaderClient methods that were added by r51629, since only        
+        the old (since-deleted) Android port needed them.
+
+        * src/FrameLoaderClientImpl.cpp:
+        * src/FrameLoaderClientImpl.h:
+
 2011-09-17  Aaron Boodman  <aa@chromium.org>
 
         Rework script context creation/release notifications
index 1c70499..57bf56f 100644 (file)
@@ -1183,18 +1183,6 @@ bool FrameLoaderClientImpl::shouldStopLoadingForHistoryItem(HistoryItem* targetI
     return !url.protocolIs(backForwardNavigationScheme);
 }
 
-void FrameLoaderClientImpl::dispatchDidAddBackForwardItem(HistoryItem*) const
-{
-}
-
-void FrameLoaderClientImpl::dispatchDidRemoveBackForwardItem(HistoryItem*) const
-{
-}
-
-void FrameLoaderClientImpl::dispatchDidChangeBackForwardIndex() const
-{
-}
-
 void FrameLoaderClientImpl::didDisplayInsecureContent()
 {
     if (m_webFrame->client())
index 4d12ac5..248edd5 100644 (file)
@@ -136,9 +136,6 @@ public:
     virtual void updateGlobalHistoryRedirectLinks();
     virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
     virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidChangeBackForwardIndex() const;
     virtual void didDisplayInsecureContent();
     virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const WebCore::KURL& insecureURL);
     virtual WebCore::ResourceError blockedError(const WebCore::ResourceRequest&);
index 547a169..69c60a2 100755 (executable)
@@ -1,3 +1,16 @@
+2011-09-17  Mihai Parparita  <mihaip@chromium.org>
+
+        FrameLoaderClient BackForwardList-related methods are unsued
+        https://bugs.webkit.org/show_bug.cgi?id=68293
+
+        Reviewed by Darin Adler.
+
+        Remove FrameLoaderClient methods that were added by r51629, since only        
+        the old (since-deleted) Android port needed them.
+
+        * WebCoreSupport/FrameLoaderClientEfl.cpp:
+        * WebCoreSupport/FrameLoaderClientEfl.h:
+
 2011-09-15  Adam Barth  <abarth@webkit.org>
 
         Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
index 452f620..d61423e 100644 (file)
@@ -169,11 +169,6 @@ void FrameLoaderClientEfl::dispatchDidReplaceStateWithinPage()
     notImplemented();
 }
 
-void FrameLoaderClientEfl::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
-{
-    notImplemented();
-}
-
 void FrameLoaderClientEfl::dispatchDidPushStateWithinPage()
 {
     notImplemented();
@@ -184,16 +179,6 @@ void FrameLoaderClientEfl::dispatchDidPopStateWithinPage()
     notImplemented();
 }
 
-void FrameLoaderClientEfl::dispatchDidChangeBackForwardIndex() const
-{
-    notImplemented();
-}
-
-void FrameLoaderClientEfl::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
-{
-    notImplemented();
-}
-
 void FrameLoaderClientEfl::dispatchDidReceiveAuthenticationChallenge(DocumentLoader*, unsigned long  identifier, const AuthenticationChallenge&)
 {
     notImplemented();
index 2e23410..5a56bb1 100644 (file)
@@ -81,9 +81,6 @@ class FrameLoaderClientEfl : public FrameLoaderClient {
     virtual void dispatchDidPushStateWithinPage();
     virtual void dispatchDidPopStateWithinPage();
     virtual void dispatchDidReplaceStateWithinPage();
-    virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidChangeBackForwardIndex() const;
     virtual void dispatchDidClearWindowObjectInWorld(WebCore::DOMWrapperWorld*);
 
     virtual void dispatchDidCancelAuthenticationChallenge(DocumentLoader*, unsigned long  identifier, const AuthenticationChallenge&);
index cf13e59..4aabcde 100644 (file)
@@ -1,3 +1,16 @@
+2011-09-17  Mihai Parparita  <mihaip@chromium.org>
+
+        FrameLoaderClient BackForwardList-related methods are unsued
+        https://bugs.webkit.org/show_bug.cgi?id=68293
+
+        Reviewed by Darin Adler.
+
+        Remove FrameLoaderClient methods that were added by r51629, since only        
+        the old (since-deleted) Android port needed them.
+
+        * WebCoreSupport/FrameLoaderClientGtk.cpp:
+        * WebCoreSupport/FrameLoaderClientGtk.h:
+
 2011-09-15  Adam Barth  <abarth@webkit.org>
 
         Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
index c948602..adc5118 100644 (file)
@@ -713,18 +713,6 @@ bool FrameLoaderClient::shouldStopLoadingForHistoryItem(HistoryItem* item) const
     return true;
 }
 
-void FrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
-{
-}
-
-void FrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
-{
-}
-
-void FrameLoaderClient::dispatchDidChangeBackForwardIndex() const
-{
-}
-
 void FrameLoaderClient::didDisplayInsecureContent()
 {
     notImplemented();
index a2aae30..446f8ba 100644 (file)
@@ -142,9 +142,6 @@ namespace WebKit {
         virtual void updateGlobalHistoryRedirectLinks();
         virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
         virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
-        virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
-        virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
-        virtual void dispatchDidChangeBackForwardIndex() const;
 
         virtual void didDisplayInsecureContent();
         virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const WebCore::KURL&);
index 3a12a81..b485463 100644 (file)
@@ -1,3 +1,16 @@
+2011-09-17  Mihai Parparita  <mihaip@chromium.org>
+
+        FrameLoaderClient BackForwardList-related methods are unsued
+        https://bugs.webkit.org/show_bug.cgi?id=68293
+
+        Reviewed by Darin Adler.
+
+        Remove FrameLoaderClient methods that were added by r51629, since only        
+        the old (since-deleted) Android port needed them.
+
+        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
+        * WebCoreSupport/FrameLoaderClientHaiku.h:
+
 2011-09-15  Adam Barth  <abarth@webkit.org>
 
         Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
index 511a480..dcc8173 100644 (file)
@@ -488,18 +488,6 @@ bool FrameLoaderClientHaiku::shouldStopLoadingForHistoryItem(WebCore::HistoryIte
     return true;
 }
 
-void FrameLoaderClientHaiku::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
-{
-}
-
-void FrameLoaderClientHaiku::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
-{
-}
-
-void FrameLoaderClientHaiku::dispatchDidChangeBackForwardIndex() const
-{
-}
-
 void FrameLoaderClientHaiku::saveScrollPositionAndViewStateToItem(WebCore::HistoryItem*)
 {
     notImplemented();
index f0ff154..673750d 100644 (file)
@@ -160,9 +160,6 @@ namespace WebCore {
         virtual void updateGlobalHistoryRedirectLinks();
         virtual bool shouldGoToHistoryItem(HistoryItem*) const;
         virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const;
-        virtual void dispatchDidAddBackForwardItem(HistoryItem*) const;
-        virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const;
-        virtual void dispatchDidChangeBackForwardIndex() const;
         virtual void saveScrollPositionAndViewStateToItem(HistoryItem*);
         virtual bool canCachePage() const;
 
index b52ea53..f0cc133 100644 (file)
@@ -1,3 +1,17 @@
+2011-09-17  Mihai Parparita  <mihaip@chromium.org>
+
+        FrameLoaderClient BackForwardList-related methods are unsued
+        https://bugs.webkit.org/show_bug.cgi?id=68293
+
+        Reviewed by Darin Adler.
+
+        Remove FrameLoaderClient methods that were added by r51629, since only        
+        the old (since-deleted) Android port needed them.
+
+        * WebCoreSupport/WebFrameLoaderClient.h:
+        * WebCoreSupport/WebFrameLoaderClient.mm:
+        * WebKit.order:
+
 2011-09-16  Simon Fraser  <simon.fraser@apple.com>
 
         Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
index 77d7c1a..72fd04d 100644 (file)
@@ -152,9 +152,6 @@ private:
 
     virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
     virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidChangeBackForwardIndex() const;
     virtual void updateGlobalHistoryItemForPage();
 
     virtual void didDisplayInsecureContent();
index 0948406..f48ae8f 100644 (file)
@@ -973,18 +973,6 @@ bool WebFrameLoaderClient::shouldStopLoadingForHistoryItem(HistoryItem* item) co
     return true;
 }
 
-void WebFrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
-{
-}
-
-void WebFrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
-{
-}
-
-void WebFrameLoaderClient::dispatchDidChangeBackForwardIndex() const
-{
-}
-
 void WebFrameLoaderClient::updateGlobalHistoryItemForPage()
 {
     HistoryItem* historyItem = 0;
index d60d871..51b31e4 100644 (file)
@@ -738,7 +738,6 @@ __ZN20WebFrameLoaderClient18makeRepresentationEPN7WebCore14DocumentLoaderE
 -[WebDataSource(WebFileInternal) _setRepresentation:]
 -[WebHTMLRepresentation setDataSource:]
 __Z26WKNotifyHistoryItemChangedPN7WebCore11HistoryItemE
-__ZNK20WebFrameLoaderClient29dispatchDidAddBackForwardItemEPN7WebCore11HistoryItemE
 __ZN20WebFrameLoaderClient19updateGlobalHistoryEv
 -[WebView(WebPendingPublic) historyDelegate]
 __ZN20WebFrameLoaderClient32updateGlobalHistoryRedirectLinksEv
@@ -1220,7 +1219,6 @@ _WKCreateAXTextMarkerRange
 -[WebFrame(WebPrivate) _pauseAnimation:onNode:atTime:]
 _WKExecutableWasLinkedOnOrBeforeSnowLeopard
 +[WebCoreStatistics garbageCollectJavaScriptObjects]
-__ZNK20WebFrameLoaderClient32dispatchDidRemoveBackForwardItemEPN7WebCore11HistoryItemE
 __ZNK7WebCore12ChromeClient29dispatchViewportDataDidChangeERKNS_17ViewportArgumentsE
 -[WebView(WebPrivate) setFrameSize:]
 -[WebFrame(WebKitDebug) renderTreeAsExternalRepresentationForPrinting:]
@@ -1756,7 +1754,6 @@ __ZN3WTF9HashTableIjSt4pairIjPN6WebKit23NetscapePluginHostProxyEENS_18PairFirstE
 -[WebView(WebPendingPublic) zoomPageIn:]
 __ZNK20WebFrameLoaderClient21shouldGoToHistoryItemEPN7WebCore11HistoryItemE
 -[WebDefaultPolicyDelegate webView:shouldGoToHistoryItem:]
-__ZNK20WebFrameLoaderClient33dispatchDidChangeBackForwardIndexEv
 -[WebView(WebPendingPublic) zoomPageOut:]
 -[WebView _zoomOut:isTextOnly:]
 -[WebFrame(WebKitDebug) counterValueForElement:]
index 4cf182a..e6e1aa5 100644 (file)
@@ -1,3 +1,16 @@
+2011-09-17  Mihai Parparita  <mihaip@chromium.org>
+
+        FrameLoaderClient BackForwardList-related methods are unsued
+        https://bugs.webkit.org/show_bug.cgi?id=68293
+
+        Reviewed by Darin Adler.
+
+        Remove FrameLoaderClient methods that were added by r51629, since only        
+        the old (since-deleted) Android port needed them.
+
+        * WebCoreSupport/FrameLoaderClientQt.cpp:
+        * WebCoreSupport/FrameLoaderClientQt.h:
+
 2011-09-15  Adam Barth  <abarth@webkit.org>
 
         Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
index a081bdb..136ad21 100644 (file)
@@ -854,18 +854,6 @@ bool FrameLoaderClientQt::shouldStopLoadingForHistoryItem(WebCore::HistoryItem*)
     return true;
 }
 
-void FrameLoaderClientQt::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
-{
-}
-
-void FrameLoaderClientQt::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
-{
-}
-
-void FrameLoaderClientQt::dispatchDidChangeBackForwardIndex() const
-{
-}
-
 void FrameLoaderClientQt::didDisplayInsecureContent()
 {
     if (dumpFrameLoaderCallbacks)
index 2244b26..a0e0929 100644 (file)
@@ -160,9 +160,6 @@ public:
     virtual void updateGlobalHistoryRedirectLinks();
     virtual bool shouldGoToHistoryItem(HistoryItem*) const;
     virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const;
-    virtual void dispatchDidAddBackForwardItem(HistoryItem*) const;
-    virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const;
-    virtual void dispatchDidChangeBackForwardIndex() const;
     virtual void didDisplayInsecureContent();
     virtual void didRunInsecureContent(SecurityOrigin*, const KURL&);
 
index c16790f..09062fe 100644 (file)
@@ -1,3 +1,16 @@
+2011-09-17  Mihai Parparita  <mihaip@chromium.org>
+
+        FrameLoaderClient BackForwardList-related methods are unsued
+        https://bugs.webkit.org/show_bug.cgi?id=68293
+
+        Reviewed by Darin Adler.
+
+        Remove FrameLoaderClient methods that were added by r51629, since only        
+        the old (since-deleted) Android port needed them.
+
+        * WebCoreSupport/WebFrameLoaderClient.cpp:
+        * WebCoreSupport/WebFrameLoaderClient.h:
+
 2011-09-15  Adam Barth  <abarth@webkit.org>
 
         Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
index f0aa50c..0bb9649 100644 (file)
@@ -613,18 +613,6 @@ bool WebFrameLoaderClient::shouldStopLoadingForHistoryItem(HistoryItem*) const
     return true;
 }
 
-void WebFrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
-{
-}
-
-void WebFrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
-{
-}
-
-void WebFrameLoaderClient::dispatchDidChangeBackForwardIndex() const
-{
-}
-
 void WebFrameLoaderClient::updateGlobalHistoryItemForPage()
 {
     HistoryItem* historyItem = 0;
index c43a716..4ec8469 100644 (file)
@@ -94,9 +94,6 @@ public:
     virtual void updateGlobalHistoryRedirectLinks();
     virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
     virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidChangeBackForwardIndex() const;
     virtual void updateGlobalHistoryItemForPage();
 
     virtual void didDisplayInsecureContent();
index c094a3b..58897d8 100644 (file)
@@ -1,3 +1,16 @@
+2011-09-17  Mihai Parparita  <mihaip@chromium.org>
+
+        FrameLoaderClient BackForwardList-related methods are unsued
+        https://bugs.webkit.org/show_bug.cgi?id=68293
+
+        Reviewed by Darin Adler.
+
+        Remove FrameLoaderClient methods that were added by r51629, since only        
+        the old (since-deleted) Android port needed them.
+
+        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
+        * WebCoreSupport/FrameLoaderClientWinCE.h:
+
 2011-09-15  Adam Barth  <abarth@webkit.org>
 
         Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
index 1e4537a..c372e21 100644 (file)
@@ -264,18 +264,6 @@ bool FrameLoaderClientWinCE::shouldStopLoadingForHistoryItem(HistoryItem* item)
     return true;
 }
 
-void FrameLoaderClientWinCE::dispatchDidAddBackForwardItem(HistoryItem*) const
-{
-}
-
-void FrameLoaderClientWinCE::dispatchDidRemoveBackForwardItem(HistoryItem*) const
-{
-}
-
-void FrameLoaderClientWinCE::dispatchDidChangeBackForwardIndex() const
-{
-}
-
 void FrameLoaderClientWinCE::didDisplayInsecureContent()
 {
     notImplemented();
index 00918ba..7a4f781 100644 (file)
@@ -137,9 +137,6 @@ public:
     virtual void updateGlobalHistoryRedirectLinks();
     virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
     virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidChangeBackForwardIndex() const;
 
     virtual void didDisplayInsecureContent();
     virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const WebCore::KURL&);
index 0602e00..d5b9eba 100644 (file)
@@ -1,3 +1,16 @@
+2011-09-17  Mihai Parparita  <mihaip@chromium.org>
+
+        FrameLoaderClient BackForwardList-related methods are unsued
+        https://bugs.webkit.org/show_bug.cgi?id=68293
+
+        Reviewed by Darin Adler.
+
+        Remove FrameLoaderClient methods that were added by r51629, since only        
+        the old (since-deleted) Android port needed them.
+
+        * WebKitSupport/FrameLoaderClientWx.cpp:
+        * WebKitSupport/FrameLoaderClientWx.h:
+
 2011-09-15  Adam Barth  <abarth@webkit.org>
 
         Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
index 18c1d03..22f5595 100644 (file)
@@ -592,18 +592,6 @@ bool FrameLoaderClientWx::shouldStopLoadingForHistoryItem(WebCore::HistoryItem*)
     return true;
 }
 
-void FrameLoaderClientWx::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
-{
-}
-
-void FrameLoaderClientWx::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
-{
-}
-
-void FrameLoaderClientWx::dispatchDidChangeBackForwardIndex() const
-{
-}
-
 void FrameLoaderClientWx::didDisplayInsecureContent()
 {
     notImplemented();
index 1c207f1..61181a9 100644 (file)
@@ -165,9 +165,6 @@ namespace WebCore {
         virtual void updateGlobalHistoryRedirectLinks();
         virtual bool shouldGoToHistoryItem(HistoryItem*) const;
         virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const;
-        virtual void dispatchDidAddBackForwardItem(HistoryItem*) const;
-        virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const;
-        virtual void dispatchDidChangeBackForwardIndex() const;
         virtual void saveScrollPositionAndViewStateToItem(HistoryItem*);
         virtual bool canCachePage() const;
         
index af8597c..dfc2025 100644 (file)
@@ -1,3 +1,16 @@
+2011-09-17  Mihai Parparita  <mihaip@chromium.org>
+
+        FrameLoaderClient BackForwardList-related methods are unsued
+        https://bugs.webkit.org/show_bug.cgi?id=68293
+
+        Reviewed by Darin Adler.
+
+        Remove FrameLoaderClient methods that were added by r51629, since only        
+        the old (since-deleted) Android port needed them.
+
+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
+
 2011-09-16  Gopal Raghavan  <gopal.1.raghavan@nokia.com>
         [Qt] QTouchWebView missing loadProgress tests
         https://bugs.webkit.org/show_bug.cgi?id=68183
index 52d29fd..4dfbd3f 100644 (file)
@@ -923,21 +923,6 @@ bool WebFrameLoaderClient::shouldStopLoadingForHistoryItem(HistoryItem* item) co
     return true;
 }
 
-void WebFrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
-{
-    notImplemented();
-}
-
-void WebFrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
-{
-    notImplemented();
-}
-
-void WebFrameLoaderClient::dispatchDidChangeBackForwardIndex() const
-{
-    notImplemented();
-}
-
 void WebFrameLoaderClient::didDisplayInsecureContent()
 {
     WebPage* webPage = m_frame->page();
index 82a3bc2..ae0b270 100644 (file)
@@ -135,9 +135,6 @@ private:
     
     virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
     virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
-    virtual void dispatchDidChangeBackForwardIndex() const;
 
     virtual void didDisplayInsecureContent();
     virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const WebCore::KURL&);