results.webkit.org: Color should be the worst result, count should include all results
authorjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Jul 2019 01:03:40 +0000 (01:03 +0000)
committerjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Jul 2019 01:03:40 +0000 (01:03 +0000)
https://bugs.webkit.org/show_bug.cgi?id=200127

Rubber-stamped by Aakash Jain.

* resultsdbpy/resultsdbpy/view/static/js/timeline.js:
(Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js

index f68de7a..c896f5f 100644 (file)
@@ -1,3 +1,13 @@
+2019-07-25  Jonathan Bedard  <jbedard@apple.com>
+
+        results.webkit.org: Color should be the worst result, count should include all results
+        https://bugs.webkit.org/show_bug.cgi?id=200127
+
+        Rubber-stamped by Aakash Jain.
+
+        * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
+        (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
+
 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
 
         [Timeline]: Make timeline header width automatic, instead of fixed width
index 5f85467..8b940ff 100644 (file)
@@ -194,22 +194,17 @@ class Dot {
             return render('dot success');
 
         let key = 'failed';
-        let value = this.failed - this.timeout;
-        if (this.timeout) {
+        if (this.timeout)
             key = 'timeout';
-            value = this.timeout - this.crash;
-        }
-        if (this.crash) {
+        if (this.crash)
             key = 'crash';
-            value = this.timeout;
-        }
 
         if (!this.combined)
-            return render(`dot ${key}`, `<div class="tag" style="color:var(--boldInverseColor)">${value}</div>`);
+            return render(`dot ${key}`, `<div class="tag" style="color:var(--boldInverseColor)">${this.failed}</div>`);
 
         return render(`dot ${key}`, `<div class="tag" style="color:var(--boldInverseColor)">
                 ${function() {
-                    let percent = Math.ceil(value / self.count * 100 - .5);
+                    let percent = Math.ceil(this.failed / self.count * 100 - .5);
                     if (percent > 0)
                         return percent;
                     return '<1';