[Win][IndexedDB] Crash when running blob test.
authorpeavo@outlook.com <peavo@outlook.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 1 Jun 2016 09:10:49 +0000 (09:10 +0000)
committerpeavo@outlook.com <peavo@outlook.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 1 Jun 2016 09:10:49 +0000 (09:10 +0000)
https://bugs.webkit.org/show_bug.cgi?id=158224

Reviewed by Brady Eidson.

Avoid calling WTFMove(x) before calling x->method().

* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::putOrAddOnServer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@201547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Modules/indexeddb/IDBTransaction.cpp

index 9b95123..340b9cc 100644 (file)
@@ -1,3 +1,15 @@
+2016-06-01  Per Arne Vollan  <pvollan@apple.com>
+
+        [Win][IndexedDB] Crash when running blob test.
+        https://bugs.webkit.org/show_bug.cgi?id=158224
+
+        Reviewed by Brady Eidson.
+
+        Avoid calling WTFMove(x) before calling x->method().
+
+        * Modules/indexeddb/IDBTransaction.cpp:
+        (WebCore::IDBTransaction::putOrAddOnServer):
+
 2016-06-01  Manuel Rego Casasnovas  <rego@igalia.com>
 
         [css-grid] Positioned items can be placed on the implicit grid
index cd4d372..d7e4ef6 100644 (file)
@@ -968,7 +968,7 @@ void IDBTransaction::putOrAddOnServer(IDBClient::TransactionOperation& operation
 
     RefPtr<IDBTransaction> protectedThis(this);
     RefPtr<IDBClient::TransactionOperation> protectedOperation(&operation);
-    value->writeBlobsToDiskForIndexedDB([protectedThis = WTFMove(protectedThis), this, protectedOperation = WTFMove(protectedOperation), key = WTFMove(key), value = WTFMove(value), overwriteMode](const IDBValue& idbValue) mutable {
+    value->writeBlobsToDiskForIndexedDB([protectedThis = WTFMove(protectedThis), this, protectedOperation = WTFMove(protectedOperation), key = WTFMove(key), overwriteMode](const IDBValue& idbValue) mutable {
         ASSERT(currentThread() == originThreadID());
         ASSERT(isMainThread());
         if (idbValue.data().data()) {