Add a Mac debug EWS queue
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 13 Oct 2015 02:49:33 +0000 (02:49 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 13 Oct 2015 02:49:33 +0000 (02:49 +0000)
https://bugs.webkit.org/show_bug.cgi?id=150069

Reviewed by Geoffrey Garen.

* QueueStatusServer/config/queues.py:
* Scripts/webkitpy/common/config/ews.json:
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.archive_last_test_results):
(AbstractEarlyWarningSystem.build_style):
(AbstractEarlyWarningSystem.refetch_patch):
(AbstractEarlyWarningSystem.load_ews_classes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/QueueStatusServer/config/queues.py
Tools/Scripts/webkitpy/common/config/ews.json
Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py

index f8baa00..d4c4590 100644 (file)
@@ -1,3 +1,19 @@
+2015-10-12  Alexey Proskuryakov  <ap@apple.com>
+
+        Add a Mac debug EWS queue
+        https://bugs.webkit.org/show_bug.cgi?id=150069
+
+        Reviewed by Geoffrey Garen.
+
+        * QueueStatusServer/config/queues.py:
+        * Scripts/webkitpy/common/config/ews.json:
+        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+        (AbstractEarlyWarningSystem):
+        (AbstractEarlyWarningSystem.archive_last_test_results):
+        (AbstractEarlyWarningSystem.build_style):
+        (AbstractEarlyWarningSystem.refetch_patch):
+        (AbstractEarlyWarningSystem.load_ews_classes):
+
 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
 
         [GTK] Update jhbuild's version of harfbuzz
index dddd5e8..1950ce6 100644 (file)
@@ -37,6 +37,7 @@ all_queue_names = [
     "ios-ews",
     "mac-ews",
     "mac-wk2-ews",
+    "mac-debug-32bit-ews",
     "win-ews",
     "efl-wk2-ews",
 ]
index 8c4e6e7..cbc4006 100644 (file)
             "rniwa@webkit.org"
         ],
         "runTests": true
+    },
+    "Mac Debug 32-bit WK2 EWS": {
+        "port": "mac",
+        "name": "mac-debug-32bit-ews",
+        "style": "debug",
+        "architecture": "i386",
     }
 }
index acb3dfc..4f9b6f3 100644 (file)
@@ -44,7 +44,6 @@ _log = logging.getLogger(__name__)
 
 
 class AbstractEarlyWarningSystem(AbstractReviewQueue, EarlyWarningSystemTaskDelegate):
-    _build_style = "release"
     # FIXME: Switch _default_run_tests from opt-in to opt-out once more bots are ready to run tests.
     run_tests = False
 
@@ -124,7 +123,7 @@ class AbstractEarlyWarningSystem(AbstractReviewQueue, EarlyWarningSystemTaskDele
         return self._layout_test_results_reader.archive(patch)
 
     def build_style(self):
-        return self._build_style
+        return self.build_style
 
     def refetch_patch(self, patch):
         return self._tool.bugs.fetch_attachment(patch.id())
@@ -150,10 +149,11 @@ class AbstractEarlyWarningSystem(AbstractReviewQueue, EarlyWarningSystemTaskDele
 
         classes = []
         for name, config in ewses.iteritems():
-            classes.append(type(str(name.replace(' ', '')), (AbstractEarlyWarningSystem,), {
-                'name': config['port'] + '-ews',
+            classes.append(type(str(name).translate(None, ' -'), (AbstractEarlyWarningSystem,), {
+                'name': config.get('name', config['port'] + '-ews'),
                 'port_name': config['port'],
                 'architecture': config.get('architecture', None),
+                'build_style': config.get('style', "release"),
                 'watchers': config.get('watchers', []),
                 'run_tests': config.get('runTests', cls.run_tests),
             }))