Unreviewed, disable new window.open() API tests introduced in r230051 on iOS.
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Mar 2018 23:46:29 +0000 (23:46 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Mar 2018 23:46:29 +0000 (23:46 +0000)
I will investigate if this is testable on iOS.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm

index 3efd692..ecf0175 100644 (file)
@@ -1,5 +1,13 @@
 2018-03-28  Chris Dumez  <cdumez@apple.com>
 
+        Unreviewed, disable new window.open() API tests introduced in r230051 on iOS.
+
+        I will investigate if this is testable on iOS.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2018-03-28  Chris Dumez  <cdumez@apple.com>
+
         Do process swap when opening a cross-origin URL via window.open(url, '_blank', 'noopener')
         https://bugs.webkit.org/show_bug.cgi?id=183962
         <rdar://problem/38817833>
index 53bff6d..c47f5d3 100644 (file)
@@ -314,6 +314,8 @@ TEST(ProcessSwap, Back)
     EXPECT_FALSE(pid1 == pid3);
 }
 
+#if PLATFORM(MAC)
+
 TEST(ProcessSwap, CrossOriginWindowOpenNoOpener)
 {
     auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]);
@@ -397,7 +399,7 @@ TEST(ProcessSwap, CrossOriginWindowOpenWithOpener)
     EXPECT_EQ(pid1, pid2);
 }
 
-TEST(ProcessSwap, SamOriginWindowOpenNoOpener)
+TEST(ProcessSwap, SameOriginWindowOpenNoOpener)
 {
     auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]);
     processPoolConfiguration.get().processSwapsOnNavigation = YES;
@@ -436,4 +438,6 @@ TEST(ProcessSwap, SamOriginWindowOpenNoOpener)
     EXPECT_EQ(pid1, pid2);
 }
 
+#endif // PLATFORM(MAC)
+
 #endif // WK_API_ENABLED