Unreviewed follow-up fix to r239650
authoraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 5 Jan 2019 12:01:10 +0000 (12:01 +0000)
committeraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 5 Jan 2019 12:01:10 +0000 (12:01 +0000)
https://bugs.webkit.org/show_bug.cgi?id=193140
<rdar://problem/47063037>

Typecast patch_id to string.

* BuildSlaveSupport/ews-build/steps.py:
(ValidatePatch._is_patch_obsolete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/ews-build/steps.py
Tools/ChangeLog

index 81b2e0d..a8ed578 100644 (file)
@@ -287,7 +287,7 @@ class ValidatePatch(buildstep.BuildStep):
             self._addToLog('stdio', 'Unable to fetch patch {}.\n'.format(patch_id))
             return -1
 
-        if patch_json.get('id') != self.getProperty('patch_id', ''):
+        if str(patch_json.get('id')) != self.getProperty('patch_id', ''):
             self._addToLog('stdio', 'Fetched patch id {} does not match with requested patch id {}. Unable to validate.\n'.format(patch_json.get('id'), self.getProperty('patch_id', '')))
             return -1
 
index e5b3dac..741bd2f 100644 (file)
@@ -1,3 +1,14 @@
+2019-01-05  Aakash Jain  <aakash_jain@apple.com>
+
+        Unreviewed follow-up fix to r239650
+        https://bugs.webkit.org/show_bug.cgi?id=193140
+        <rdar://problem/47063037>
+
+        Typecast patch_id to string.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (ValidatePatch._is_patch_obsolete):
+
 2019-01-04  Daniel Bates  <dabates@apple.com>
 
         [lldb-webkit]: Add support for pretty-printing raw bitmask types