REGRESSION(r170676): [GTK] UI process crashes when the Web Process crashes
authorcarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 3 Jul 2014 07:56:28 +0000 (07:56 +0000)
committercarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 3 Jul 2014 07:56:28 +0000 (07:56 +0000)
https://bugs.webkit.org/show_bug.cgi?id=134541

Reviewed by Gyuyoung Kim.

It happens when attaching a new web process, because it tries to
encode a null SessionState.

* UIProcess/LegacySessionStateCodingNone.cpp:
(WebKit::encodeLegacySessionState): Return an empty API::Data
object instead of nullptr.
(WebKit::encodeLegacySessionHistoryEntryData): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/LegacySessionStateCodingNone.cpp

index f20095f..be411ba 100644 (file)
@@ -1,5 +1,20 @@
 2014-07-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 
+        REGRESSION(r170676): [GTK] UI process crashes when the Web Process crashes
+        https://bugs.webkit.org/show_bug.cgi?id=134541
+
+        Reviewed by Gyuyoung Kim.
+
+        It happens when attaching a new web process, because it tries to
+        encode a null SessionState.
+
+        * UIProcess/LegacySessionStateCodingNone.cpp:
+        (WebKit::encodeLegacySessionState): Return an empty API::Data
+        object instead of nullptr.
+        (WebKit::encodeLegacySessionHistoryEntryData): Ditto.
+
+2014-07-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
         REGRESSION(r170743): [GTK] [EFL] Build broken.
         https://bugs.webkit.org/show_bug.cgi?id=134585
 
index aea0043..5b5adba 100644 (file)
@@ -35,13 +35,13 @@ namespace WebKit {
 RefPtr<API::Data> encodeLegacySessionState(const SessionState&)
 {
     notImplemented();
-    return nullptr;
+    return API::Data::create(nullptr, 0);
 }
 
 RefPtr<API::Data> encodeLegacySessionHistoryEntryData(const FrameState&)
 {
     notImplemented();
-    return nullptr;
+    return API::Data::create(nullptr, 0);
 }
 
 bool decodeLegacySessionState(const uint8_t* data, size_t, SessionState&)