Remove AudioMediaStreamTrackRenderer::muted
authoryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 7 May 2020 23:17:26 +0000 (23:17 +0000)
committeryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 7 May 2020 23:17:26 +0000 (23:17 +0000)
https://bugs.webkit.org/show_bug.cgi?id=211289

Reviewed by Eric Carlson.

Source/WebCore:

* platform/mediastream/AudioMediaStreamTrackRenderer.h:
muted is unnecessary since we are using start/stop instead.

Source/WebKit:

muted is unnecessary since we are using start/stop instead.

* GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
* GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
* GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in:
* WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp:
* WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/mediastream/AudioMediaStreamTrackRenderer.h
Source/WebKit/ChangeLog
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.h

index 0410f91..d85b9d3 100644 (file)
@@ -1,3 +1,13 @@
+2020-05-07  Youenn Fablet  <youenn@apple.com>
+
+        Remove AudioMediaStreamTrackRenderer::muted
+        https://bugs.webkit.org/show_bug.cgi?id=211289
+
+        Reviewed by Eric Carlson.
+
+        * platform/mediastream/AudioMediaStreamTrackRenderer.h:
+        muted is unnecessary since we are using start/stop instead.
+
 2020-05-07  Eric Carlson  <eric.carlson@apple.com>
 
         [macOS] Playhead in Touch Bar continues when loading stalls
index 070e9f1..f20f0b4 100644 (file)
@@ -50,7 +50,6 @@ public:
     // May be called on a background thread. It should only be called after start/before stop is called.
     virtual void pushSamples(const WTF::MediaTime&, const PlatformAudioData&, const AudioStreamDescription&, size_t) = 0;
 
-    virtual void setMuted(bool);
     virtual void setVolume(float);
     float volume() const;
 
@@ -70,13 +69,10 @@ protected:
     WTFLogChannel& logChannel() const final;
 #endif
 
-    bool isMuted() const;
-
 private:
     static RendererCreator m_rendererCreator;
 
     // Main thread writable members
-    bool m_muted { false };
     float m_volume { 1 };
 
 #if !RELEASE_LOG_DISABLED
@@ -85,11 +81,6 @@ private:
 #endif
 };
 
-inline void AudioMediaStreamTrackRenderer::setMuted(bool value)
-{
-    m_muted = value;
-}
-
 inline void AudioMediaStreamTrackRenderer::setVolume(float volume)
 {
     m_volume = volume;
@@ -100,12 +91,6 @@ inline float AudioMediaStreamTrackRenderer::volume() const
     return m_volume;
 }
 
-
-inline bool AudioMediaStreamTrackRenderer::isMuted() const
-{
-    return m_muted;
-}
-
 #if !RELEASE_LOG_DISABLED
 inline const Logger& AudioMediaStreamTrackRenderer::logger() const
 {
index ddc57ff..3a9ce69 100644 (file)
@@ -1,3 +1,18 @@
+2020-05-07  Youenn Fablet  <youenn@apple.com>
+
+        Remove AudioMediaStreamTrackRenderer::muted
+        https://bugs.webkit.org/show_bug.cgi?id=211289
+
+        Reviewed by Eric Carlson.
+
+        muted is unnecessary since we are using start/stop instead.
+
+        * GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
+        * GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
+        * GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in:
+        * WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp:
+        * WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.h:
+
 2020-05-07  Don Olmstead  <don.olmstead@sony.com>
 
         Remove unused USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
index 594159e..972e53b 100644 (file)
@@ -90,11 +90,6 @@ void RemoteAudioMediaStreamTrackRenderer::clear()
     m_renderer->clear();
 }
 
-void RemoteAudioMediaStreamTrackRenderer::setMuted(bool value)
-{
-    m_renderer->setMuted(value);
-}
-
 void RemoteAudioMediaStreamTrackRenderer::setVolume(float value)
 {
     m_renderer->setVolume(value);
index 319cb4a..acb2863 100644 (file)
@@ -55,7 +55,6 @@ private:
     void start();
     void stop();
     void clear();
-    void setMuted(bool);
     void setVolume(float);
     void audioSamplesStorageChanged(const SharedMemory::Handle&, const WebCore::CAAudioStreamDescription&, uint64_t numberOfFrames);
     void audioSamplesAvailable(MediaTime, uint64_t numberOfFrames, uint64_t startFrame, uint64_t endFrame);
index 9bfecc2..dc770fe 100644 (file)
@@ -28,7 +28,6 @@ messages -> RemoteAudioMediaStreamTrackRenderer NotRefCounted {
     Stop()
     Clear()
 
-    SetMuted(bool value)
     SetVolume(float value)
 
     AudioSamplesStorageChanged(WebKit::SharedMemory::Handle storageHandle, WebCore::CAAudioStreamDescription description, uint64_t numberOfFrames)
index 6acd222..de97199 100644 (file)
@@ -73,12 +73,6 @@ void AudioMediaStreamTrackRenderer::clear()
     m_connection->send(Messages::RemoteAudioMediaStreamTrackRenderer::Clear { }, m_identifier);
 }
 
-void AudioMediaStreamTrackRenderer::setMuted(bool value)
-{
-    WebCore::AudioMediaStreamTrackRenderer::setMuted(value);
-    m_connection->send(Messages::RemoteAudioMediaStreamTrackRenderer::SetMuted { value }, m_identifier);
-}
-
 void AudioMediaStreamTrackRenderer::setVolume(float value)
 {
     WebCore::AudioMediaStreamTrackRenderer::setVolume(value);
index 177bf7a..d1e853d 100644 (file)
@@ -56,7 +56,6 @@ private:
     void start() final;
     void stop() final;
     void clear() final;
-    void setMuted(bool) final;
     void setVolume(float) final;
     void pushSamples(const MediaTime&, const WebCore::PlatformAudioData&, const WebCore::AudioStreamDescription&, size_t) final;