2011-03-15 Chris Mumford <chris.mumford@palm.com>
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 15 Mar 2011 10:47:29 +0000 (10:47 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 15 Mar 2011 10:47:29 +0000 (10:47 +0000)
        Reviewed by Adam Barth.

        Initializing several member variables that were not initialized in
        their constructors. These values were all read prior to initialization
        as reported by Valgrind.

        No new tests: No feature additions/removals.

        * accessibility/AccessibilityImageMapLink.cpp:
        (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::HTMLCanvasElement):
        * xml/XPathResult.cpp:
        (WebCore::XPathResult::XPathResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/accessibility/AccessibilityImageMapLink.cpp
Source/WebCore/editing/DeleteSelectionCommand.cpp
Source/WebCore/html/HTMLCanvasElement.cpp
Source/WebCore/xml/XPathResult.cpp

index 57177b5..a148d56 100644 (file)
@@ -1,3 +1,22 @@
+2011-03-15  Chris Mumford  <chris.mumford@palm.com>
+
+        Reviewed by Adam Barth.
+
+        Initializing several member variables that were not initialized in
+        their constructors. These values were all read prior to initialization
+        as reported by Valgrind.
+
+        No new tests: No feature additions/removals.
+
+        * accessibility/AccessibilityImageMapLink.cpp:
+        (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
+        * editing/DeleteSelectionCommand.cpp:
+        (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
+        * html/HTMLCanvasElement.cpp:
+        (WebCore::HTMLCanvasElement::HTMLCanvasElement):
+        * xml/XPathResult.cpp:
+        (WebCore::XPathResult::XPathResult):
+
 2011-03-15  Ben Taylor  <bentaylor.solx86@gmail.com>
 
         Reviewed by Adam Barth.
index 0844d02..a41f228 100644 (file)
@@ -42,6 +42,7 @@ using namespace HTMLNames;
 AccessibilityImageMapLink::AccessibilityImageMapLink()
     : m_areaElement(0)
     , m_mapElement(0)
+    , m_parent(0)
 {
 }
 
index 99b64b2..ad48ab9 100644 (file)
@@ -72,6 +72,7 @@ DeleteSelectionCommand::DeleteSelectionCommand(Document *document, bool smartDel
       m_hasSelectionToDelete(false), 
       m_smartDelete(smartDelete), 
       m_mergeBlocksAfterDelete(mergeBlocksAfterDelete),
+      m_needPlaceholder(false),
       m_replace(replace),
       m_expandForSpecialElements(expandForSpecialElements),
       m_pruneStartBlockIfNecessary(false),
@@ -88,6 +89,7 @@ DeleteSelectionCommand::DeleteSelectionCommand(const VisibleSelection& selection
       m_hasSelectionToDelete(true), 
       m_smartDelete(smartDelete), 
       m_mergeBlocksAfterDelete(mergeBlocksAfterDelete),
+      m_needPlaceholder(false),
       m_replace(replace),
       m_expandForSpecialElements(expandForSpecialElements),
       m_pruneStartBlockIfNecessary(false),
index 0067d26..c361e3d 100644 (file)
@@ -76,6 +76,7 @@ static const float MaxSkiaDim = 32767.0F; // Maximum width/height in CSS pixels.
 HTMLCanvasElement::HTMLCanvasElement(const QualifiedName& tagName, Document* document)
     : HTMLElement(tagName, document)
     , m_size(DefaultWidth, DefaultHeight)
+    , m_rendererIsCanvas(false)
     , m_ignoreReset(false)
     , m_pageScaleFactor(document->frame() ? document->frame()->page()->chrome()->scaleFactor() : 1)
     , m_originClean(true)
index b608280..1dcde2e 100644 (file)
@@ -41,6 +41,8 @@ using namespace XPath;
 
 XPathResult::XPathResult(Document* document, const Value& value)
     : m_value(value)
+    , m_nodeSetPosition(0)
+    , m_domTreeVersion(0)
 {
     switch (m_value.type()) {
         case Value::BooleanValue: