[Qt][Wk2] Many tests are flaky on Qt 5.1
authorallan.jensen@digia.com <allan.jensen@digia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Aug 2013 12:13:05 +0000 (12:13 +0000)
committerallan.jensen@digia.com <allan.jensen@digia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Aug 2013 12:13:05 +0000 (12:13 +0000)
https://bugs.webkit.org/show_bug.cgi?id=118232

Reviewed by Jocelyn Turcotte.

We need to set renderToOffscreenBuffer since we won't otherwise get
the paint calls necessary to synchronize UI- and Web-Process. It was
only disabled in Qt 5.0 because it conflicted with setRenderWithoutShowing
which is no longer supported or needed.

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@154733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp

index eb20b4d..19bee8b 100644 (file)
@@ -1,3 +1,18 @@
+2013-08-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
+
+        [Qt][Wk2] Many tests are flaky on Qt 5.1
+        https://bugs.webkit.org/show_bug.cgi?id=118232
+
+        Reviewed by Jocelyn Turcotte.
+
+        We need to set renderToOffscreenBuffer since we won't otherwise get
+        the paint calls necessary to synchronize UI- and Web-Process. It was
+        only disabled in Qt 5.0 because it conflicted with setRenderWithoutShowing
+        which is no longer supported or needed.
+
+        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
+        (WTR::WrapperWindow::handleStatusChanged):
+
 2013-08-27  Alexey Proskuryakov  <ap@apple.com>
 
         [WK2] Remove USE_WEBPROCESS_EVENT_SIMULATION
index 8f04e2d..9fba4d0 100644 (file)
@@ -70,6 +70,8 @@ private Q_SLOTS:
             create();
 #if QT_VERSION < QT_VERSION_CHECK(5, 1, 0)
             QQuickWindowPrivate::get(this)->setRenderWithoutShowing(true);
+#else
+            m_view->experimental()->setRenderToOffscreenBuffer(true);
 #endif
         } else
             m_view->experimental()->setRenderToOffscreenBuffer(true);