[CSS Regions] Rename CSS classes and JS methods in vertical layout tests about selection
authorrego@igalia.com <rego@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Oct 2013 09:50:07 +0000 (09:50 +0000)
committerrego@igalia.com <rego@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Oct 2013 09:50:07 +0000 (09:50 +0000)
https://bugs.webkit.org/show_bug.cgi?id=123327

Reviewed by Mihnea Ovidenie.

For consistency with Blink we use Vertical instead of Vert in CSS
classes and JS methods related to the selection layout tests for CSS
Regions.

* fast/regions/resources/helper.js:
(selectContentByIdsVertical):
* fast/regions/resources/region-style.css:
* fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html:
* fast/regions/selection/selecting-text-ignoring-region-vert-lr.html:
* fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html:
* fast/regions/selection/selecting-text-ignoring-region-vert-rl.html:
* fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html:
* fast/regions/selection/selecting-text-in-2-regions-vert-lr.html:
* fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html:
* fast/regions/selection/selecting-text-in-2-regions-vert-rl.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@157997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/regions/resources/helper.js
LayoutTests/fast/regions/resources/region-style.css
LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html
LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-lr.html
LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html
LayoutTests/fast/regions/selection/selecting-text-ignoring-region-vert-rl.html
LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html
LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-lr.html
LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html
LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-rl.html

index 461004c..98f7cbe 100644 (file)
@@ -1,3 +1,26 @@
+2013-10-25  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [CSS Regions] Rename CSS classes and JS methods in vertical layout tests about selection
+        https://bugs.webkit.org/show_bug.cgi?id=123327
+
+        Reviewed by Mihnea Ovidenie.
+
+        For consistency with Blink we use Vertical instead of Vert in CSS
+        classes and JS methods related to the selection layout tests for CSS
+        Regions.
+
+        * fast/regions/resources/helper.js:
+        (selectContentByIdsVertical):
+        * fast/regions/resources/region-style.css:
+        * fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html:
+        * fast/regions/selection/selecting-text-ignoring-region-vert-lr.html:
+        * fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html:
+        * fast/regions/selection/selecting-text-ignoring-region-vert-rl.html:
+        * fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html:
+        * fast/regions/selection/selecting-text-in-2-regions-vert-lr.html:
+        * fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html:
+        * fast/regions/selection/selecting-text-in-2-regions-vert-rl.html:
+
 2013-10-25  Javier Fernandez  <jfernandez@igalia.com>
 
         Unreviewed GTK gardening. Several fast/regions/selection tests are failing in WK2.
index ab9a319..5233d70 100644 (file)
@@ -224,7 +224,7 @@ function selectContentByIds(fromId, toId) {
     selectContentByRange(fromRect.left, fromRectVerticalCenter, toRect.right, toRectVerticalCenter);
 }
 
-function selectContentByIdsVert(fromId, toId) {
+function selectContentByIdsVertical(fromId, toId) {
     var fromRect = document.getElementById(fromId).getBoundingClientRect();
     var toRect = document.getElementById(toId).getBoundingClientRect();
 
index 72a9dc6..21d567e 100644 (file)
     background-color: lightgrey;
 }
 
-.descriptionVert {
+.descriptionVertical {
     height: 600px;
 }
 
-.bigBoxVert {
+.bigBoxVertical {
     height: 300px;
     width: 100px;
 }
 
-.greyBigBoxVert {
+.greyBigBoxVertical {
     height: 300px;
     width: 100px;
     background-color: lightgrey;
index a72d01d..4e018cd 100644 (file)
         onMouseUpLogSelection("selected-content");
     </script>
 </head>
-<body onload="selectContentByIdsVert('word1', 'word2');">
-    <div id="region" class="greyBigBoxVert">
+<body onload="selectContentByIdsVertical('word1', 'word2');">
+    <div id="region" class="greyBigBoxVertical">
         inside region inside region inside region inside region
         inside region inside region inside region inside region
     </div>
-    <div id="outside-1" class="bigBoxVert">
+    <div id="outside-1" class="bigBoxVertical">
         outside region outside region outside region outside region
         <span id="word1" class="token">word1</span>
         outside region outside region outside region outside region
     </div>
-    <div id="outside-2" class="bigBoxVert">
+    <div id="outside-2" class="bigBoxVertical">
         outside region outside region outside region outside region
         <span id="word2" class="token">word2</span>
         outside region outside region outside region outside region
     </div>
-    <div id="description" class="descriptionVert">
+    <div id="description" class="descriptionVertical">
         <h1><a href="https://bugs.webkit.org/show_bug.cgi?id=122353">Bug #122353 - [CSS Regions] Layout Test for selecting text ignoring region content</a></h1>
         <p>This test checks the selection in 2 text wrapping a region. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "inside region" text is not highlighted and not included in the selected content (because of the content of the region is before the "outside region" element in the DOM).</p>
         <dl>
index 41febb3..ac75f75 100644 (file)
         onMouseUpLogSelection("selected-content");
     </script>
 </head>
-<body onload="selectContentByIdsVert('word1', 'word2');">
+<body onload="selectContentByIdsVertical('word1', 'word2');">
     <div class="flowArticle">
         inside region inside region inside region inside region
         inside region inside region inside region inside region
     </div>
-    <div class="bigBoxVert float">
+    <div class="bigBoxVertical float">
         outside region outside region outside region outside region
         <span id="word1" class="token">word1</span>
         outside region outside region outside region outside region
     </div>
     <div class="clear"></div>
-    <div class="regionArticle greyBigBoxVert"></div>
-    <div class="bigBoxVert float">
+    <div class="regionArticle greyBigBoxVertical"></div>
+    <div class="bigBoxVertical float">
         outside region outside region outside region outside region
         <span id="word2" class="token">word2</span>
         outside region outside region outside region outside region
     </div>
     <div class="clear"></div>
-    <div class="descriptionVert">
+    <div class="descriptionVertical">
         <h1><a href="https://bugs.webkit.org/show_bug.cgi?id=122353">Bug #122353 - [CSS Regions] Layout Test for selecting text ignoring region content</a></h1>
         <p>This test checks the selection in 2 text wrapping a region. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "inside region" text is not highlighted and not included in the selected content (because of the content of the region is before the "outside region" element in the DOM).</p>
         <dl>
index e09d0eb..d0c5b67 100644 (file)
         onMouseUpLogSelection("selected-content");
     </script>
 </head>
-<body onload="selectContentByIdsVert('word1', 'word2');">
-    <div id="region" class="greyBigBoxVert">
+<body onload="selectContentByIdsVertical('word1', 'word2');">
+    <div id="region" class="greyBigBoxVertical">
         inside region inside region inside region inside region
         inside region inside region inside region inside region
     </div>
-    <div id="outside-1" class="bigBoxVert">
+    <div id="outside-1" class="bigBoxVertical">
         outside region outside region outside region outside region
         <span id="word1" class="token">word1</span>
         outside region outside region outside region outside region
     </div>
-    <div id="outside-2" class="bigBoxVert">
+    <div id="outside-2" class="bigBoxVertical">
         outside region outside region outside region outside region
         <span id="word2" class="token">word2</span>
         outside region outside region outside region outside region
     </div>
-    <div id="description" class="descriptionVert">
+    <div id="description" class="descriptionVertical">
         <h1><a href="https://bugs.webkit.org/show_bug.cgi?id=122353">Bug #122353 - [CSS Regions] Layout Test for selecting text ignoring region content</a></h1>
         <p>This test checks the selection in 2 text wrapping a region. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "inside region" text is not highlighted and not included in the selected content (because of the content of the region is before the "outside region" element in the DOM).</p>
         <dl>
index 9563b55..a9b376d 100644 (file)
         onMouseUpLogSelection("selected-content");
     </script>
 </head>
-<body onload="selectContentByIdsVert('word1', 'word2');">
+<body onload="selectContentByIdsVertical('word1', 'word2');">
     <div class="flowArticle">
         inside region inside region inside region inside region
         inside region inside region inside region inside region
     </div>
-    <div class="bigBoxVert float">
+    <div class="bigBoxVertical float">
         outside region outside region outside region outside region
         <span id="word1" class="token">word1</span>
         outside region outside region outside region outside region
     </div>
     <div class="clear"></div>
-    <div class="regionArticle greyBigBoxVert"></div>
-    <div class="bigBoxVert float">
+    <div class="regionArticle greyBigBoxVertical"></div>
+    <div class="bigBoxVertical float">
         outside region outside region outside region outside region
         <span id="word2" class="token">word2</span>
         outside region outside region outside region outside region
     </div>
     <div class="clear"></div>
-    <div class="descriptionVert">
+    <div class="descriptionVertical">
         <h1><a href="https://bugs.webkit.org/show_bug.cgi?id=122353">Bug #122353 - [CSS Regions] Layout Test for selecting text ignoring region content</a></h1>
         <p>This test checks the selection in 2 text wrapping a region. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "inside region" text is not highlighted and not included in the selected content (because of the content of the region is before the "outside region" element in the DOM).</p>
         <dl>
index 06236a5..2bfac31 100644 (file)
         onMouseUpLogSelection("selected-content");
     </script>
 </head>
-<body onload="selectContentByIdsVert('word1', 'word2');" style="margin-left: 0;">
-    <div id="region-1" class="greyBigBoxVert">
+<body onload="selectContentByIdsVertical('word1', 'word2');" style="margin-left: 0;">
+    <div id="region-1" class="greyBigBoxVertical">
         inside region inside region inside region inside region
         <span id="word1" class="token">word1</span>
         inside region inside region inside region inside region
     </div>
-    <div id="region-2" class="greyBigBoxVert">
+    <div id="region-2" class="greyBigBoxVertical">
         inside region inside region inside region inside region
         <span id="word2" class="token">word2</span>
         inside region inside region inside region inside region
     </div>
-    <div id="outside" class="bigBoxVert">
+    <div id="outside" class="bigBoxVertical">
         outside region outside region outside region outside region
         outside region outside region outside region outside region
     </div>
-    <div id="description" class="descriptionVert">
+    <div id="description" class="descriptionVertical">
         <h1><a href="https://bugs.webkit.org/show_bug.cgi?id=121841">Bug #121841 - [CSS Regions] Layout Test for selecting text in 2 regions</a></h1>
         <p>This test checks the selection in 2 regions. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "outside region" text is not highlighted and not included in the selected content.</p>
         <dl>
index c3b7da4..3e0b531 100644 (file)
@@ -12,7 +12,7 @@
         onMouseUpLogSelection("selected-content");
     </script>
 </head>
-<body onload="selectContentByIdsVert('word1', 'word2');" style="margin-left: 0;">
+<body onload="selectContentByIdsVertical('word1', 'word2');" style="margin-left: 0;">
     <div class="flowArticle">
         inside region inside region inside region inside region
         <span id="word1" class="token">word1</span>
         <span id="word2" class="token">word2</span>
         inside region inside region inside region inside region
     </div>
-    <div class="regionArticle greyBigBoxVert"></div>
-    <div class="bigBoxVert">
+    <div class="regionArticle greyBigBoxVertical"></div>
+    <div class="bigBoxVertical">
         outside region outside region outside region outside region
         outside region outside region outside region outside region
     </div>
-    <div class="regionArticle greyBigBoxVert"></div>
-    <div class="descriptionVert">
+    <div class="regionArticle greyBigBoxVertical"></div>
+    <div class="descriptionVertical">
         <h1><a href="https://bugs.webkit.org/show_bug.cgi?id=121841">Bug #121841 - [CSS Regions] Layout Test for selecting text in 2 regions</a></h1>
         <p>This test checks the selection in 2 regions. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "outside region" text is not highlighted and not included in the selected content.</p>
         <dl>
index 9fab1b3..1fcb381 100644 (file)
         onMouseUpLogSelection("selected-content");
     </script>
 </head>
-<body onload="selectContentByIdsVert('word1', 'word2');" style="margin-right: 0;">
-    <div id="region-1" class="greyBigBoxVert">
+<body onload="selectContentByIdsVertical('word1', 'word2');" style="margin-right: 0;">
+    <div id="region-1" class="greyBigBoxVertical">
         inside region inside region inside region inside region
         <span id="word1" class="token">word1</span>
         inside region inside region inside region inside region
     </div>
-    <div id="region-2" class="greyBigBoxVert">
+    <div id="region-2" class="greyBigBoxVertical">
         inside region inside region inside region inside region
         <span id="word2" class="token">word2</span>
         inside region inside region inside region inside region
     </div>
-    <div id="outside" class="bigBoxVert">
+    <div id="outside" class="bigBoxVertical">
         outside region outside region outside region outside region
         outside region outside region outside region outside region
     </div>
-    <div id="description" class="descriptionVert">
+    <div id="description" class="descriptionVertical">
         <h1><a href="https://bugs.webkit.org/show_bug.cgi?id=121841">Bug #121841 - [CSS Regions] Layout Test for selecting text in 2 regions</a></h1>
         <p>This test checks the selection in 2 regions. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "outside region" text is not highlighted and not included in the selected content.</p>
         <dl>
index ce65e9d..4362025 100644 (file)
@@ -12,7 +12,7 @@
         onMouseUpLogSelection("selected-content");
     </script>
 </head>
-<body onload="selectContentByIdsVert('word1', 'word2');" style="margin-right: 0;">
+<body onload="selectContentByIdsVertical('word1', 'word2');" style="margin-right: 0;">
     <div class="flowArticle">
         inside region inside region inside region inside region
         <span id="word1" class="token">word1</span>
         <span id="word2" class="token">word2</span>
         inside region inside region inside region inside region
     </div>
-    <div class="regionArticle greyBigBoxVert"></div>
-    <div class="bigBoxVert">
+    <div class="regionArticle greyBigBoxVertical"></div>
+    <div class="bigBoxVertical">
         outside region outside region outside region outside region
         outside region outside region outside region outside region
     </div>
-    <div class="regionArticle greyBigBoxVert"></div>
-    <div class="descriptionVert">
+    <div class="regionArticle greyBigBoxVertical"></div>
+    <div class="descriptionVertical">
         <h1><a href="https://bugs.webkit.org/show_bug.cgi?id=121841">Bug #121841 - [CSS Regions] Layout Test for selecting text in 2 regions</a></h1>
         <p>This test checks the selection in 2 regions. If you select from <span class="token">word1</span> to <span class="token">word2</span> you will see that "outside region" text is not highlighted and not included in the selected content.</p>
         <dl>