AX: Mavericks: Text cursor does not move along with VoiceOver cursor for text fields
authorcfleizach@apple.com <cfleizach@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 11 Sep 2015 00:55:14 +0000 (00:55 +0000)
committercfleizach@apple.com <cfleizach@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 11 Sep 2015 00:55:14 +0000 (00:55 +0000)
https://bugs.webkit.org/show_bug.cgi?id=148891

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Asychronous focus setting DOES work on Yosemite, just not Mavericks.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):

LayoutTests:

Mark accessibility focus tests as passing on Yosemite.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/mac/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

index ea45668..d81ec2c 100644 (file)
@@ -1,3 +1,14 @@
+2015-09-10  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Mavericks: Text cursor does not move along with VoiceOver cursor for text fields
+        https://bugs.webkit.org/show_bug.cgi?id=148891
+
+        Reviewed by Alexey Proskuryakov.
+
+        Mark accessibility focus tests as passing on Yosemite.
+
+        * platform/mac/TestExpectations:
+
 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
 
         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
 
         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
index 267c80e..7d437c8 100644 (file)
@@ -1194,8 +1194,8 @@ webkit.org/b/142142 media/video-volume-slider-drag.html [ Skip ]
 webkit.org/b/17022 [ MountainLion Mavericks ] fast/images/animated-png.html [ Skip ]
 
 # Pre-Capitan does not support asynchronous attribute setting.
 webkit.org/b/17022 [ MountainLion Mavericks ] fast/images/animated-png.html [ Skip ]
 
 # Pre-Capitan does not support asynchronous attribute setting.
-[ Mavericks Yosemite ] accessibility/mac/setting-attributes-is-asynchronous.html [ Skip ]
-[ Mavericks Yosemite ] accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html [ Skip ]
+[ Mavericks ] accessibility/mac/setting-attributes-is-asynchronous.html [ Skip ]
+[ Mavericks ] accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html [ Skip ]
 
 # OS X 10.10.3+ has the necessary glyphs.
 webkit.org/b/142548 [ Yosemite+ ] editing/selection/extend-by-character-007.html [ Pass ]
 
 # OS X 10.10.3+ has the necessary glyphs.
 webkit.org/b/142548 [ Yosemite+ ] editing/selection/extend-by-character-007.html [ Pass ]
index 5348f97..c4d5f36 100644 (file)
@@ -1,3 +1,16 @@
+2015-09-10  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Mavericks: Text cursor does not move along with VoiceOver cursor for text fields
+        https://bugs.webkit.org/show_bug.cgi?id=148891
+
+        Reviewed by Alexey Proskuryakov.
+
+        Asychronous focus setting DOES work on Yosemite, just not Mavericks.
+
+        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+        (-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
+        (-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):
+
 2015-09-10  David Hyatt  <hyatt@apple.com>
 
         [New Block-Inside-Inline Model] Self-collapsing block check needs to account for anonymous inline blocks
 2015-09-10  David Hyatt  <hyatt@apple.com>
 
         [New Block-Inside-Inline Model] Self-collapsing block check needs to account for anonymous inline blocks
index 210465f..9d437d9 100644 (file)
@@ -3393,7 +3393,7 @@ static NSString* roleValueToNSString(AccessibilityRole value)
 
 - (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attributeName
 {
 
 - (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attributeName
 {
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
     // In case anything we do by changing values causes an alert or other modal
     // behaviors, we need to return now, so that VoiceOver doesn't hang indefinitely.
     dispatch_async(dispatch_get_main_queue(), ^{
     // In case anything we do by changing values causes an alert or other modal
     // behaviors, we need to return now, so that VoiceOver doesn't hang indefinitely.
     dispatch_async(dispatch_get_main_queue(), ^{