Drop obsolete HTMLDocument.width / height attributes
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 16 Jan 2016 01:03:47 +0000 (01:03 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 16 Jan 2016 01:03:47 +0000 (01:03 +0000)
https://bugs.webkit.org/show_bug.cgi?id=153144

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

* web-platform-tests/dom/historical-expected.txt:

Source/WebCore:

Drop obsolete HTMLDocument.width / height attributes as these are
obsolete and already not supported by other major browsers (tested
Firefox and Chrome).

No new tests, already covered by existing tests.

* html/HTMLDocument.idl:

LayoutTests:

* fast/dom/HTMLDocument/width-and-height-expected.txt: Removed.
* fast/dom/HTMLDocument/width-and-height.html: Removed.
Drop outdated test.

* fast/dom/Window/window-property-invalid-characters-ignored-expected.txt:
* fast/dom/Window/window-property-invalid-characters-ignored.html:
Stop relying on Document.width / height as these are obsolete.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@195160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt [deleted file]
LayoutTests/fast/dom/HTMLDocument/width-and-height.html [deleted file]
LayoutTests/fast/dom/Window/window-property-invalid-characters-ignored-expected.txt
LayoutTests/fast/dom/Window/window-property-invalid-characters-ignored.html
LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/html/HTMLDocument.idl

index c7d768d..0bba270 100644 (file)
@@ -1,3 +1,18 @@
+2016-01-15  Chris Dumez  <cdumez@apple.com>
+
+        Drop obsolete HTMLDocument.width / height attributes
+        https://bugs.webkit.org/show_bug.cgi?id=153144
+
+        Reviewed by Ryosuke Niwa.
+
+        * fast/dom/HTMLDocument/width-and-height-expected.txt: Removed.
+        * fast/dom/HTMLDocument/width-and-height.html: Removed.
+        Drop outdated test.
+
+        * fast/dom/Window/window-property-invalid-characters-ignored-expected.txt:
+        * fast/dom/Window/window-property-invalid-characters-ignored.html:
+        Stop relying on Document.width / height as these are obsolete.
+
 2016-01-15  Beth Dakin  <bdakin@apple.com>
 
         Add a test for touch events in scaled documents
diff --git a/LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt b/LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt
deleted file mode 100644 (file)
index 6a8862a..0000000
+++ /dev/null
@@ -1 +0,0 @@
-PASS. The document.width and document.height properties are accessible from JavaScript.
diff --git a/LayoutTests/fast/dom/HTMLDocument/width-and-height.html b/LayoutTests/fast/dom/HTMLDocument/width-and-height.html
deleted file mode 100644 (file)
index b098b42..0000000
+++ /dev/null
@@ -1,9 +0,0 @@
-<script>
-    if (window.testRunner)
-        testRunner.dumpAsText();
-
-    if ('width' in document && 'height' in document)
-        document.write("PASS. The document.width and document.height properties are accessible from JavaScript.");
-    else
-        document.write("FAIL. document.width or document.height are not accessible from JavaScript.");
-</script>
index 52636e6..d88d793 100644 (file)
@@ -3,8 +3,8 @@ Tests that invalid characters are ignored after a window property value.
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS w.document.width is 123
-PASS w.document.height is 123
+PASS w.innerWidth is 123
+PASS w.innerHeight is 123
 PASS w !== window is true
 PASS successfullyParsed is true
 
index 6f28602..fb7be7f 100644 (file)
@@ -16,8 +16,8 @@ var w = window.open("resources/window-property-invalid-characters-ignored.html",
 
 function finishTest()
 {
-    shouldBe("w.document.width", "123");
-    shouldBe("w.document.height", "123");
+    shouldBe("w.innerWidth", "123");
+    shouldBe("w.innerHeight", "123");
     shouldBeTrue("w !== window");
     w.close();
 
index f5f1968..7731614 100644 (file)
@@ -1,5 +1,16 @@
 2016-01-15  Chris Dumez  <cdumez@apple.com>
 
+        Drop obsolete HTMLDocument.width / height attributes
+        https://bugs.webkit.org/show_bug.cgi?id=153144
+
+        Reviewed by Ryosuke Niwa.
+
+        Rebaseline W3C test now that more checks are passing.
+
+        * web-platform-tests/dom/historical-expected.txt:
+
+2016-01-15  Chris Dumez  <cdumez@apple.com>
+
         Drop obsolete DocumentType.entities / notations
         https://bugs.webkit.org/show_bug.cgi?id=153147
 
index f41de73..d0d191c 100644 (file)
@@ -28,8 +28,8 @@ PASS Historical DOM features must be removed: domConfig
 PASS Historical DOM features must be removed: normalizeDocument 
 PASS Historical DOM features must be removed: renameNode 
 FAIL Historical DOM features must be removed: defaultCharset assert_equals: expected (undefined) undefined but got (string) "ISO-8859-1"
-FAIL Historical DOM features must be removed: height assert_equals: expected (undefined) undefined but got (number) 600
-FAIL Historical DOM features must be removed: width assert_equals: expected (undefined) undefined but got (number) 800
+PASS Historical DOM features must be removed: height 
+PASS Historical DOM features must be removed: width 
 PASS DOMImplementation.getFeature() must be nuked. 
 PASS Historical DOM features must be removed: schemaTypeInfo 
 PASS Historical DOM features must be removed: setIdAttribute 
index 2cbf2d2..90459f3 100644 (file)
@@ -1,5 +1,20 @@
 2016-01-15  Chris Dumez  <cdumez@apple.com>
 
+        Drop obsolete HTMLDocument.width / height attributes
+        https://bugs.webkit.org/show_bug.cgi?id=153144
+
+        Reviewed by Ryosuke Niwa.
+
+        Drop obsolete HTMLDocument.width / height attributes as these are
+        obsolete and already not supported by other major browsers (tested
+        Firefox and Chrome).
+
+        No new tests, already covered by existing tests.
+
+        * html/HTMLDocument.idl:
+
+2016-01-15  Chris Dumez  <cdumez@apple.com>
+
         Drop obsolete DocumentType.entities / notations
         https://bugs.webkit.org/show_bug.cgi?id=153147
 
index 7758713..688938b 100644 (file)
     void captureEvents();
     void releaseEvents();
 
+#if !defined(LANGUAGE_JAVASCRIPT) || !LANGUAGE_JAVASCRIPT
     readonly attribute long width;
     readonly attribute long height;
+#endif
+
              [TreatNullAs=NullString] attribute DOMString dir;
              [TreatNullAs=NullString] attribute DOMString designMode;
     readonly attribute DOMString compatMode;