[BlackBerry] Remove pointless const in InputHandler
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Aug 2013 00:51:36 +0000 (00:51 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Aug 2013 00:51:36 +0000 (00:51 +0000)
https://bugs.webkit.org/show_bug.cgi?id=119550

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-08-07
Reviewed by Rob Buis.
Internally reviewed by Leo Yang and Mike Fenton.

* Api/WebPageClient.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
(BlackBerry::WebKit::InputHandler::redrawSpellCheckDialogIfRequired):
* WebKitSupport/InputHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/blackberry/Api/WebPageClient.h
Source/WebKit/blackberry/ChangeLog
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
Source/WebKit/blackberry/WebKitSupport/InputHandler.h

index 1aea90e..a29434d 100644 (file)
@@ -146,7 +146,7 @@ public:
     virtual void showFormControls(bool visible, bool previousActive = false, bool nextActive = false) = 0;
     virtual void showVirtualKeyboard(bool) = 0;
 
-    virtual void requestSpellingCheckingOptions(imf_sp_text_t&, const BlackBerry::Platform::IntRect& documentCaretRect, const BlackBerry::Platform::IntSize& screenOffset, const bool shouldMoveDialog) = 0;
+    virtual void requestSpellingCheckingOptions(imf_sp_text_t&, const BlackBerry::Platform::IntRect& documentCaretRect, const BlackBerry::Platform::IntSize& screenOffset, bool shouldMoveDialog) = 0;
     virtual int32_t checkSpellingOfStringAsync(wchar_t* text, const unsigned length) = 0;
 
     virtual void notifySelectionDetailsChanged(const BlackBerry::Platform::SelectionDetails&) = 0;
index ab2b566..cb8d606 100644 (file)
@@ -1,3 +1,17 @@
+2013-08-07  Jacky Jiang  <zhajiang@blackberry.com>
+
+        [BlackBerry] Remove pointless const in InputHandler
+        https://bugs.webkit.org/show_bug.cgi?id=119550
+
+        Reviewed by Rob Buis.
+        Internally reviewed by Leo Yang and Mike Fenton.
+
+        * Api/WebPageClient.h:
+        * WebKitSupport/InputHandler.cpp:
+        (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
+        (BlackBerry::WebKit::InputHandler::redrawSpellCheckDialogIfRequired):
+        * WebKitSupport/InputHandler.h:
+
 2013-08-04  Sam Weinig  <sam@webkit.org>
 
         Remove support for HTML5 MicroData
index 86a98d2..1fbf050 100644 (file)
@@ -788,7 +788,7 @@ bool InputHandler::shouldRequestSpellCheckingOptionsForPoint(const Platform::Int
     return true;
 }
 
-void InputHandler::requestSpellingCheckingOptions(imf_sp_text_t& spellCheckingOptionRequest, WebCore::IntSize& screenOffset, const bool shouldMoveDialog)
+void InputHandler::requestSpellingCheckingOptions(imf_sp_text_t& spellCheckingOptionRequest, WebCore::IntSize& screenOffset, bool shouldMoveDialog)
 {
     // If the caret is no longer active, no message should be sent.
     if (m_webPage->focusedOrMainFrame()->selection()->selectionType() != VisibleSelection::CaretSelection)
@@ -1256,7 +1256,7 @@ void InputHandler::stopPendingSpellCheckRequests(bool isRestartRequired)
     }
 }
 
-void InputHandler::redrawSpellCheckDialogIfRequired(const bool shouldMoveDialog)
+void InputHandler::redrawSpellCheckDialogIfRequired(bool shouldMoveDialog)
 {
     if (didSpellCheckWord()) {
         imf_sp_text_t spellCheckingOptionRequest;
index b74bcc4..70d9951 100644 (file)
@@ -154,9 +154,9 @@ public:
     void spellCheckTextBlock(WebCore::Element* = 0);
 
     bool shouldRequestSpellCheckingOptionsForPoint(const Platform::IntPoint& documentContentPosition, const WebCore::Element*, imf_sp_text_t&);
-    void requestSpellingCheckingOptions(imf_sp_text_t&, WebCore::IntSize& screenOffset, const bool shouldMoveDialog = false);
+    void requestSpellingCheckingOptions(imf_sp_text_t&, WebCore::IntSize& screenOffset, bool shouldMoveDialog = false);
     void clearDidSpellCheckState() { m_didSpellCheckWord = false; }
-    void redrawSpellCheckDialogIfRequired(const bool shouldMoveDialog = true);
+    void redrawSpellCheckDialogIfRequired(bool shouldMoveDialog = true);
 
     void callRequestCheckingFor(PassRefPtr<WebCore::SpellCheckRequest>);
     void setSystemSpellCheckStatus(bool enabled) { m_spellCheckStatusConfirmed = true; m_globalSpellCheckStatus = enabled; }