ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
authormark.lam@apple.com <mark.lam@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 29 Nov 2018 01:22:19 +0000 (01:22 +0000)
committermark.lam@apple.com <mark.lam@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 29 Nov 2018 01:22:19 +0000 (01:22 +0000)
https://bugs.webkit.org/show_bug.cgi?id=192110
<rdar://problem/46317746>

Reviewed by Saam Barati.

Source/JavaScriptCore:

* config.h:

Source/WTF:

Contrary my previous claim in r238564, ENABLE_SEPARATED_WX_HEAP needs to be
defined in Platform.h because it is also needed in WebCore for the CSS JIT.  Also
contrary to my previous claim, ENABLE(FAST_JIT_PERMISSIONS) is defined for WebCore
(and other projects) as well as JSC.  Hence, there's no reason why
ENABLE_SEPARATED_WX_HEAP cannot be defined in Platform.h.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/config.h
Source/WTF/ChangeLog
Source/WTF/wtf/Platform.h

index 16cdd14..22559e4 100644 (file)
@@ -1,3 +1,13 @@
+2018-11-28  Mark Lam  <mark.lam@apple.com>
+
+        ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
+        https://bugs.webkit.org/show_bug.cgi?id=192110
+        <rdar://problem/46317746>
+
+        Reviewed by Saam Barati.
+
+        * config.h:
+
 2018-11-28  Keith Rollin  <krollin@apple.com>
 
         Update generate-{derived,unified}-sources scripts to support generating .xcfilelist files
index 5baade4..e0232cf 100644 (file)
 #endif
 
 #include <wtf/DisallowCType.h>
-
-#if !defined(ENABLE_SEPARATED_WX_HEAP)
-#if (!ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)) && PLATFORM(IOS_FAMILY) && CPU(ARM64)
-#define ENABLE_SEPARATED_WX_HEAP 1
-#else
-#define ENABLE_SEPARATED_WX_HEAP 0
-#endif
-#endif // !defined(ENABLE_SEPARATED_WX_HEAP)
index 4f468cb..76a3895 100644 (file)
@@ -1,3 +1,19 @@
+2018-11-28  Mark Lam  <mark.lam@apple.com>
+
+        ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
+        https://bugs.webkit.org/show_bug.cgi?id=192110
+        <rdar://problem/46317746>
+
+        Reviewed by Saam Barati.
+
+        Contrary my previous claim in r238564, ENABLE_SEPARATED_WX_HEAP needs to be
+        defined in Platform.h because it is also needed in WebCore for the CSS JIT.  Also
+        contrary to my previous claim, ENABLE(FAST_JIT_PERMISSIONS) is defined for WebCore
+        (and other projects) as well as JSC.  Hence, there's no reason why
+        ENABLE_SEPARATED_WX_HEAP cannot be defined in Platform.h.
+
+        * wtf/Platform.h:
+
 2018-11-28  Keith Rollin  <krollin@apple.com>
 
         Update generate-unified-source-bundles.rb to generate .xcfilelist files
index d3348d1..8bd71ea 100644 (file)
 #define JIT_OPERATION
 #endif
 
+#ifndef ENABLE_SEPARATED_WX_HEAP
+#if (!ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)) && PLATFORM(IOS_FAMILY) && CPU(ARM64)
+#define ENABLE_SEPARATED_WX_HEAP 1
+#else
+#define ENABLE_SEPARATED_WX_HEAP 0
+#endif
+#endif
+
 /* Configure the interpreter */
 #if COMPILER(GCC_COMPATIBLE)
 #define HAVE_COMPUTED_GOTO 1