SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Nov 2017 21:42:29 +0000 (21:42 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Nov 2017 21:42:29 +0000 (21:42 +0000)
https://bugs.webkit.org/show_bug.cgi?id=180214

Reviewed by Brady Eidson.

SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted.
RefCounted is sufficient as there is no longer any multithreading on server side.

* workers/service/server/SWServerToContextConnection.h:
* workers/service/server/SWServerWorker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/workers/service/server/SWServerToContextConnection.h
Source/WebCore/workers/service/server/SWServerWorker.h

index 3e9927d..24874cc 100644 (file)
@@ -1,5 +1,18 @@
 2017-11-30  Chris Dumez  <cdumez@apple.com>
 
+        SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted
+        https://bugs.webkit.org/show_bug.cgi?id=180214
+
+        Reviewed by Brady Eidson.
+
+        SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted.
+        RefCounted is sufficient as there is no longer any multithreading on server side.
+
+        * workers/service/server/SWServerToContextConnection.h:
+        * workers/service/server/SWServerWorker.h:
+
+2017-11-30  Chris Dumez  <cdumez@apple.com>
+
         ServiceWorkerGlobalScope::skipWaiting() should resolve its promise
         https://bugs.webkit.org/show_bug.cgi?id=180204
 
index 4a152f2..5db8d0a 100644 (file)
@@ -29,7 +29,7 @@
 
 #include "ServiceWorkerIdentifier.h"
 #include "ServiceWorkerTypes.h"
-#include <wtf/ThreadSafeRefCounted.h>
+#include <wtf/RefCounted.h>
 
 namespace WebCore {
 
@@ -37,7 +37,7 @@ class SWServer;
 struct ServiceWorkerContextData;
 struct ServiceWorkerJobDataIdentifier;
 
-class SWServerToContextConnection : public ThreadSafeRefCounted<SWServerToContextConnection> {
+class SWServerToContextConnection : public RefCounted<SWServerToContextConnection> {
 public:
     WEBCORE_EXPORT virtual ~SWServerToContextConnection();
 
index c30d459..ac869b4 100644 (file)
@@ -32,7 +32,7 @@
 #include "ServiceWorkerRegistrationKey.h"
 #include "ServiceWorkerTypes.h"
 #include "URL.h"
-#include <wtf/ThreadSafeRefCounted.h>
+#include <wtf/RefCounted.h>
 
 namespace WebCore {
 
@@ -41,7 +41,7 @@ class SWServerRegistration;
 enum class WorkerType;
 struct ServiceWorkerJobDataIdentifier;
 
-class SWServerWorker : public ThreadSafeRefCounted<SWServerWorker> {
+class SWServerWorker : public RefCounted<SWServerWorker> {
 public:
     template <typename... Args> static Ref<SWServerWorker> create(Args&&... args)
     {