REGRESSION (r140658): Multiple accessibility failures on GTK
authordmazzoni@google.com <dmazzoni@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Jan 2013 08:23:58 +0000 (08:23 +0000)
committerdmazzoni@google.com <dmazzoni@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Jan 2013 08:23:58 +0000 (08:23 +0000)
https://bugs.webkit.org/show_bug.cgi?id=107832

Reviewed by Chris Fleizach.

Source/WebCore:

In the ATK accessibility implementation, attachWrapper
might create a different object depending on the role of
the WebCore AccessibilityObject, whereas on other platforms
attachWrapper doesn't care. Calling init before attachWrapper
solves the problem.

Re-enables 7 skipped tests.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):

LayoutTests:

Re-enable accessibility tests that were skipped when they started
failing.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/accessibility/AXObjectCache.cpp

index 41d06a7..f78e419 100644 (file)
@@ -1,3 +1,15 @@
+2013-01-25  Dominic Mazzoni  <dmazzoni@google.com>
+
+        REGRESSION (r140658): Multiple accessibility failures on GTK
+        https://bugs.webkit.org/show_bug.cgi?id=107832
+
+        Reviewed by Chris Fleizach.
+
+        Re-enable accessibility tests that were skipped when they started
+        failing.
+
+        * platform/gtk/TestExpectations:
+
 2013-01-25  Ryosuke Niwa  <rniwa@webkit.org>
 
         (Hopefully) Final Mac rebaselines for r140728.
index 3381fb1..7c875d4 100644 (file)
@@ -1406,16 +1406,6 @@ webkit.org/b/105574 fast/spatial-navigation/snav-div-overflow-scrol-hidden.html
 
 webkit.org/b/106563 fast/css/image-orientation/image-orientation.html [ Failure ]
 
-webkit.org/b/107832 accessibility/aria-slider-value.html [ Failure ]
-webkit.org/b/107832 accessibility/aria-tables.html [ Failure ]
-webkit.org/b/107832 accessibility/document-attributes.html [ Failure ]
-webkit.org/b/107832 accessibility/language-attribute.html [ Failure ]
-webkit.org/b/107832 accessibility/spinbutton-value.html [ Failure ]
-webkit.org/b/107832 platform/gtk/accessibility/aria-slider-required-attributes.html [ Failure ]
-webkit.org/b/107832 platform/gtk/accessibility/entry-and-password.html [ Failure ]
-webkit.org/b/107832 platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html [ Failure ]
-webkit.org/b/107832 platform/gtk/accessibility/table-hierarchy.html [ Failure ]
-
 #////////////////////////////////////////////////////////////////////////////////////////
 # End of Tests failing
 #////////////////////////////////////////////////////////////////////////////////////////
index 34ae632..05074d4 100644 (file)
@@ -1,3 +1,21 @@
+2013-01-25  Dominic Mazzoni  <dmazzoni@google.com>
+
+        REGRESSION (r140658): Multiple accessibility failures on GTK
+        https://bugs.webkit.org/show_bug.cgi?id=107832
+
+        Reviewed by Chris Fleizach.
+
+        In the ATK accessibility implementation, attachWrapper
+        might create a different object depending on the role of
+        the WebCore AccessibilityObject, whereas on other platforms
+        attachWrapper doesn't care. Calling init before attachWrapper
+        solves the problem.
+
+        Re-enables 7 skipped tests.
+
+        * accessibility/AXObjectCache.cpp:
+        (WebCore::AXObjectCache::getOrCreate):
+
 2013-01-24  Kent Tamura  <tkent@chromium.org>
 
         INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum() and maximum() of DateTimeSymbolicFieldElement
index 47a649d..8eff326 100644 (file)
@@ -313,8 +313,8 @@ AccessibilityObject* AXObjectCache::getOrCreate(Widget* widget)
     
     m_widgetObjectMapping.set(widget, newObj->axObjectID());
     m_objects.set(newObj->axObjectID(), newObj);    
-    attachWrapper(newObj.get());
     newObj->init();
+    attachWrapper(newObj.get());
     return newObj.get();
 }
 
@@ -348,9 +348,8 @@ AccessibilityObject* AXObjectCache::getOrCreate(Node* node)
 
     m_nodeObjectMapping.set(node, newObj->axObjectID());
     m_objects.set(newObj->axObjectID(), newObj);
-    attachWrapper(newObj.get());
-
     newObj->init();
+    attachWrapper(newObj.get());
     newObj->setCachedIsIgnoredValue(newObj->accessibilityIsIgnored());
 
     return newObj.get();
@@ -373,9 +372,8 @@ AccessibilityObject* AXObjectCache::getOrCreate(RenderObject* renderer)
 
     m_renderObjectMapping.set(renderer, newObj->axObjectID());
     m_objects.set(newObj->axObjectID(), newObj);
-    attachWrapper(newObj.get());
-
     newObj->init();
+    attachWrapper(newObj.get());
     newObj->setCachedIsIgnoredValue(newObj->accessibilityIsIgnored());
 
     return newObj.get();
@@ -442,8 +440,8 @@ AccessibilityObject* AXObjectCache::getOrCreate(AccessibilityRole role)
         return 0;
 
     m_objects.set(obj->axObjectID(), obj);    
-    attachWrapper(obj.get());
     obj->init();
+    attachWrapper(obj.get());
     return obj.get();
 }