[GStreamer] http/tests/media/video-auth.html is failing
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 16 Sep 2014 08:46:10 +0000 (08:46 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 16 Sep 2014 08:46:10 +0000 (08:46 +0000)
https://bugs.webkit.org/show_bug.cgi?id=126619

Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-09-16
Reviewed by Philippe Normand.

Source/WebCore:

Test: http/tests/media/video-auth-cors.html

Use stored credentials when retrieving videos following image loading behavior
(i.e. stored credentials are always used except when in cors anonymous mode),
except that requesting credentials from user remains disabled for cross-origin requests.

Patch is covered by http/tests/media/video-auth.html.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(CachedResourceStreamingClient::CachedResourceStreamingClient): Enable using stored credentials except when using cors anonymous mode.

LayoutTests:

* platform/efl/TestExpectations: Removed failure expectation for http/tests/media/video-auth.html.
* platform/efl/http/tests/media/video-auth-expected.txt: Added.
* platform/gtk/TestExpectations: Removed failure expectation for http/tests/media/video-auth.html.
* platform/gtk/http/tests/media/video-auth-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/efl/TestExpectations
LayoutTests/platform/efl/http/tests/media/video-auth-expected.txt [new file with mode: 0755]
LayoutTests/platform/gtk/TestExpectations [changed mode: 0644->0755]
LayoutTests/platform/gtk/http/tests/media/video-auth-expected.txt [new file with mode: 0755]
Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

index 2e199fa..f746b24 100644 (file)
@@ -1,3 +1,15 @@
+2014-09-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
+
+        [GStreamer] http/tests/media/video-auth.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=126619
+
+        Reviewed by Philippe Normand.
+
+        * platform/efl/TestExpectations: Removed failure expectation for http/tests/media/video-auth.html.
+        * platform/efl/http/tests/media/video-auth-expected.txt: Added.
+        * platform/gtk/TestExpectations: Removed failure expectation for http/tests/media/video-auth.html.
+        * platform/gtk/http/tests/media/video-auth-expected.txt: Added.
+
 2014-09-16  Jinho Bang  <jinho.bang@samsung.com>
 
         Add version of drawFocusIfNeeded that take a Path2D parameter.
index c3e3152..4d5a4fc 100644 (file)
@@ -1821,8 +1821,6 @@ webkit.org/b/127477 css2.1/t1604-c542-letter-sp-00-b-a.html [ Missing ]
 
 webkit.org/b/127489 http/tests/misc/will-send-request-returns-null-on-redirect.html [ Failure ]
 
-webkit.org/b/126619 http/tests/media/video-auth.html [ Failure ]
-
 webkit.org/b/127725 media/video-restricted-no-preload-auto.html [ Failure ]
 
 webkit.org/b/127731 plugins/embed-prefers-plugins-for-images.html [ Failure ]
diff --git a/LayoutTests/platform/efl/http/tests/media/video-auth-expected.txt b/LayoutTests/platform/efl/http/tests/media/video-auth-expected.txt
new file mode 100755 (executable)
index 0000000..7e52312
--- /dev/null
@@ -0,0 +1,6 @@
+didReceiveAuthenticationChallenge - Responding with username:password
+Tests that the media player sends authorization credentials when requesting a media file.  
+EVENT(canplay)
+END OF TEST
+
old mode 100644 (file)
new mode 100755 (executable)
index 48b7350..94a7e4a
@@ -1852,8 +1852,6 @@ webkit.org/b/125348 accessibility/document-attributes.html [ Failure ]
 
 webkit.org/b/125406 fast/regions/relative-in-absolute-borders-overflow.html [ ImageOnlyFailure ]
 
-webkit.org/b/126619 http/tests/media/video-auth.html [ Failure ]
-
 # Subpixel rendering: borders are reporting float values.
 webkit.org/b/128061 fast/css/bidi-override-in-anonymous-block.html [ Failure ]
 webkit.org/b/128061 fast/repaint/repaint-during-scroll-with-zoom.html [ Failure ]
diff --git a/LayoutTests/platform/gtk/http/tests/media/video-auth-expected.txt b/LayoutTests/platform/gtk/http/tests/media/video-auth-expected.txt
new file mode 100755 (executable)
index 0000000..7e52312
--- /dev/null
@@ -0,0 +1,6 @@
+didReceiveAuthenticationChallenge - Responding with username:password
+Tests that the media player sends authorization credentials when requesting a media file.  
+EVENT(canplay)
+END OF TEST
+
index ba16392..1801071 100644 (file)
@@ -1,3 +1,21 @@
+2014-09-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
+
+        [GStreamer] http/tests/media/video-auth.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=126619
+
+        Reviewed by Philippe Normand.
+
+        Test: http/tests/media/video-auth-cors.html
+
+        Use stored credentials when retrieving videos following image loading behavior
+        (i.e. stored credentials are always used except when in cors anonymous mode),
+        except that requesting credentials from user remains disabled for cross-origin requests.
+
+        Patch is covered by http/tests/media/video-auth.html.
+
+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+        (CachedResourceStreamingClient::CachedResourceStreamingClient): Enable using stored credentials except when using cors anonymous mode.
+
 2014-09-16  Jinho Bang  <jinho.bang@samsung.com>
 
         Add version of drawFocusIfNeeded that take a Path2D parameter.
index 7c7741b..05eb8cb 100644 (file)
@@ -996,7 +996,7 @@ CachedResourceStreamingClient::CachedResourceStreamingClient(WebKitWebSrc* src,
 {
     DataBufferingPolicy bufferingPolicy = request.url().protocolIs("blob") ? BufferData : DoNotBufferData;
     RequestOriginPolicy corsPolicy = corsMode != MediaPlayerClient::Unspecified ? PotentiallyCrossOriginEnabled : UseDefaultOriginRestrictionsForType;
-    StoredCredentials allowCredentials = corsMode == MediaPlayerClient::UseCredentials ? AllowStoredCredentials : DoNotAllowStoredCredentials;
+    StoredCredentials allowCredentials = corsMode == MediaPlayerClient::Anonymous ? DoNotAllowStoredCredentials : AllowStoredCredentials;
     ResourceLoaderOptions options(SendCallbacks, DoNotSniffContent, bufferingPolicy, allowCredentials, DoNotAskClientForCrossOriginCredentials, DoSecurityCheck, corsPolicy, DoNotIncludeCertificateInfo);
 
     CachedResourceRequest cacheRequest(request, options);