Remove WILL_REVEAL_EDGE_EVENTS code
authorsimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Jun 2017 21:29:21 +0000 (21:29 +0000)
committersimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Jun 2017 21:29:21 +0000 (21:29 +0000)
https://bugs.webkit.org/show_bug.cgi?id=173632

Reviewed by Sam Weinig, Beth Dakin.

Remove will-reveal-edge events, which never took off.

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::clearScriptedAnimationController):
(WebCore::Document::sendWillRevealEdgeEventsIfNeeded): Deleted.
* dom/Document.h:
* dom/GlobalEventHandlers.idl:
* html/HTMLBodyElement.idl:
* html/HTMLFrameSetElement.idl:
* page/FrameView.cpp:
(WebCore::FrameView::scrollPositionChanged):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):

Source/WTF:

* wtf/FeatureDefines.h:

LayoutTests:

* fast/events/will-reveal-edge-on-div-expected.txt: Removed.
* fast/events/will-reveal-edge-on-div.html: Removed.
* fast/events/will-reveal-edges-body-attributes-expected.txt: Removed.
* fast/events/will-reveal-edges-body-attributes.html: Removed.
* fast/events/will-reveal-edges-event-listeners-expected.txt: Removed.
* fast/events/will-reveal-edges-event-listeners.html: Removed.
* fast/events/will-reveal-edges-window-attributes-expected.txt: Removed.
* fast/events/will-reveal-edges-window-attributes.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@218651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/events/will-reveal-edge-on-div-expected.txt [deleted file]
LayoutTests/fast/events/will-reveal-edge-on-div.html [deleted file]
LayoutTests/fast/events/will-reveal-edges-body-attributes-expected.txt [deleted file]
LayoutTests/fast/events/will-reveal-edges-body-attributes.html [deleted file]
LayoutTests/fast/events/will-reveal-edges-event-listeners-expected.txt [deleted file]
LayoutTests/fast/events/will-reveal-edges-event-listeners.html [deleted file]
LayoutTests/fast/events/will-reveal-edges-window-attributes-expected.txt [deleted file]
LayoutTests/fast/events/will-reveal-edges-window-attributes.html [deleted file]
Source/WTF/ChangeLog
Source/WTF/wtf/FeatureDefines.h
Source/WebCore/ChangeLog
Source/WebCore/dom/Document.cpp
Source/WebCore/dom/Document.h
Source/WebCore/dom/GlobalEventHandlers.idl
Source/WebCore/html/HTMLBodyElement.idl
Source/WebCore/html/HTMLFrameSetElement.idl
Source/WebCore/page/FrameView.cpp
Source/WebCore/rendering/RenderLayer.cpp

index 1abd497..5d6aae5 100644 (file)
@@ -1,3 +1,21 @@
+2017-06-20  Simon Fraser  <simon.fraser@apple.com>
+
+        Remove WILL_REVEAL_EDGE_EVENTS code
+        https://bugs.webkit.org/show_bug.cgi?id=173632
+
+        Reviewed by Sam Weinig, Beth Dakin.
+
+        Remove will-reveal-edge events, which never took off.
+
+        * fast/events/will-reveal-edge-on-div-expected.txt: Removed.
+        * fast/events/will-reveal-edge-on-div.html: Removed.
+        * fast/events/will-reveal-edges-body-attributes-expected.txt: Removed.
+        * fast/events/will-reveal-edges-body-attributes.html: Removed.
+        * fast/events/will-reveal-edges-event-listeners-expected.txt: Removed.
+        * fast/events/will-reveal-edges-event-listeners.html: Removed.
+        * fast/events/will-reveal-edges-window-attributes-expected.txt: Removed.
+        * fast/events/will-reveal-edges-window-attributes.html: Removed.
+
 2017-06-21  Simon Fraser  <simon.fraser@apple.com>
 
         svgPath.getTotalLength() freezes webkit
diff --git a/LayoutTests/fast/events/will-reveal-edge-on-div-expected.txt b/LayoutTests/fast/events/will-reveal-edge-on-div-expected.txt
deleted file mode 100644 (file)
index fe0c26f..0000000
+++ /dev/null
@@ -1,10 +0,0 @@
-This tests that we can listen for webkitwillrevealbottom, webkitwillrevealtop, webkitwillrevealleft, and webkitwillrevealright
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-All edges were revealed!
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
diff --git a/LayoutTests/fast/events/will-reveal-edge-on-div.html b/LayoutTests/fast/events/will-reveal-edge-on-div.html
deleted file mode 100644 (file)
index b1570f1..0000000
+++ /dev/null
@@ -1,83 +0,0 @@
-<html>
-<script src="../../resources/js-test-pre.js"></script>
-
-<style>
-#scrolly-div {
-    width:200px;
-    height:200px;
-    border:2px solid black;
-    overflow:scroll;
-}
-
-.big {
-    background-color:purple;
-    width:600px;
-    height:600px;
-}
-</style>
-
-<script type="text/javascript">
-description('This tests that we can listen for webkitwillrevealbottom, webkitwillrevealtop, webkitwillrevealleft, and webkitwillrevealright');
-
-var triggeredWillRevealBottom = false;
-var triggeredWillRevealTop = false;
-var triggeredWillRevealRight = false;
-var triggeredWillRevealLeft = false;
-
-function bottomRevealed()
-{
-    triggeredWillRevealBottom = true;
-    var scrolly = document.getElementById("scrolly-div");
-    scrolly.scrollTop = 0;
-    checkComplete();
-}
-
-function topRevealed()
-{
-    triggeredWillRevealTop = true;
-    var scrolly = document.getElementById("scrolly-div");
-    scrolly.scrollLeft = 600;
-    checkComplete();
-}
-
-function rightRevealed()
-{
-    triggeredWillRevealRight = true;
-    var scrolly = document.getElementById("scrolly-div");
-    scrolly.scrollLeft = 0;
-    checkComplete();
-}
-
-function leftRevealed()
-{
-    triggeredWillRevealLeft = true;
-    checkComplete();
-}
-
-function checkComplete()
-{
-    if (triggeredWillRevealBottom && triggeredWillRevealTop && triggeredWillRevealRight && triggeredWillRevealLeft) {
-        debug('All edges were revealed!');
-        finishJSTest();
-    }
-}
-
-var jsTestIsAsync = true;
-
-function runTest() {
-    var scrolly = document.getElementById("scrolly-div");
-    scrolly.addEventListener('webkitwillrevealbottom', bottomRevealed, false);
-    scrolly.addEventListener('webkitwillrevealtop', topRevealed, false);
-    scrolly.addEventListener('webkitwillrevealright', rightRevealed, false);
-    scrolly.addEventListener('webkitwillrevealleft', leftRevealed, false);
-    scrolly.scrollTop = 600;
-}
-</script>
-
-<body onload="runTest()">
-    <div id="scrolly-div">
-        <div class="big"></div>
-    </div>
-    <script src="../../resources/js-test-post.js"></script>
-</body>
-</html>
diff --git a/LayoutTests/fast/events/will-reveal-edges-body-attributes-expected.txt b/LayoutTests/fast/events/will-reveal-edges-body-attributes-expected.txt
deleted file mode 100644 (file)
index 14ec35c..0000000
+++ /dev/null
@@ -1,10 +0,0 @@
-This tests that onwebkitwillrevealbottom, onwebkitwillrevealtop, onwebkitwillrevealleft, and onwebkitwillrevealright work as body attributes
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-All edges were revealed!
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
diff --git a/LayoutTests/fast/events/will-reveal-edges-body-attributes.html b/LayoutTests/fast/events/will-reveal-edges-body-attributes.html
deleted file mode 100644 (file)
index 8fc823c..0000000
+++ /dev/null
@@ -1,54 +0,0 @@
-<html>
-<script src="../../resources/js-test-pre.js"></script>
-
-<script type="text/javascript">
-description('This tests that onwebkitwillrevealbottom, onwebkitwillrevealtop, onwebkitwillrevealleft, and onwebkitwillrevealright work as body attributes');
-
-var triggeredWillRevealBottom = false;
-var triggeredWillRevealTop = false;
-var triggeredWillRevealRight = false;
-var triggeredWillRevealLeft = false;
-
-function willRevealBottom() {
-    triggeredWillRevealBottom = true;
-    window.scrollTo(0,0);
-    checkComplete();
-}
-
-function willRevealTop() {
-    triggeredWillRevealTop = true;
-    window.scrollTo(2000, 0);
-    checkComplete();
-}
-
-function willRevealRight() {
-    triggeredWillRevealRight = true;
-    window.scrollTo(0, 0);
-    checkComplete();
-}
-
-function willRevealLeft() {
-    triggeredWillRevealLeft = true;
-    checkComplete();
-}
-
-function checkComplete()
-{
-    if (triggeredWillRevealBottom && triggeredWillRevealTop && triggeredWillRevealRight && triggeredWillRevealLeft) {
-        debug('All edges were revealed!');
-        finishJSTest();
-    }
-}
-
-var jsTestIsAsync = true;
-
-function runTest() {
-    window.scrollTo(0, 2000);
-}
-</script>
-
-<body style="height:2000px; width:2000px;" onload="runTest()" onwebkitwillrevealbottom="willRevealBottom()"
-    onwebkitwillrevealtop="willRevealTop()" onwebkitwillrevealright="willRevealRight()" onwebkitwillrevealleft="willRevealLeft()">
-    <script src="../../resources/js-test-post.js"></script>
-</body>
-</html>
diff --git a/LayoutTests/fast/events/will-reveal-edges-event-listeners-expected.txt b/LayoutTests/fast/events/will-reveal-edges-event-listeners-expected.txt
deleted file mode 100644 (file)
index fe0c26f..0000000
+++ /dev/null
@@ -1,10 +0,0 @@
-This tests that we can listen for webkitwillrevealbottom, webkitwillrevealtop, webkitwillrevealleft, and webkitwillrevealright
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-All edges were revealed!
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
diff --git a/LayoutTests/fast/events/will-reveal-edges-event-listeners.html b/LayoutTests/fast/events/will-reveal-edges-event-listeners.html
deleted file mode 100644 (file)
index d02e649..0000000
+++ /dev/null
@@ -1,65 +0,0 @@
-<html>
-<script src="../../resources/js-test-pre.js"></script>
-
-<script type="text/javascript">
-description('This tests that we can listen for webkitwillrevealbottom, webkitwillrevealtop, webkitwillrevealleft, and webkitwillrevealright');
-
-var triggeredWillRevealBottom = false;
-var triggeredWillRevealTop = false;
-var triggeredWillRevealRight = false;
-var triggeredWillRevealLeft = false;
-
-window.addEventListener(
-    'webkitwillrevealbottom',
-    function() {
-        triggeredWillRevealBottom = true;
-        window.scrollTo(0,0);
-        checkComplete();
-    },
-    false);
-
-window.addEventListener(
-    'webkitwillrevealtop',
-    function(event) {
-        triggeredWillRevealTop = true;
-        window.scrollTo(2000, 0);
-        checkComplete();
-    },
-    false);
-
-window.addEventListener(
-    'webkitwillrevealright',
-    function(event) {
-        triggeredWillRevealRight = true;
-        window.scrollTo(0, 0);
-        checkComplete();
-    },
-    false);
-
-window.addEventListener(
-    'webkitwillrevealleft',
-    function(event) {
-        triggeredWillRevealLeft = true;
-        checkComplete();
-    },
-    false);
-
-function checkComplete()
-{
-    if (triggeredWillRevealBottom && triggeredWillRevealTop && triggeredWillRevealRight && triggeredWillRevealLeft) {
-        debug('All edges were revealed!');
-        finishJSTest();
-    }
-}
-
-var jsTestIsAsync = true;
-
-function runTest() {
-    window.scrollTo(0, 2000);
-}
-</script>
-
-<body style="height:2000px; width:2000px;" onload="runTest()">
-    <script src="../../resources/js-test-post.js"></script>
-</body>
-</html>
diff --git a/LayoutTests/fast/events/will-reveal-edges-window-attributes-expected.txt b/LayoutTests/fast/events/will-reveal-edges-window-attributes-expected.txt
deleted file mode 100644 (file)
index 2797921..0000000
+++ /dev/null
@@ -1,10 +0,0 @@
-This tests that onwebkitwillrevealbottom, onwebkitwillrevealtop, onwebkitwillrevealleft, and onwebkitwillrevealright work as window attributes.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-All edges were revealed!
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
diff --git a/LayoutTests/fast/events/will-reveal-edges-window-attributes.html b/LayoutTests/fast/events/will-reveal-edges-window-attributes.html
deleted file mode 100644 (file)
index 7cad521..0000000
+++ /dev/null
@@ -1,57 +0,0 @@
-<html>
-<script src="../../resources/js-test-pre.js"></script>
-
-<script type="text/javascript">
-description('This tests that onwebkitwillrevealbottom, onwebkitwillrevealtop, onwebkitwillrevealleft, and onwebkitwillrevealright work as window attributes.');
-
-var triggeredWillRevealBottom = false;
-var triggeredWillRevealTop = false;
-var triggeredWillRevealRight = false;
-var triggeredWillRevealLeft = false;
-
-window.onwebkitwillrevealbottom =
-    function() {
-        triggeredWillRevealBottom = true;
-        window.scrollTo(0,0);
-        checkComplete();
-    }
-
-window.onwebkitwillrevealtop =
-    function() {
-        triggeredWillRevealTop = true;
-        window.scrollTo(2000, 0);
-        checkComplete();
-    }
-
-window.onwebkitwillrevealright =
-    function() {
-        triggeredWillRevealRight = true;
-        window.scrollTo(0, 0);
-        checkComplete();
-    }
-
-window.onwebkitwillrevealleft =
-    function() {
-        triggeredWillRevealLeft = true;
-        checkComplete();
-    }
-
-function checkComplete()
-{
-    if (triggeredWillRevealBottom && triggeredWillRevealTop && triggeredWillRevealRight && triggeredWillRevealLeft) {
-        debug('All edges were revealed!');
-        finishJSTest();
-    }
-}
-
-var jsTestIsAsync = true;
-
-function runTest() {
-    window.scrollTo(0, 2000);
-}
-</script>
-
-<body style="height:2000px; width:2000px;" onload="runTest()">
-    <script src="../../resources/js-test-post.js"></script>
-</body>
-</html>
index a96bcb7..43a2ddf 100644 (file)
@@ -1,3 +1,14 @@
+2017-06-20  Simon Fraser  <simon.fraser@apple.com>
+
+        Remove WILL_REVEAL_EDGE_EVENTS code
+        https://bugs.webkit.org/show_bug.cgi?id=173632
+
+        Reviewed by Sam Weinig, Beth Dakin.
+
+        Remove will-reveal-edge events, which never took off.
+
+        * wtf/FeatureDefines.h:
+
 2017-06-20  Konstantin Tokarev  <annulen@yandex.ru>
 
         Remove excessive include directives from WTF
index 081f192..67a9456 100644 (file)
@@ -732,10 +732,6 @@ the public iOS SDK. We will also need to update the FeatureDefines.xcconfig file
 #define ENABLE_WEB_TIMING 0
 #endif
 
-#if !defined(ENABLE_WILL_REVEAL_EDGE_EVENTS)
-#define ENABLE_WILL_REVEAL_EDGE_EVENTS 1
-#endif
-
 #if !defined(ENABLE_XSLT)
 #define ENABLE_XSLT 1
 #endif
index 745be8a..2865592 100644 (file)
@@ -1,3 +1,24 @@
+2017-06-20  Simon Fraser  <simon.fraser@apple.com>
+
+        Remove WILL_REVEAL_EDGE_EVENTS code
+        https://bugs.webkit.org/show_bug.cgi?id=173632
+
+        Reviewed by Sam Weinig, Beth Dakin.
+
+        Remove will-reveal-edge events, which never took off.
+
+        * dom/Document.cpp:
+        (WebCore::Document::clearScriptedAnimationController):
+        (WebCore::Document::sendWillRevealEdgeEventsIfNeeded): Deleted.
+        * dom/Document.h:
+        * dom/GlobalEventHandlers.idl:
+        * html/HTMLBodyElement.idl:
+        * html/HTMLFrameSetElement.idl:
+        * page/FrameView.cpp:
+        (WebCore::FrameView::scrollPositionChanged):
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::scrollTo):
+
 2017-06-21  Daniel Bates  <dabates@apple.com>
 
         Cleanup FrameLoadRequest
index 9a09879..60d6135 100644 (file)
@@ -6270,77 +6270,6 @@ void Document::clearScriptedAnimationController()
         m_scriptedAnimationController->clearDocumentPointer();
     m_scriptedAnimationController = nullptr;
 }
-    
-void Document::sendWillRevealEdgeEventsIfNeeded(const IntPoint& oldPosition, const IntPoint& newPosition, const IntRect& visibleRect, const IntSize& contentsSize, Element* target)
-{
-    // For each edge (top, bottom, left and right), send the will reveal edge event for that direction
-    // if newPosition is at or beyond the notification point, if the scroll direction is heading in the
-    // direction of that edge point, and if oldPosition is before the notification point (which indicates
-    // that this is the first moment that we know we crossed the magic line).
-    
-#if ENABLE(WILL_REVEAL_EDGE_EVENTS)
-    // FIXME: broken in RTL documents.
-    int willRevealBottomNotificationPoint = std::max(0, contentsSize.height() - 2 *  visibleRect.height());
-    int willRevealTopNotificationPoint = visibleRect.height();
-
-    // Bottom edge.
-    if (newPosition.y() >= willRevealBottomNotificationPoint && newPosition.y() > oldPosition.y()
-        && willRevealBottomNotificationPoint >= oldPosition.y()) {
-        Ref<Event> willRevealEvent = Event::create(eventNames().webkitwillrevealbottomEvent, false, false);
-        if (!target)
-            enqueueWindowEvent(WTFMove(willRevealEvent));
-        else {
-            willRevealEvent->setTarget(target);
-            m_eventQueue.enqueueEvent(WTFMove(willRevealEvent));
-        }
-    }
-
-    // Top edge.
-    if (newPosition.y() <= willRevealTopNotificationPoint && newPosition.y() < oldPosition.y()
-        && willRevealTopNotificationPoint <= oldPosition.y()) {
-        Ref<Event> willRevealEvent = Event::create(eventNames().webkitwillrevealtopEvent, false, false);
-        if (!target)
-            enqueueWindowEvent(WTFMove(willRevealEvent));
-        else {
-            willRevealEvent->setTarget(target);
-            m_eventQueue.enqueueEvent(WTFMove(willRevealEvent));
-        }
-    }
-
-    int willRevealRightNotificationPoint = std::max(0, contentsSize.width() - 2 * visibleRect.width());
-    int willRevealLeftNotificationPoint = visibleRect.width();
-
-    // Right edge.
-    if (newPosition.x() >= willRevealRightNotificationPoint && newPosition.x() > oldPosition.x()
-        && willRevealRightNotificationPoint >= oldPosition.x()) {
-        Ref<Event> willRevealEvent = Event::create(eventNames().webkitwillrevealrightEvent, false, false);
-        if (!target)
-            enqueueWindowEvent(WTFMove(willRevealEvent));
-        else {
-            willRevealEvent->setTarget(target);
-            m_eventQueue.enqueueEvent(WTFMove(willRevealEvent));
-        }
-    }
-
-    // Left edge.
-    if (newPosition.x() <= willRevealLeftNotificationPoint && newPosition.x() < oldPosition.x()
-        && willRevealLeftNotificationPoint <= oldPosition.x()) {
-        Ref<Event> willRevealEvent = Event::create(eventNames().webkitwillrevealleftEvent, false, false);
-        if (!target)
-            enqueueWindowEvent(WTFMove(willRevealEvent));
-        else {
-            willRevealEvent->setTarget(target);
-            m_eventQueue.enqueueEvent(WTFMove(willRevealEvent));
-        }
-    }
-#else
-    UNUSED_PARAM(oldPosition);
-    UNUSED_PARAM(newPosition);
-    UNUSED_PARAM(visibleRect);
-    UNUSED_PARAM(contentsSize);
-    UNUSED_PARAM(target);
-#endif
-}
 
 void Document::wheelEventHandlersChanged()
 {
index fea4aad..273ca92 100644 (file)
@@ -1164,8 +1164,6 @@ public:
     void cancelAnimationFrame(int id);
     void serviceScriptedAnimations(double timestamp);
 
-    void sendWillRevealEdgeEventsIfNeeded(const IntPoint& oldPosition, const IntPoint& newPosition, const IntRect& visibleRect, const IntSize& contentsSize, Element* target = nullptr);
-
     EventTarget* errorEventTarget() final;
     void logExceptionToConsole(const String& errorMessage, const String& sourceURL, int lineNumber, int columnNumber, RefPtr<Inspector::ScriptCallStack>&&) final;
 
index 5321908..24f13a2 100644 (file)
     [NotEnumerable, Conditional=MOUSE_FORCE_EVENTS] attribute EventHandler onwebkitmouseforcedown;
     [NotEnumerable, Conditional=MOUSE_FORCE_EVENTS] attribute EventHandler onwebkitmouseforcewillbegin;
     [NotEnumerable, Conditional=MOUSE_FORCE_EVENTS] attribute EventHandler onwebkitmouseforceup;
-    [NotEnumerable, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealbottom;
-    [NotEnumerable, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealleft;
-    [NotEnumerable, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealright;
-    [NotEnumerable, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealtop;
 };
index 49dc6ae..6eef87b 100644 (file)
@@ -39,10 +39,6 @@ interface HTMLBodyElement : HTMLElement {
     [NotEnumerable, WindowEventHandler, Conditional=MOUSE_FORCE_EVENTS] attribute EventHandler onwebkitmouseforcedown;
     [NotEnumerable, WindowEventHandler, Conditional=MOUSE_FORCE_EVENTS] attribute EventHandler onwebkitmouseforcewillbegin;
     [NotEnumerable, WindowEventHandler, Conditional=MOUSE_FORCE_EVENTS] attribute EventHandler onwebkitmouseforceup;
-    [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealbottom;
-    [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealleft;
-    [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealright;
-    [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealtop;
 
     // Unique to Document and HTMLBodyElement
     [NotEnumerable, DocumentEventHandler] attribute EventHandler onselectionchange;
index 2da1f5c..3250b94 100644 (file)
@@ -31,11 +31,6 @@ interface HTMLFrameSetElement : HTMLElement {
     [NotEnumerable, WindowEventHandler] attribute EventHandler onresize;
     [NotEnumerable, WindowEventHandler] attribute EventHandler onscroll;
 
-    [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealbottom;
-    [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealleft;
-    [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealright;
-    [NotEnumerable, WindowEventHandler, Conditional=WILL_REVEAL_EDGE_EVENTS] attribute EventHandler onwebkitwillrevealtop;
-    
     // Non-standard named getter
     // FIXME: This is not in the standard, can we remove this?
     getter DOMWindow (DOMString name);
index e089b0f..61e2695 100644 (file)
@@ -2540,6 +2540,9 @@ void FrameView::scrollOffsetChangedViaPlatformWidgetImpl(const ScrollOffset& old
 // These scroll positions are affected by zooming.
 void FrameView::scrollPositionChanged(const ScrollPosition& oldPosition, const ScrollPosition& newPosition)
 {
+    UNUSED_PARAM(oldPosition);
+    UNUSED_PARAM(newPosition);
+
     Page* page = frame().page();
     Seconds throttlingDelay = page ? page->chrome().client().eventThrottlingDelay() : 0_s;
 
@@ -2549,9 +2552,6 @@ void FrameView::scrollPositionChanged(const ScrollPosition& oldPosition, const S
     } else if (!m_delayedScrollEventTimer.isActive())
         m_delayedScrollEventTimer.startOneShot(throttlingDelay);
 
-    if (Document* document = frame().document())
-        document->sendWillRevealEdgeEventsIfNeeded(oldPosition, newPosition, visibleContentRect(), contentsSize());
-
     if (RenderView* renderView = this->renderView()) {
         if (renderView->usesCompositing())
             renderView->compositor().frameViewDidScroll();
index ed52be6..9d60301 100644 (file)
@@ -2406,7 +2406,6 @@ void RenderLayer::scrollTo(const ScrollPosition& position)
         return;
     }
     
-    ScrollPosition oldPosition = IntPoint(m_scrollPosition);
     m_scrollPosition = newPosition;
 
     RenderView& view = renderer().view();
@@ -2457,10 +2456,8 @@ void RenderLayer::scrollTo(const ScrollPosition& position)
         renderer().repaintUsingContainer(repaintContainer, rectForRepaint);
 
     // Schedule the scroll and scroll-related DOM events.
-    if (Element* element = renderer().element()) {
+    if (Element* element = renderer().element())
         element->document().eventQueue().enqueueOrDispatchScrollEvent(*element);
-        element->document().sendWillRevealEdgeEventsIfNeeded(oldPosition, newPosition, visibleContentRect(), contentsSize(), element);
-    }
 
     if (scrollsOverflow())
         view.frameView().didChangeScrollOffset();