JetStream 2 should not report time values as scores
authorsbarati@apple.com <sbarati@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Mar 2019 01:47:29 +0000 (01:47 +0000)
committersbarati@apple.com <sbarati@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Mar 2019 01:47:29 +0000 (01:47 +0000)
https://bugs.webkit.org/show_bug.cgi?id=196334

Reviewed by Yusuke Suzuki.

PerformanceTests:

* JetStream2/JetStreamDriver.js:
(toTimeValue):
(Driver.prototype.async.reportScoreToRunBenchmarkRunner):

Websites/browserbench.org:

* JetStream2.0/JetStreamDriver.js:
(toTimeValue):
(Driver.prototype.async.reportScoreToRunBenchmarkRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

PerformanceTests/ChangeLog
PerformanceTests/JetStream2/JetStreamDriver.js
Websites/browserbench.org/ChangeLog
Websites/browserbench.org/JetStream2.0/JetStreamDriver.js

index 7dd76fa..0b2ede8 100644 (file)
@@ -1,3 +1,14 @@
+2019-03-27  Saam Barati  <sbarati@apple.com>
+
+        JetStream 2 should not report time values as scores
+        https://bugs.webkit.org/show_bug.cgi?id=196334
+
+        Reviewed by Yusuke Suzuki.
+
+        * JetStream2/JetStreamDriver.js:
+        (toTimeValue):
+        (Driver.prototype.async.reportScoreToRunBenchmarkRunner):
+
 2019-03-27  Saam barati  <sbarati@apple.com>
 
         Unreviewed. Fix individual benchmark description urls to go to in-depth.html instead of about.html
index c777f88..c228f0c 100644 (file)
@@ -82,6 +82,10 @@ function toScore(timeValue) {
     return 5000 / timeValue;
 }
 
+function toTimeValue(score) {
+    return 5000 / score;
+}
+
 function updateUI() {
     return new Promise((resolve) => {
         if (isInBrowser)
@@ -319,7 +323,7 @@ class Driver {
             const subResults = {}
             const subTimes = benchmark.subTimes();
             for (const name in subTimes) {
-                subResults[name] = {"metrics": {"Time": {"current": [subTimes[name]]}}};
+                subResults[name] = {"metrics": {"Time": {"current": [toTimeValue(subTimes[name])]}}};
             }
             results[benchmark.name] = {
                 "metrics" : {
index 6c1f931..906c370 100644 (file)
@@ -1,3 +1,14 @@
+2019-03-27  Saam Barati  <sbarati@apple.com>
+
+        JetStream 2 should not report time values as scores
+        https://bugs.webkit.org/show_bug.cgi?id=196334
+
+        Reviewed by Yusuke Suzuki.
+
+        * JetStream2.0/JetStreamDriver.js:
+        (toTimeValue):
+        (Driver.prototype.async.reportScoreToRunBenchmarkRunner):
+
 2019-03-27  Saam barati  <sbarati@apple.com>
 
         Unreviewed. Fix individual benchmark description urls to go to in-depth.html instead of about.html
index c777f88..c228f0c 100644 (file)
@@ -82,6 +82,10 @@ function toScore(timeValue) {
     return 5000 / timeValue;
 }
 
+function toTimeValue(score) {
+    return 5000 / score;
+}
+
 function updateUI() {
     return new Promise((resolve) => {
         if (isInBrowser)
@@ -319,7 +323,7 @@ class Driver {
             const subResults = {}
             const subTimes = benchmark.subTimes();
             for (const name in subTimes) {
-                subResults[name] = {"metrics": {"Time": {"current": [subTimes[name]]}}};
+                subResults[name] = {"metrics": {"Time": {"current": [toTimeValue(subTimes[name])]}}};
             }
             results[benchmark.name] = {
                 "metrics" : {