Unreviewed, add extra test failure logging after r200971
authordrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 27 Aug 2019 00:48:14 +0000 (00:48 +0000)
committerdrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 27 Aug 2019 00:48:14 +0000 (00:48 +0000)
* inspector/debugger/tail-deleted-frames-this-value.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/inspector/debugger/tail-deleted-frames-this-value.html

index 4970bb8..fda06b3 100644 (file)
@@ -1,3 +1,10 @@
+2019-08-26  Devin Rousso  <drousso@apple.com>
+
+        Unreviewed, add extra test failure logging after r200971
+
+        * inspector/debugger/tail-deleted-frames-this-value.html:
+        Also log the actual value (in addition to the expected one) in assertion messages.
+
 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         Remove UIHelper.activateElementAtHumanSpeed
 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         Remove UIHelper.activateElementAtHumanSpeed
index 0bf27cb..8f9de24 100644 (file)
@@ -42,7 +42,7 @@ function test()
         let targetData = WI.debuggerManager.dataForTarget(WI.debuggerManager.activeCallFrame.target);
         let callFrames = targetData.callFrames;
 
         let targetData = WI.debuggerManager.dataForTarget(WI.debuggerManager.activeCallFrame.target);
         let callFrames = targetData.callFrames;
 
-        InspectorTest.assert(callFrames.length >= expectedFrames.length, `Should have ${expectedFrames.length} frames.`);
+        InspectorTest.assert(callFrames.length >= expectedFrames.length, `Should have at least ${expectedFrames.length} frames, but have ${callFrame.length} instead.`);
 
         // Resolve a thisObject preview on each of the CallFrames.
         let promises = [];
 
         // Resolve a thisObject preview on each of the CallFrames.
         let promises = [];
@@ -60,12 +60,12 @@ function test()
                 let callFrame = callFrames[i];
                 let expectedFrame = expectedFrames[i];
                 InspectorTest.log("Expected frame: " + JSON.stringify(expectedFrame));
                 let callFrame = callFrames[i];
                 let expectedFrame = expectedFrames[i];
                 InspectorTest.log("Expected frame: " + JSON.stringify(expectedFrame));
-                InspectorTest.assert(callFrame.functionName === expectedFrame.functionName, `Should have functionName of '${expectedFrame.functionName}'.`);
-                InspectorTest.assert(callFrame.isTailDeleted === expectedFrame.isTailDeleted, `Should have isTailDeleted of '${expectedFrame.isTailDeleted}.`);
+                InspectorTest.assert(callFrame.functionName === expectedFrame.functionName, `Should have functionName of '${expectedFrame.functionName}', but have '${callFrame.functionName}' instead.`);
+                InspectorTest.assert(callFrame.isTailDeleted === expectedFrame.isTailDeleted, `Should have isTailDeleted of '${expectedFrame.isTailDeleted}', but have '${callFrame.isTailDeleted}' instead.`);
 
                 let thisObject = callFrame.thisObject;
                 let properties = thisObject.preview.propertyPreviews;
 
                 let thisObject = callFrame.thisObject;
                 let properties = thisObject.preview.propertyPreviews;
-                InspectorTest.assert(properties.length === 1, "Should hvae one property.");
+                InspectorTest.assert(properties.length === 1, "Should have one property.");
                 let prop = properties[0];
                 InspectorTest.expectThat(expectedFrame.thisValue[0] === prop.name, `'this' value should have expected property: ${expectedFrame.thisValue[0]}`);
                 InspectorTest.assert('' + expectedFrame.thisValue[1] === prop.value, `'this' value object should have expected property value: ${expectedFrame.thisValue[1]}`);
                 let prop = properties[0];
                 InspectorTest.expectThat(expectedFrame.thisValue[0] === prop.name, `'this' value should have expected property: ${expectedFrame.thisValue[0]}`);
                 InspectorTest.assert('' + expectedFrame.thisValue[1] === prop.value, `'this' value object should have expected property value: ${expectedFrame.thisValue[1]}`);