[WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNot...
authorzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Oct 2013 20:33:41 +0000 (20:33 +0000)
committerzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Oct 2013 20:33:41 +0000 (20:33 +0000)
https://bugs.webkit.org/show_bug.cgi?id=122275

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/fileapi/.

* fileapi/Blob.idl:
* fileapi/FileException.idl:
* fileapi/FileList.idl:
* fileapi/FileReader.idl:
* fileapi/FileReaderSync.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/fileapi/Blob.idl
Source/WebCore/fileapi/FileException.idl
Source/WebCore/fileapi/FileList.idl
Source/WebCore/fileapi/FileReader.idl
Source/WebCore/fileapi/FileReaderSync.idl

index 2f6f433..10ed916 100644 (file)
@@ -1,5 +1,27 @@
 2013-10-04  Zan Dobersek  <zdobersek@igalia.com>
 
+        [WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
+        https://bugs.webkit.org/show_bug.cgi?id=122275
+
+        Reviewed by Darin Adler.
+
+        Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
+        interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
+        doesn't have any effect, but will keep the operations not configurable after the generator is modified
+        to preserve the original behavior. The attribute will be removed from each interface after checking
+        conformity with other browsers (in terms of configurability of operations of that interface) and the
+        WebKit's existing test suites.
+
+        This patch covers IDL interfaces under Source/WebCore/fileapi/.
+
+        * fileapi/Blob.idl:
+        * fileapi/FileException.idl:
+        * fileapi/FileList.idl:
+        * fileapi/FileReader.idl:
+        * fileapi/FileReaderSync.idl:
+
+2013-10-04  Zan Dobersek  <zdobersek@igalia.com>
+
         [WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the OperationsNotDeletable attribute
         https://bugs.webkit.org/show_bug.cgi?id=122271
 
index 17cd5e2..6a4ea89 100644 (file)
@@ -34,7 +34,8 @@
     CustomToJSObject,
     JSNoStaticTables,
     CustomConstructor,
-    CustomConstructor(sequence<any> blobParts, optional BlobPropertyBag options)
+    CustomConstructor(sequence<any> blobParts, optional BlobPropertyBag options),
+    OperationsNotDeletable
 ] interface Blob {
     readonly attribute unsigned long long size;
     readonly attribute DOMString type;
index fa7ea5e..0565e7e 100644 (file)
@@ -33,7 +33,8 @@
     Conditional=BLOB,
     DoNotCheckConstants,
     JSNoStaticTables,
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] exception FileException {
 
     readonly attribute unsigned short   code;
index f0d4ce4..413a7a8 100644 (file)
@@ -25,7 +25,8 @@
 
 [
     JSNoStaticTables,
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] interface FileList {
     readonly attribute unsigned long length;
     getter File item(unsigned long index);
index 0d5af4f..8e48e22 100644 (file)
@@ -36,7 +36,8 @@
     Constructor,
     ConstructorCallWith=ScriptExecutionContext,
     EventTarget,
-    JSNoStaticTables
+    JSNoStaticTables,
+    OperationsNotDeletable
 ] interface FileReader {
     // ready states
     const unsigned short EMPTY = 0;
index 8ef0f6a..5be22e1 100644 (file)
@@ -32,7 +32,8 @@
     GlobalContext=WorkerGlobalScope,
     Conditional=BLOB,
     Constructor,
-    JSNoStaticTables
+    JSNoStaticTables,
+    OperationsNotDeletable
 ] interface FileReaderSync {
     [CallWith=ScriptExecutionContext, RaisesException] ArrayBuffer readAsArrayBuffer(Blob blob);
     [CallWith=ScriptExecutionContext, RaisesException] DOMString readAsBinaryString(Blob blob);