Web Inspector: add pixel area column to layout timeline view
authormattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Jun 2016 22:29:32 +0000 (22:29 +0000)
committermattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Jun 2016 22:29:32 +0000 (22:29 +0000)
https://bugs.webkit.org/show_bug.cgi?id=148677
<rdar://problem/22518762>

Reviewed by Timothy Hatcher.

The view can simply add the column. LayoutTimelineDataGridNode
already includes area data and cell formatting.

* UserInterface/Views/LayoutTimelineView.js:
(WebInspector.LayoutTimelineView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js

index 032931c..27eaaac 100644 (file)
@@ -1,3 +1,17 @@
+2016-06-30  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: add pixel area column to layout timeline view
+        https://bugs.webkit.org/show_bug.cgi?id=148677
+        <rdar://problem/22518762>
+
+        Reviewed by Timothy Hatcher.
+
+        The view can simply add the column. LayoutTimelineDataGridNode
+        already includes area data and cell formatting.
+
+        * UserInterface/Views/LayoutTimelineView.js:
+        (WebInspector.LayoutTimelineView):
+
 2016-06-30  Brian Burg  <bburg@apple.com>
 
         Web Inspector: the last normal tab cannot be closed with "Close Tab" context menu item
index dd952bc..cbeed2a 100644 (file)
@@ -31,7 +31,7 @@ WebInspector.LayoutTimelineView = class LayoutTimelineView extends WebInspector.
 
         console.assert(timeline.type === WebInspector.TimelineRecord.Type.Layout, timeline);
 
-        let columns = {type: {}, name: {}, location: {}, width: {}, height: {}, startTime: {}, totalTime: {}};
+        let columns = {type: {}, name: {}, location: {}, area: {}, width: {}, height: {}, startTime: {}, totalTime: {}};
 
         columns.name.title = WebInspector.UIString("Type");
         columns.name.width = "15%";
@@ -55,6 +55,9 @@ WebInspector.LayoutTimelineView = class LayoutTimelineView extends WebInspector.
         columns.location.title = WebInspector.UIString("Initiator");
         columns.location.width = "25%";
 
+        columns.area.title = WebInspector.UIString("Area");
+        columns.area.width = "8%";
+
         columns.width.title = WebInspector.UIString("Width");
         columns.width.width = "8%";