Web Inspector: Table should not center rows when scrolling them into view
authormattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 15 Aug 2018 06:10:34 +0000 (06:10 +0000)
committermattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 15 Aug 2018 06:10:34 +0000 (06:10 +0000)
https://bugs.webkit.org/show_bug.cgi?id=188593
<rdar://problem/43311660>

Reviewed by Devin Rousso.

* UserInterface/Views/Table.js:
(WI.Table.prototype._handleKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/Table.js

index b1e1d78..bf68df2 100644 (file)
@@ -1,3 +1,14 @@
+2018-08-14  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: Table should not center rows when scrolling them into view
+        https://bugs.webkit.org/show_bug.cgi?id=188593
+        <rdar://problem/43311660>
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/Table.js:
+        (WI.Table.prototype._handleKeyDown):
+
 2018-08-13  Matt Baker  <mattbaker@apple.com>
 
         Web Inspector: Table should handle row selection instead of the table delegate
index b335a9c..839c06c 100644 (file)
@@ -1173,7 +1173,7 @@ WI.Table = class Table extends WI.View
 
             let row = this._cachedRows.get(this._selectedRowIndex);
             console.assert(row, "Moving up or down by one should always find a cached row since it is within the overflow bounds.");
-            row.scrollIntoViewIfNeeded();
+            row.scrollIntoViewIfNeeded(false);
 
             // Force our own scroll update because we may have scrolled.
             this._cachedScrollTop = NaN;