[GTK][WPE] Stop pushing the StreamCollection as event in GStreamerMediaStreamSource
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Jul 2018 20:08:19 +0000 (20:08 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Jul 2018 20:08:19 +0000 (20:08 +0000)
https://bugs.webkit.org/show_bug.cgi?id=187304

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-04
Reviewed by Philippe Normand.

We let parsebin build the StreamCollection for us and pass extra metadata through the
`TAG_EVENT` pushing the collection ourself is not bringing anything but adds extra work in the
MediaPlayerGStreamer duplicating the STREAM_COLLECTION message for no good reason.

MediaStream layout tests already test that code path.

* platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(WebCore::webkitMediaStreamSrcPadProbeCb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp

index 7df7fe7..be1621c 100644 (file)
@@ -1,3 +1,19 @@
+2018-07-04  Thibault Saunier  <tsaunier@igalia.com>
+
+        [GTK][WPE] Stop pushing the StreamCollection as event in GStreamerMediaStreamSource
+        https://bugs.webkit.org/show_bug.cgi?id=187304
+
+        Reviewed by Philippe Normand.
+
+        We let parsebin build the StreamCollection for us and pass extra metadata through the
+        `TAG_EVENT` pushing the collection ourself is not bringing anything but adds extra work in the
+        MediaPlayerGStreamer duplicating the STREAM_COLLECTION message for no good reason.
+
+        MediaStream layout tests already test that code path.
+
+        * platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
+        (WebCore::webkitMediaStreamSrcPadProbeCb):
+
 2018-07-04  Frederic Wang  <fwang@igalia.com>
 
         [WebIDL] Remove custom bindings for HTMLDocument
index 711d32f..8d4c78a 100644 (file)
@@ -383,7 +383,6 @@ static GstPadProbeReturn webkitMediaStreamSrcPadProbeCb(GstPad* pad, GstPadProbe
         gst_event_unref(event);
 
         gst_pad_push_event(pad, stream_start);
-        gst_pad_push_event(pad, gst_event_new_stream_collection(self->streamCollection.get()));
         gst_pad_push_event(pad, gst_event_new_tag(mediaStreamTrackPrivateGetTags(data->track.get())));
 
         webkitMediaStreamSrcAddPad(self, pad, data->pad_template);