Fix layout tests that incorrectly attempt to detect whether they're running inside...
authormrowe@apple.com <mrowe@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Jul 2009 05:10:28 +0000 (05:10 +0000)
committermrowe@apple.com <mrowe@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Jul 2009 05:10:28 +0000 (05:10 +0000)
Rubber-stamped by Brady Eidson.

* editing/execCommand/25256.html:
* editing/execCommand/25320.html:
* fast/canvas/arc-crash.html:
* fast/css/emptyStyleTag.html:
* fast/events/js-keyboard-event-creation.html:
* fast/events/scrollbar-double-click.html:
* fast/forms/select-no-name.html:
* fast/history/window-open.html:
* platform/mac/fast/events/objc-event-api.html:
* platform/mac/fast/events/objc-keyboard-event-creation.html:
* scrollbars/scrollbar-miss-mousemove-disabled.html:
* scrollbars/scrollbar-miss-mousemove.html:
* storage/domstorage/localstorage/clear.html:
* storage/domstorage/localstorage/delete-removal.html:
* storage/domstorage/localstorage/enumerate-storage.html:
* storage/domstorage/localstorage/index-get-and-set.html:
* storage/domstorage/localstorage/onstorage-attribute-markup.html:
* storage/domstorage/localstorage/onstorage-attribute-setattribute.html:
* storage/domstorage/localstorage/private-browsing-affects-storage.html:
* storage/domstorage/localstorage/resources/window-open-second.html:
* storage/domstorage/localstorage/simple-events.html:
* storage/domstorage/localstorage/simple-usage.html:
* storage/domstorage/localstorage/string-conversion.html:
* storage/domstorage/localstorage/window-open.html:
* storage/domstorage/sessionstorage/clear.html:
* storage/domstorage/sessionstorage/delete-removal.html:
* storage/domstorage/sessionstorage/enumerate-storage.html:
* storage/domstorage/sessionstorage/index-get-and-set.html:
* storage/domstorage/sessionstorage/onstorage-attribute-markup.html:
* storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html:
* storage/domstorage/sessionstorage/private-browsing-affects-storage.html:
* storage/domstorage/sessionstorage/resources/window-open-second.html:
* storage/domstorage/sessionstorage/simple-events.html:
* storage/domstorage/sessionstorage/simple-usage.html:
* storage/domstorage/sessionstorage/string-conversion.html:
* storage/domstorage/sessionstorage/window-open.html:
* storage/domstorage/window-attributes-exist.html:
* svg/custom/stop-crash.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

39 files changed:
LayoutTests/ChangeLog
LayoutTests/editing/execCommand/25256.html
LayoutTests/editing/execCommand/25320.html
LayoutTests/fast/canvas/arc-crash.html
LayoutTests/fast/css/emptyStyleTag.html
LayoutTests/fast/events/js-keyboard-event-creation.html
LayoutTests/fast/events/scrollbar-double-click.html
LayoutTests/fast/forms/select-no-name.html
LayoutTests/fast/history/window-open.html
LayoutTests/platform/mac/fast/events/objc-event-api.html
LayoutTests/platform/mac/fast/events/objc-keyboard-event-creation.html
LayoutTests/scrollbars/scrollbar-miss-mousemove-disabled.html
LayoutTests/scrollbars/scrollbar-miss-mousemove.html
LayoutTests/storage/domstorage/localstorage/clear.html
LayoutTests/storage/domstorage/localstorage/delete-removal.html
LayoutTests/storage/domstorage/localstorage/enumerate-storage.html
LayoutTests/storage/domstorage/localstorage/index-get-and-set.html
LayoutTests/storage/domstorage/localstorage/onstorage-attribute-markup.html
LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute.html
LayoutTests/storage/domstorage/localstorage/private-browsing-affects-storage.html
LayoutTests/storage/domstorage/localstorage/resources/window-open-second.html
LayoutTests/storage/domstorage/localstorage/simple-events.html
LayoutTests/storage/domstorage/localstorage/simple-usage.html
LayoutTests/storage/domstorage/localstorage/string-conversion.html
LayoutTests/storage/domstorage/localstorage/window-open.html
LayoutTests/storage/domstorage/sessionstorage/clear.html
LayoutTests/storage/domstorage/sessionstorage/delete-removal.html
LayoutTests/storage/domstorage/sessionstorage/enumerate-storage.html
LayoutTests/storage/domstorage/sessionstorage/index-get-and-set.html
LayoutTests/storage/domstorage/sessionstorage/onstorage-attribute-markup.html
LayoutTests/storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html
LayoutTests/storage/domstorage/sessionstorage/private-browsing-affects-storage.html
LayoutTests/storage/domstorage/sessionstorage/resources/window-open-second.html
LayoutTests/storage/domstorage/sessionstorage/simple-events.html
LayoutTests/storage/domstorage/sessionstorage/simple-usage.html
LayoutTests/storage/domstorage/sessionstorage/string-conversion.html
LayoutTests/storage/domstorage/sessionstorage/window-open.html
LayoutTests/storage/domstorage/window-attributes-exist.html
LayoutTests/svg/custom/stop-crash.svg

index 5486534..b4d5043 100644 (file)
@@ -1,5 +1,51 @@
 2009-07-23  Mark Rowe  <mrowe@apple.com>
 
+        Rubber-stamped by Brady Eidson.
+
+        Fix layout tests that incorrectly attempt to detect whether they're running inside DumpRenderTree
+        using "if (layoutTestController)".
+
+        * editing/execCommand/25256.html:
+        * editing/execCommand/25320.html:
+        * fast/canvas/arc-crash.html:
+        * fast/css/emptyStyleTag.html:
+        * fast/events/js-keyboard-event-creation.html:
+        * fast/events/scrollbar-double-click.html:
+        * fast/forms/select-no-name.html:
+        * fast/history/window-open.html:
+        * platform/mac/fast/events/objc-event-api.html:
+        * platform/mac/fast/events/objc-keyboard-event-creation.html:
+        * scrollbars/scrollbar-miss-mousemove-disabled.html:
+        * scrollbars/scrollbar-miss-mousemove.html:
+        * storage/domstorage/localstorage/clear.html:
+        * storage/domstorage/localstorage/delete-removal.html:
+        * storage/domstorage/localstorage/enumerate-storage.html:
+        * storage/domstorage/localstorage/index-get-and-set.html:
+        * storage/domstorage/localstorage/onstorage-attribute-markup.html:
+        * storage/domstorage/localstorage/onstorage-attribute-setattribute.html:
+        * storage/domstorage/localstorage/private-browsing-affects-storage.html:
+        * storage/domstorage/localstorage/resources/window-open-second.html:
+        * storage/domstorage/localstorage/simple-events.html:
+        * storage/domstorage/localstorage/simple-usage.html:
+        * storage/domstorage/localstorage/string-conversion.html:
+        * storage/domstorage/localstorage/window-open.html:
+        * storage/domstorage/sessionstorage/clear.html:
+        * storage/domstorage/sessionstorage/delete-removal.html:
+        * storage/domstorage/sessionstorage/enumerate-storage.html:
+        * storage/domstorage/sessionstorage/index-get-and-set.html:
+        * storage/domstorage/sessionstorage/onstorage-attribute-markup.html:
+        * storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html:
+        * storage/domstorage/sessionstorage/private-browsing-affects-storage.html:
+        * storage/domstorage/sessionstorage/resources/window-open-second.html:
+        * storage/domstorage/sessionstorage/simple-events.html:
+        * storage/domstorage/sessionstorage/simple-usage.html:
+        * storage/domstorage/sessionstorage/string-conversion.html:
+        * storage/domstorage/sessionstorage/window-open.html:
+        * storage/domstorage/window-attributes-exist.html:
+        * svg/custom/stop-crash.svg:
+
+2009-07-23  Mark Rowe  <mrowe@apple.com>
+
         And now with some valid JavaScript syntax!
 
         * http/tests/misc/redirect-to-about-blank.html:
index 9f3a029..44dafaa 100644 (file)
@@ -5,7 +5,7 @@
 edit = document.getElementById("edit");
 edit.focus();
 document.execCommand("JustifyRight");
-if (layoutTestController) {
+if (window.layoutTestController) {
     layoutTestController.dumpAsText();
     document.body.innerText = document.getElementById("description").innerText + "\n\n" + edit.innerHTML;
 }
index 6845d20..7631b72 100644 (file)
@@ -2,7 +2,7 @@
 <head>
 <script>
 function runTest() {
-    if (layoutTestController)
+    if (window.layoutTestController)
         layoutTestController.dumpAsText();
     document.body.focus();
     document.execCommand("JustifyCenter");
index 6ca6a6c..f17a3e6 100644 (file)
@@ -29,7 +29,7 @@ function runTests() {
     context.fillStyle = '#0f0';
     context.fillRect(0, 0, canvas.width, canvas.height);
     debug("Test passed.");
-    if (layoutTestController)
+    if (window.layoutTestController)
         layoutTestController.dumpAsText();
 }
 </script>
index 47d3cfc..8100fdb 100644 (file)
@@ -5,7 +5,7 @@ This tests that we support empty style sheets.
 <div id="result">Test failed.</div>
 
 <script>
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 if (document.styleSheets[0]) {
index 7a747f9..2e7f592 100644 (file)
@@ -18,7 +18,7 @@ function init() {
         layoutTestController.dumpAsText();
     
     input.focus();
-    if (eventSender) {
+    if (window.eventSender) {
         eventSender.keyDown("\t");
         eventSender.keyDown("\t", new Array("shiftKey"));
     }
index 90cff6f..fb21c56 100644 (file)
@@ -1,6 +1,6 @@
 <body style="margin:0">
 <script>
-if (layoutTestController) {
+if (window.layoutTestController) {
     layoutTestController.dumpAsText();
     layoutTestController.waitUntilDone();
 }
@@ -14,7 +14,7 @@ if (layoutTestController) {
 <div id="console"></div>
 
 <script>
-if (eventSender) {
+if (window.eventSender) {
     eventSender.mouseMoveTo(390, 300);
     eventSender.mouseDown();
     eventSender.mouseUp();
index 0e1ea01..6b679fc 100644 (file)
@@ -27,7 +27,7 @@ SELECT with no name generates invalid query string.</p>
 <h2 id="pass">PASS</h2>
 <h2 id="fail">FAIL</h2>
 <script type="text/javascript">
-if (layoutTestController) {
+if (window.layoutTestController) {
     layoutTestController.waitUntilDone();
     layoutTestController.dumpAsText();
 }
index 266e22e..4916b6a 100644 (file)
@@ -29,7 +29,7 @@
     function childLoaded()
     {
         childWindow.close();
-        if (layoutTestController) {
+        if (window.layoutTestController) {
             document.getElementById("result").innerText = layoutTestController.webHistoryItemCount === 1 ? "PASS" : "FAIL";
             layoutTestController.notifyDone();
         }
index 15b3d5f..af7f699 100644 (file)
@@ -2,7 +2,7 @@
 <head>
 <script>
 function init() {
-   if (eventSender) {
+   if (window.eventSender) {
       layoutTestController.dumpAsText();
       
       eventSender.mouseMoveTo(1,1);
index 9afccf1..a0009ba 100644 (file)
@@ -14,10 +14,10 @@ function init() {
     input.addEventListener("keypress", keyevent, true);
     input.addEventListener("keyup", keyevent, true);
    
-    if (layoutTestController)
+    if (window.layoutTestController)
         layoutTestController.dumpAsText();
     
-    if (eventSender)
+    if (window.eventSender)
         eventSender.fireKeyboardEventsToElement(input);
 }
 </script>
index 2e5a61a..05379ea 100644 (file)
@@ -1,7 +1,7 @@
 <html>
 <body style="margin:0">
 <script>
-if (layoutTestController) {
+if (window.layoutTestController) {
     layoutTestController.dumpAsText();
     layoutTestController.waitUntilDone();
 }
@@ -116,7 +116,7 @@ properly even is there was no mouse move onto the scrollbar; this is the
 disabled control case. On success, the text should begin with "zx".<p/>
 <div id="console"></div>
 <script>
-if (eventSender) {
+if (window.eventSender) {
     document.form1.text1.disabled = true;
     document.form1.style.display = "none";
     eventSender.mouseMoveTo(390, 10);
index b13eea8..9e64b2a 100644 (file)
@@ -1,7 +1,7 @@
 <html>
 <body style="margin:0">
 <script>
-if (layoutTestController) {
+if (window.layoutTestController) {
     layoutTestController.dumpAsText();
     layoutTestController.waitUntilDone();
 }
@@ -16,7 +16,7 @@ properly even is there was no mouse move onto the scrollbar; this is the
 enabled control case. On success, the offset should be 0.<p/>
 <div id="console"></div>
 <script>
-if (eventSender) {
+if (window.eventSender) {
     document.getElementById('overflow').style.display = "none";
     eventSender.mouseMoveTo(390, 10);
     document.getElementById('overflow').style.display = "";
index 55907f8..113432b 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearLocalStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index 26780dd..8745e0d 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearLocalStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index c8f81b0..2d5a2b7 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearLocalStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
@@ -13,7 +13,7 @@ function log(a)
 
 function finish()
 {
-    if (layoutTestController)
+    if (window.layoutTestController)
         layoutTestController.notifyDone()
 }
 
index 62e2951..b50b731 100644 (file)
@@ -15,7 +15,7 @@ function log(a)
 
 function finish()
 {
-    if (layoutTestController)
+    if (window.layoutTestController)
         layoutTestController.notifyDone()
 }
 
index d53e569..91efc42 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearLocalStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index b8d8066..c55b9d7 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearLocalStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index 2e4511e..9e46bec 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearLocalStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index f655737..f944d71 100644 (file)
@@ -24,7 +24,7 @@ function runTest()
     
     window.opener.log(secondWindowLog);
     
-    if (layoutTestController)
+    if (window.layoutTestController)
         layoutTestController.notifyDone();
 }
 
index c78b988..ec039e2 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearLocalStorage.js"></script>
 <script>
 
-if (layoutTestController) {
+if (window.layoutTestController) {
     layoutTestController.dumpAsText();
     layoutTestController.waitUntilDone();
 }
@@ -15,7 +15,7 @@ function log(a)
 
 function finish()
 {
-    if (layoutTestController)
+    if (window.layoutTestController)
         layoutTestController.notifyDone()
 }
 
index 158603c..610a665 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearLocalStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index 7f0e3f5..aa8bdfd 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearLocalStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index fa9e5c6..b390881 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearLocalStorage.js"></script>
 <script>
 
-if (layoutTestController) {
+if (window.layoutTestController) {
     layoutTestController.dumpAsText();
     layoutTestController.setCanOpenWindows();
     layoutTestController.waitUntilDone();
index 13f228a..61b1c33 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearSessionStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index 5f71fe2..5172c97 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearSessionStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index a81ef89..15b5ffd 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearSessionStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
@@ -13,7 +13,7 @@ function log(a)
 
 function finish()
 {
-    if (layoutTestController)
+    if (window.layoutTestController)
         layoutTestController.notifyDone()
 }
 
index 674e39f..16945cd 100644 (file)
@@ -15,7 +15,7 @@ function log(a)
 
 function finish()
 {
-    if (layoutTestController)
+    if (window.layoutTestController)
         layoutTestController.notifyDone()
 }
 
index 4936c22..8969047 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearSessionStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index 69077e4..a7ecd46 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearSessionStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index 362b115..8dd7a6a 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearSessionStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index 1f6d98a..b8dede6 100644 (file)
@@ -24,7 +24,7 @@ function runTest()
     
     window.opener.log(secondWindowLog);
     
-    if (layoutTestController)
+    if (window.layoutTestController)
         layoutTestController.notifyDone();
 }
 
index 356e6ae..216ebb5 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearSessionStorage.js"></script>
 <script>
 
-if (layoutTestController) {
+if (window.layoutTestController) {
     layoutTestController.dumpAsText();
     layoutTestController.waitUntilDone();
 }
@@ -15,7 +15,7 @@ function log(a)
 
 function finish()
 {
-    if (layoutTestController)
+    if (window.layoutTestController)
         layoutTestController.notifyDone()
 }
 
index 9633b3a..b6dc5dd 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearSessionStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index 0a29fe4..64a4e14 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearSessionStorage.js"></script>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index 0ce645b..34f8f39 100644 (file)
@@ -3,7 +3,7 @@
 <script src="resources/clearSessionStorage.js"></script>
 <script>
 
-if (layoutTestController) {
+if (window.layoutTestController) {
     layoutTestController.dumpAsText();
     layoutTestController.setCanOpenWindows();
     layoutTestController.waitUntilDone();
index 2d6b493..935bf13 100644 (file)
@@ -2,7 +2,7 @@
 <head>
 <script>
 
-if (layoutTestController)
+if (window.layoutTestController)
     layoutTestController.dumpAsText();
 
 function log(a)
index 1b58c57..b758686 100644 (file)
@@ -1,8 +1,8 @@
 <svg xmlns="http://www.w3.org/2000/svg">
   <stop/>
   <script>
-  if (layoutTestController)
+  if (window.layoutTestController)
      layoutTestController.dumpAsText();
   </script>
   <text x="10" y="25">PASS -- if this test doesn't crash it passes.</text>
-</svg>
\ No newline at end of file
+</svg>