https://bugs.webkit.org/show_bug.cgi?id=132085
Reviewed by Tim Horton.
Source/WebCore:
This was essentially unused, and also didnt work.
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setMockScrollbarsEnabled): Deleted.
* testing/InternalSettings.h:
* testing/InternalSettings.idl:
Tools:
* DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
No need to reset the preference, there is no way it can change.
LayoutTests:
Remove calls, all of which were resetting it to true (which is the default, and
the only value that makes sense).
* compositing/geometry/fixed-position.html:
* compositing/geometry/horizontal-scroll-composited.html:
* compositing/geometry/vertical-scroll-composited.html:
* compositing/iframes/resources/scrollgrandchild-inner.html:
* compositing/overflow/fixed-position-ancestor-clip.html:
* compositing/resources/mock_scrollbars.js: Removed.
* css3/filters/blur-filter-page-scroll-parents.html:
* css3/filters/blur-filter-page-scroll-self.html:
* css3/filters/blur-filter-page-scroll.html:
* fast/dom/window-scroll-scaling.html:
* fast/events/touch/gesture/gesture-scrollbar.html:
* fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html:
* fast/sub-pixel/transformed-iframe-copy-on-scroll.html:
* media/video-controls-rendering.html:
* media/video-zoom.html:
* scrollingcoordinator/resources/non-fast-scrollable-region-testing.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2014-04-23 Alexey Proskuryakov <ap@apple.com>
+
+ Eliminate internals.setMockScrollbarsEnabled()
+ https://bugs.webkit.org/show_bug.cgi?id=132085
+
+ Reviewed by Tim Horton.
+
+ Remove calls, all of which were resetting it to true (which is the default, and
+ the only value that makes sense).
+
+ * compositing/geometry/fixed-position.html:
+ * compositing/geometry/horizontal-scroll-composited.html:
+ * compositing/geometry/vertical-scroll-composited.html:
+ * compositing/iframes/resources/scrollgrandchild-inner.html:
+ * compositing/overflow/fixed-position-ancestor-clip.html:
+ * compositing/resources/mock_scrollbars.js: Removed.
+ * css3/filters/blur-filter-page-scroll-parents.html:
+ * css3/filters/blur-filter-page-scroll-self.html:
+ * css3/filters/blur-filter-page-scroll.html:
+ * fast/dom/window-scroll-scaling.html:
+ * fast/events/touch/gesture/gesture-scrollbar.html:
+ * fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html:
+ * fast/sub-pixel/transformed-iframe-copy-on-scroll.html:
+ * media/video-controls-rendering.html:
+ * media/video-zoom.html:
+ * scrollingcoordinator/resources/non-fast-scrollable-region-testing.js:
+
2014-04-23 David Hyatt <hyatt@apple.com>
[New Multicolumn] Crasher when clearing out a flow thread in multicolumn layout.
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<title>Position fixed</title>
- <script src="../resources/mock_scrollbars.js"></script>
<style type="text/css" media="screen">
body {
height: 1000px;
if (window.testRunner)
testRunner.waitUntilDone();
</script>
- <script src="../resources/mock_scrollbars.js"></script>
</head>
<body style="width: 600px">
<div style="-webkit-transform: translatez(0); width: 1000px; height: 800px; border-style: solid; border-color: Red; border-width: 3px; background-image: url(../resources/apple.jpg); background-repeat:repeat"></div>
if (window.testRunner)
testRunner.waitUntilDone();
</script>
- <script src="../resources/mock_scrollbars.js"></script>
</head>
<body style="height: 600px">
<div style="-webkit-transform: rotate3d(0,0,1,20deg); width: 800px; height: 1000px; border-style: solid; border-color: Red; border-width: 3px; background-image: url(../resources/apple.jpg); background-repeat:repeat"></div>
}
</style>
<script>
- if (window.internals)
- window.internals.settings.setMockScrollbarsEnabled(true);
if (window.testRunner) {
testRunner.dumpAsText(true);
testRunner.waitUntilDone();
window.scrollBy(50, 50);
}, false);
</script>
- <script src="../resources/mock_scrollbars.js"></script>
</head>
<body>
+++ /dev/null
-if (window.internals) {
- window.internals.settings.setMockScrollbarsEnabled(true);
-}
window.testRunner.overridePreference("WebKitAcceleratedCompositingEnabled", "0");
}
</script>
- <!-- Make sure the mock scrollbars are enabled after the call to overridePreference, otherwise the setting will be overwritten. -->
- <script src="../../compositing/resources/mock_scrollbars.js"></script>
<style>
body {
margin: 0px;
window.testRunner.overridePreference("WebKitAcceleratedCompositingEnabled", "0");
}
</script>
- <!-- Make sure the mock scrollbars are enabled after the call to overridePreference, otherwise the setting will be overwritten. -->
- <script src="../../compositing/resources/mock_scrollbars.js"></script>
<style>
body {
margin: 0px;
window.testRunner.overridePreference("WebKitAcceleratedCompositingEnabled", "0");
}
</script>
- <!-- Make sure the mock scrollbars are enabled after the call to overridePreference, otherwise the setting will be overwritten. -->
- <script src="../../compositing/resources/mock_scrollbars.js"></script>
<style>
body {
margin: 0px;
<script>
description("This test ensures that document content width (height) as reported by scrollWidth (scrollHeight) is invariant to changes in page scale factor.");
- if (window.internals)
- window.internals.settings.setMockScrollbarsEnabled(true);
-
var body = document.body;
// According to CSSOM (http://dev.w3.org/csswg/cssom-view/#dom-element-scrollwidth)
function runTest()
{
- internals.settings.setMockScrollbarsEnabled(true);
if (window.eventSender) {
description('This tests scroll gesture events on a scroll bar. ' +
'The scrollable div below should be slightly scrolled down ' +
</style>
<script src="../repaint/resources/repaint.js" type="text/javascript"></script>
<script>
-if (window.testRunner) {
+if (window.testRunner)
testRunner.waitUntilDone();
- internals.settings.setMockScrollbarsEnabled(true);
-}
function setupIframes() {
setupIframe(document.getElementById('iframe1').contentWindow.document);
</style>
<script src="../repaint/resources/repaint.js" type="text/javascript"></script>
<script>
-if (window.testRunner) {
+if (window.testRunner)
testRunner.waitUntilDone();
- internals.settings.setMockScrollbarsEnabled(true);
-}
function setupIframes() {
setupIframe(document.getElementById('iframe1').contentWindow.document);
<video controls style="position: absolute; width: 320px;"></video>
</div>
<script>
-if (window.internals)
- window.internals.settings.setMockScrollbarsEnabled(true);
init();
setSrcByTagName('video', findMediaFile('video', 'content/test'));
</script>
<style> video { zoom: 150%; border: 3px solid red; } </style>
<script src=media-file.js></script>
<script>
- if (window.internals)
- window.internals.settings.setMockScrollbarsEnabled(true);
-
function init()
{
setSrcByTagName("video", findMediaFile("video", "content/test"));
function runNonFastScrollableRegionTest(scale) {
var invScale;
- window.internals.settings.setMockScrollbarsEnabled(true);
if (scale != undefined) {
window.internals.setPageScaleFactor(scale, 0, 0);
// FIXME: This is a hack for applyPageScaleFactorInCompositor() == false.
+2014-04-23 Alexey Proskuryakov <ap@apple.com>
+
+ Eliminate internals.setMockScrollbarsEnabled()
+ https://bugs.webkit.org/show_bug.cgi?id=132085
+
+ Reviewed by Tim Horton.
+
+ This was essentially unused, and also didnt work.
+
+ * testing/InternalSettings.cpp:
+ (WebCore::InternalSettings::Backup::restoreTo):
+ (WebCore::InternalSettings::setMockScrollbarsEnabled): Deleted.
+ * testing/InternalSettings.h:
+ * testing/InternalSettings.idl:
+
2014-04-23 Anders Carlsson <andersca@apple.com>
Don't migrate the WKView.h header from WebCore to WebKit
#endif
settings.setMediaTypeOverride(m_originalMediaTypeOverride);
settings.setCanvasUsesAcceleratedDrawing(m_originalCanvasUsesAcceleratedDrawing);
- settings.setMockScrollbarsEnabled(m_originalMockScrollbarsEnabled);
RuntimeEnabledFeatures::sharedFeatures().setLangAttributeAwareFormControlUIEnabled(m_langAttributeAwareFormControlUIEnabled);
settings.setImagesEnabled(m_imagesEnabled);
settings.setMinDOMTimerInterval(m_minimumTimerInterval);
return &page()->settings();
}
-void InternalSettings::setMockScrollbarsEnabled(bool enabled, ExceptionCode& ec)
-{
- InternalSettingsGuardForSettings();
- settings()->setMockScrollbarsEnabled(enabled);
-}
-
void InternalSettings::setTouchEventEmulationEnabled(bool enabled, ExceptionCode& ec)
{
#if ENABLE(TOUCH_EVENTS)
virtual ~InternalSettings();
void resetToConsistentState();
- void setMockScrollbarsEnabled(bool enabled, ExceptionCode&);
void setUsesOverlayScrollbars(bool enabled, ExceptionCode&);
void setTouchEventEmulationEnabled(bool enabled, ExceptionCode&);
void setStandardFontFamily(const String& family, const String& script, ExceptionCode&);
NoInterfaceObject,
JSGenerateToJSObject
] interface InternalSettings : InternalSettingsGenerated {
- [RaisesException] void setMockScrollbarsEnabled(boolean enabled);
[RaisesException] void setTouchEventEmulationEnabled(boolean enabled);
[RaisesException] void setStandardFontFamily(DOMString family, DOMString script);
[RaisesException] void setSerifFontFamily(DOMString family, DOMString script);
+2014-04-23 Alexey Proskuryakov <ap@apple.com>
+
+ Eliminate internals.setMockScrollbarsEnabled()
+ https://bugs.webkit.org/show_bug.cgi?id=132085
+
+ Reviewed by Tim Horton.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
+ No need to reset the preference, there is no way it can change.
+
2014-04-23 James Craig <jcraig@apple.com>
Unreviewed. Moving myself from Contributors to Committers list.
[preferences setCSSGridLayoutEnabled:NO];
[preferences setUsePreHTML5ParserQuirks:NO];
[preferences setAsynchronousSpellCheckingEnabled:NO];
- [preferences setMockScrollbarsEnabled:YES];
+ ASSERT([preferences mockScrollbarsEnabled]);
#if ENABLE(WEB_AUDIO)
[preferences setWebAudioEnabled:YES];
git://git.webkit.org / WebKit-https.git / commitdiff