[Streams API] pipeThrough test failing
authorcalvaris@igalia.com <calvaris@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Dec 2015 15:34:28 +0000 (15:34 +0000)
committercalvaris@igalia.com <calvaris@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Dec 2015 15:34:28 +0000 (15:34 +0000)
https://bugs.webkit.org/show_bug.cgi?id=152061

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

* web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt: Expectations.

Source/WebCore:

Test: imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through.html

* Modules/streams/ReadableStream.js:
(pipeThrough): Mimic destructuring for the streams parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@193832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/Modules/streams/ReadableStream.js

index 3fa59dd..507daad 100644 (file)
@@ -1,5 +1,14 @@
 2015-12-09  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 
+        [Streams API] pipeThrough test failing
+        https://bugs.webkit.org/show_bug.cgi?id=152061
+
+        Reviewed by Youenn Fablet.
+
+        * web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt: Expectations.
+
+2015-12-09  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
         [Streams API] Import the web-platform-tests directly from the spec
         https://bugs.webkit.org/show_bug.cgi?id=152051
 
index 8fb3320..b0875e7 100644 (file)
@@ -2,7 +2,7 @@
 PASS ReadableStream.prototype.pipeThrough should work generically on its this and its arguments 
 PASS ReadableStream.prototype.pipeThrough should throw when its first argument is not convertible to an object 
 PASS ReadableStream.prototype.pipeThrough should throw when "this" has no pipeTo method 
-FAIL ReadableStream.prototype.pipeThrough should rethrow errors from accessing pipeTo, readable, or writable assert_unreached: pipeTo should not be called Reached unreachable code
+PASS ReadableStream.prototype.pipeThrough should rethrow errors from accessing pipeTo, readable, or writable 
 PASS ReadableStream.prototype.pipeThrough should work with missing readable, writable, or options 
 FAIL Load pipe-through.js with SharedWorker assert_unreached: SharedWorker is unavailable Reached unreachable code
 FAIL Untitled undefined is not an object (evaluating 'navigator.serviceWorker.getRegistration')
index 8e27314..c391f94 100644 (file)
@@ -1,3 +1,15 @@
+2015-12-09  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [Streams API] pipeThrough test failing
+        https://bugs.webkit.org/show_bug.cgi?id=152061
+
+        Reviewed by Youenn Fablet.
+
+        Test: imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through.html
+
+        * Modules/streams/ReadableStream.js:
+        (pipeThrough): Mimic destructuring for the streams parameter.
+
 2015-12-09  Frederic Wang  <fred.wang@free.fr>
 
         Bad position of large operators inside an munderover element
index a4e8b07..e5a01aa 100644 (file)
@@ -94,8 +94,10 @@ function pipeThrough(streams, options)
 {
     "use strict";
 
-    this.pipeTo(streams.writable, options);
-    return streams.readable;
+    const writable = streams.writable;
+    const readable = streams.readable;
+    this.pipeTo(writable, options);
+    return readable;
 }
 
 function pipeTo(destination, options)