nrwt: clean up logging when we're only running one chunk of the tests
authordpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Jul 2012 23:18:44 +0000 (23:18 +0000)
committerdpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Jul 2012 23:18:44 +0000 (23:18 +0000)
https://bugs.webkit.org/show_bug.cgi?id=91447

Reviewed by Ojan Vafai.

Apparently we were creating a 'tests_run.txt' in the results
directory if we were only running one chunk of the tests; after
3+ years of hacking on this code, that was news to me, so I'm
guessing no one uses this. I'm removing this, and changing the
_print_expected calls to debug messages to simplify the
layering.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._split_into_chunks_if_necessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

index b781929..81b12dc 100644 (file)
@@ -1,5 +1,22 @@
 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
 
+        nrwt: clean up logging when we're only running one chunk of the tests
+        https://bugs.webkit.org/show_bug.cgi?id=91447
+
+        Reviewed by Ojan Vafai.
+
+        Apparently we were creating a 'tests_run.txt' in the results
+        directory if we were only running one chunk of the tests; after
+        3+ years of hacking on this code, that was news to me, so I'm
+        guessing no one uses this. I'm removing this, and changing the
+        _print_expected calls to debug messages to simplify the
+        layering.
+
+        * Scripts/webkitpy/layout_tests/controllers/manager.py:
+        (Manager._split_into_chunks_if_necessary):
+
+2012-07-17  Dirk Pranke  <dpranke@chromium.org>
+
         Fix regression in style checker introduced in r122868.
         https://bugs.webkit.org/show_bug.cgi?id=91470
 
index 99a861e..3031acd 100644 (file)
@@ -417,19 +417,14 @@ class Manager(object):
 
         files = test_files[slice_start:slice_end]
 
-        tests_run_msg = 'Running: %d tests (chunk slice [%d:%d] of %d)' % ((slice_end - slice_start), slice_start, slice_end, num_tests)
-        self._printer._print_expected(tests_run_msg)
+        _log.debug('chunk slice [%d:%d] of %d is %d tests' % (slice_start, slice_end, num_tests, (slice_end - slice_start)))
 
         # If we reached the end and we don't have enough tests, we run some
         # from the beginning.
         if slice_end - slice_start < chunk_len:
             extra = chunk_len - (slice_end - slice_start)
-            extra_msg = ('   last chunk is partial, appending [0:%d]' % extra)
-            self._printer._print_expected(extra_msg)
-            tests_run_msg += "\n" + extra_msg
+            _log.debug('   last chunk is partial, appending [0:%d]' % extra)
             files.extend(test_files[0:extra])
-        tests_run_filename = self._filesystem.join(self._results_directory, "tests_run.txt")
-        self._filesystem.write_text_file(tests_run_filename, tests_run_msg)
 
         len_skip_chunk = int(len(files) * len(skipped) / float(len(self._test_files)))
         skip_chunk_list = list(skipped)[0:len_skip_chunk]