Remove dead code.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Apr 2015 16:46:27 +0000 (16:46 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Apr 2015 16:46:27 +0000 (16:46 +0000)
https://bugs.webkit.org/show_bug.cgi?id=143352

Patch by Alex Christensen <achristensen@webkit.org> on 2015-04-03
Reviewed by Gyuyoung Kim.

* html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
* loader/EmptyClients.cpp:
(WebCore::EmptyChromeClient::openDateTimeChooser): Deleted.
* loader/EmptyClients.h:
* page/Chrome.cpp:
(WebCore::Chrome::openDateTimeChooser): Deleted.
* page/Chrome.h:
* page/ChromeClient.h:
Remove ChromeClient::openDateTimeChooser.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@182320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp
Source/WebCore/loader/EmptyClients.cpp
Source/WebCore/loader/EmptyClients.h
Source/WebCore/page/Chrome.cpp
Source/WebCore/page/Chrome.h
Source/WebCore/page/ChromeClient.h

index 127268b..bc4d506 100644 (file)
@@ -1,3 +1,21 @@
+2015-04-03  Alex Christensen  <achristensen@webkit.org>
+
+        Remove dead code.
+        https://bugs.webkit.org/show_bug.cgi?id=143352
+
+        Reviewed by Gyuyoung Kim.
+
+        * html/BaseChooserOnlyDateAndTimeInputType.cpp:
+        (WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
+        * loader/EmptyClients.cpp:
+        (WebCore::EmptyChromeClient::openDateTimeChooser): Deleted.
+        * loader/EmptyClients.h:
+        * page/Chrome.cpp:
+        (WebCore::Chrome::openDateTimeChooser): Deleted.
+        * page/Chrome.h:
+        * page/ChromeClient.h:
+        Remove ChromeClient::openDateTimeChooser.
+
 2015-04-03  Zan Dobersek  <zdobersek@igalia.com>
 
         Unreviewed, fixing Clang builds of the GTK port on Linux.
index 6b2a8e3..e9a6cc0 100644 (file)
@@ -54,10 +54,6 @@ void BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent(Event*)
     DateTimeChooserParameters parameters;
     if (!element().setupDateTimeChooserParameters(parameters))
         return;
-#if !PLATFORM(IOS)
-    // FIXME: Is this correct? Why don't we do this on iOS?
-    m_dateTimeChooser = element().document().page()->chrome().openDateTimeChooser(this, parameters);
-#endif
 }
 
 void BaseChooserOnlyDateAndTimeInputType::createShadowSubtree()
index 89d5486..c76408b 100644 (file)
@@ -30,7 +30,6 @@
 
 #include "ColorChooser.h"
 #include "DatabaseProvider.h"
-#include "DateTimeChooser.h"
 #include "DocumentLoader.h"
 #include "FileChooser.h"
 #include "FormState.h"
@@ -163,13 +162,6 @@ std::unique_ptr<ColorChooser> EmptyChromeClient::createColorChooser(ColorChooser
 }
 #endif
 
-#if ENABLE(DATE_AND_TIME_INPUT_TYPES) && !PLATFORM(IOS)
-PassRefPtr<DateTimeChooser> EmptyChromeClient::openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&)
-{
-    return nullptr;
-}
-#endif
-
 void EmptyChromeClient::runOpenPanel(Frame*, PassRefPtr<FileChooser>)
 {
 }
index 2694267..9ca43d0 100644 (file)
@@ -164,10 +164,6 @@ public:
     virtual std::unique_ptr<ColorChooser> createColorChooser(ColorChooserClient*, const Color&) override;
 #endif
 
-#if ENABLE(DATE_AND_TIME_INPUT_TYPES) && !PLATFORM(IOS)
-    virtual PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&) override;
-#endif
-
     virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>) override;
     virtual void loadIconForFiles(const Vector<String>&, FileIconLoader*) override { }
 
index ea1236f..13e6d05 100644 (file)
@@ -24,7 +24,6 @@
 
 #include "ChromeClient.h"
 #include "DNS.h"
-#include "DateTimeChooser.h"
 #include "Document.h"
 #include "DocumentType.h"
 #include "FileIconLoader.h"
@@ -480,14 +479,6 @@ std::unique_ptr<ColorChooser> Chrome::createColorChooser(ColorChooserClient* cli
 }
 #endif
 
-#if ENABLE(DATE_AND_TIME_INPUT_TYPES) && !PLATFORM(IOS)
-PassRefPtr<DateTimeChooser> Chrome::openDateTimeChooser(DateTimeChooserClient* client, const DateTimeChooserParameters& parameters)
-{
-    notifyPopupOpeningObservers();
-    return m_client.openDateTimeChooser(client, parameters);
-}
-#endif
-
 void Chrome::runOpenPanel(Frame* frame, PassRefPtr<FileChooser> fileChooser)
 {
     notifyPopupOpeningObservers();
index 2413a4f..98ab745 100644 (file)
@@ -163,10 +163,6 @@ public:
     std::unique_ptr<ColorChooser> createColorChooser(ColorChooserClient*, const Color& initialColor);
 #endif
 
-#if ENABLE(DATE_AND_TIME_INPUT_TYPES) && !PLATFORM(IOS)
-    PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&);
-#endif
-
     void runOpenPanel(Frame*, PassRefPtr<FileChooser>);
     void loadIconForFiles(const Vector<String>&, FileIconLoader*);
 
index bdc913c..0516dea 100644 (file)
@@ -272,10 +272,6 @@ public:
     virtual std::unique_ptr<ColorChooser> createColorChooser(ColorChooserClient*, const Color&) = 0;
 #endif
 
-#if ENABLE(DATE_AND_TIME_INPUT_TYPES) && !PLATFORM(IOS)
-    virtual PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&) = 0;
-#endif
-
     virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>) = 0;
     // Asynchronous request to load an icon for specified filenames.
     virtual void loadIconForFiles(const Vector<String>&, FileIconLoader*) = 0;