Regression(r181257): WTF_WorkQueue.Simple is flaky
authorbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 23 Mar 2015 22:56:58 +0000 (22:56 +0000)
committerbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 23 Mar 2015 22:56:58 +0000 (22:56 +0000)
https://bugs.webkit.org/show_bug.cgi?id=142560

Remove the check that the refCount has returned to one after the
individual tasks have completed. It's too nondeterministic when
the reference count will be reduced.

Reviewed by Alexey Proskuryakov

* TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
(TestWebKitAPI::TEST): Remove test that refCount is back to 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp

index f87427b..4895b5e 100644 (file)
@@ -1,3 +1,17 @@
+2015-03-23  Brent Fulgham  <bfulgham@apple.com>
+
+        Regression(r181257): WTF_WorkQueue.Simple is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=142560
+
+        Remove the check that the refCount has returned to one after the
+        individual tasks have completed. It's too nondeterministic when
+        the reference count will be reduced.
+
+        Reviewed by Alexey Proskuryakov
+
+        * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
+        (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
+
 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 
         [CMake][EFL] Put failure API test excutables into failure directory
index 6df58c2..4b03587 100644 (file)
@@ -87,7 +87,6 @@ TEST(WTF_WorkQueue, Simple)
     EXPECT_TRUE(calledSimpleTest);
     EXPECT_TRUE(calledLongTest);
     EXPECT_TRUE(calledThirdTest);
-    EXPECT_EQ(1, queue->refCount());
 
     EXPECT_EQ(static_cast<size_t>(3), m_functionCallOrder.size());
     EXPECT_STREQ(simpleTestLabel, m_functionCallOrder[0].c_str());
@@ -108,10 +107,8 @@ TEST(WTF_WorkQueue, TwoQueues)
     auto queue1 = WorkQueue::create("com.apple.WebKit.Test.twoQueues1");
     auto queue2 = WorkQueue::create("com.apple.WebKit.Test.twoQueues2");
 
-    int initialQueue1RefCount = queue1->refCount();
-    int initialQueue2RefCount = queue2->refCount();
-    EXPECT_EQ(1, initialQueue1RefCount);
-    EXPECT_EQ(1, initialQueue2RefCount);
+    EXPECT_EQ(1, queue1->refCount());
+    EXPECT_EQ(1, queue2->refCount());
 
     MutexLocker locker(m_lock);
     
@@ -146,14 +143,12 @@ TEST(WTF_WorkQueue, TwoQueues)
     EXPECT_TRUE(calledSimpleTest);
     EXPECT_FALSE(calledLongTest);
     EXPECT_TRUE(calledThirdTest);
-    EXPECT_EQ(1, queue1->refCount());
 
     m_testQueue2Completed.wait(m_lock);
 
     EXPECT_TRUE(calledSimpleTest);
     EXPECT_TRUE(calledLongTest);
     EXPECT_TRUE(calledThirdTest);
-    EXPECT_EQ(1, queue2->refCount());
 
     EXPECT_EQ(static_cast<size_t>(3), m_functionCallOrder.size());
     EXPECT_STREQ(simpleTestLabel, m_functionCallOrder[0].c_str());