git://git.webkit.org / WebKit-https.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (from parent 1: 35ea826)
AX: when invert colors is on, double-invert image and picture elements in UserAgentSt...
authorjcraig@apple.com <jcraig@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 19 Jan 2018 19:12:35 +0000 (19:12 +0000)
committerjcraig@apple.com <jcraig@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 19 Jan 2018 19:12:35 +0000 (19:12 +0000)
https://bugs.webkit.org/show_bug.cgi?id=181281
<rdar://problem/36291776>

Reviewed by Simon Fraser.

Source/WebCore:

Updated "Smart Invert" to include img and picture element inversion and tests.

Tests: accessibility/smart-invert-reference.html
       accessibility/smart-invert.html

* css/html.css:
(@media (inverted-colors)):
(img:not(picture>img), picture, video):

LayoutTests:

Updated to include img and picture element tests.

* accessibility/smart-invert-expected.txt:
* accessibility/smart-invert-reference-expected.html:
* accessibility/smart-invert.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@227219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog patch | blob | history
LayoutTests/accessibility/smart-invert-expected.txt patch | blob | history
LayoutTests/accessibility/smart-invert-reference-expected.html patch | blob | history
LayoutTests/accessibility/smart-invert.html patch | blob | history
Source/WebCore/ChangeLog patch | blob | history
Source/WebCore/css/html.css patch | blob | history

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 8f20cc6..ef0fedb 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,17 @@
+2018-01-19  James Craig  <jcraig@apple.com>
+
+        AX: when invert colors is on, double-invert image and picture elements in UserAgentStyleSheet
+        https://bugs.webkit.org/show_bug.cgi?id=181281
+        <rdar://problem/36291776>
+
+        Reviewed by Simon Fraser.
+
+        Updated to include img and picture element tests.
+
+        * accessibility/smart-invert-expected.txt:
+        * accessibility/smart-invert-reference-expected.html:
+        * accessibility/smart-invert.html:
+
 2018-01-19  Chris Dumez  <cdumez@apple.com>
 
         The WebContent process should not process incoming IPC while waiting for a sync IPC reply
diff --git a/LayoutTests/accessibility/smart-invert-expected.txt b/LayoutTests/accessibility/smart-invert-expected.txt
index 91ececb..c2f2082 100644 (file)
--- a/LayoutTests/accessibility/smart-invert-expected.txt
+++ b/LayoutTests/accessibility/smart-invert-expected.txt
@@ -16,8 +16,8 @@ PASS: filter for VIDEO.preserve-filter is 'grayscale(1)'.
 PASS: filter for VIDEO.preserve-filter is 'grayscale(1)'.
 
 AFTER INVERT-COLORS IS APPLIED
-PASS: filter for IMG#a is 'none'. Change once IMG/PICTURE elements are inverted, too.
-PASS: filter for PICTURE#b is 'none'. Change once IMG/PICTURE elements are inverted, too.
+PASS: filter for IMG#a is 'invert(1)'.
+PASS: filter for PICTURE#b is 'invert(1)'.
 PASS: filter for VIDEO#c is 'invert(1)'.
 PASS: filter for VIDEO#d is 'invert(1)'.
 PASS: filter for IMG.fallback is 'none'.
diff --git a/LayoutTests/accessibility/smart-invert-reference-expected.html b/LayoutTests/accessibility/smart-invert-reference-expected.html
index fb576cc..bcffdb3 100644 (file)
--- a/LayoutTests/accessibility/smart-invert-reference-expected.html
+++ b/LayoutTests/accessibility/smart-invert-reference-expected.html
@@ -11,8 +11,8 @@
 </head>
 <body>
 
-  <img src="../compositing/resources/simple_image.png" alt="">
-  <picture><img class="fallback" src="../compositing/resources/simple_image.png" alt=""></picture>
+  <img class="invert" src="../compositing/resources/simple_image.png" alt="">
+  <picture class="invert" ><img class="fallback" src="../compositing/resources/simple_image.png" alt=""></picture>
   <video class="invert" poster="../compositing/resources/simple_image.png"></video>
   <video class="invert" poster="../compositing/resources/simple_image.png" controls></video>
   <br>
diff --git a/LayoutTests/accessibility/smart-invert.html b/LayoutTests/accessibility/smart-invert.html
index 2aaf650..3ff6e17 100644 (file)
--- a/LayoutTests/accessibility/smart-invert.html
+++ b/LayoutTests/accessibility/smart-invert.html
@@ -61,7 +61,7 @@ function runTest() {
             document.getElementById("result").innerHTML += "<br>AFTER INVERT-COLORS IS APPLIED<br>";
 
             // Eventually elements img amd picture will be double-inverted when invert colors is on. Not shipping yet.
-            expectFilterValueForElements(NONE_VALUE, document.querySelectorAll("#a, #b"), "Change once IMG/PICTURE elements are inverted, too.");
+            expectFilterValueForElements(INVERTED_VALUE, document.querySelectorAll("#a, #b"));
 
             // Element <video> should be double-inverted when invert colors is on.
             expectFilterValueForElements(INVERTED_VALUE, document.querySelectorAll("#c, #d"));            
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index b3cf1a1..e3ba3a3 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,20 @@
+2018-01-19  James Craig  <jcraig@apple.com>
+
+        AX: when invert colors is on, double-invert image and picture elements in UserAgentStyleSheet
+        https://bugs.webkit.org/show_bug.cgi?id=181281
+        <rdar://problem/36291776>
+
+        Reviewed by Simon Fraser.
+
+        Updated "Smart Invert" to include img and picture element inversion and tests.
+
+        Tests: accessibility/smart-invert-reference.html
+               accessibility/smart-invert.html
+
+        * css/html.css:
+        (@media (inverted-colors)):
+        (img:not(picture>img), picture, video):
+
 2018-01-19  Chris Dumez  <cdumez@apple.com>
 
         The WebContent process should not process incoming IPC while waiting for a sync IPC reply
diff --git a/Source/WebCore/css/html.css b/Source/WebCore/css/html.css
index f9c7499..6d08d0b 100644 (file)
--- a/Source/WebCore/css/html.css
+++ b/Source/WebCore/css/html.css
@@ -1238,5 +1238,5 @@ attachment {
 
 /* Default support for "Smart Invert" where all content color except media is inverted. */ 
 @media (inverted-colors) {
-    video { filter: invert(100%); }  /* Only videos double-inverted for now. */
+    img:not(picture>img), picture, video { filter: invert(100%); } /* Images and videos double-inverted. */
 }
Mirror of the WebKit open source project from svn.webkit.org.