Improve access specifier use in RenderObject
authorcavalcantii@gmail.com <cavalcantii@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 3 Sep 2015 21:03:46 +0000 (21:03 +0000)
committercavalcantii@gmail.com <cavalcantii@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 3 Sep 2015 21:03:46 +0000 (21:03 +0000)
https://bugs.webkit.org/show_bug.cgi?id=148745

Reviewed by Myles C. Maxfield.

No new tests, no change in behavior.

* rendering/RenderObject.h:
(WebCore::RenderObject::setPreviousSibling):
(WebCore::RenderObject::setNextSibling):
(WebCore::RenderObject::isSetNeedsLayoutForbidden):
(WebCore::RenderObject::setNeedsLayoutIsForbidden):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderObject.h

index 6eb3a70..926335e 100644 (file)
@@ -1,3 +1,18 @@
+2015-09-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
+
+        Improve access specifier use in RenderObject
+        https://bugs.webkit.org/show_bug.cgi?id=148745
+
+        Reviewed by Myles C. Maxfield.
+
+        No new tests, no change in behavior.
+
+        * rendering/RenderObject.h:
+        (WebCore::RenderObject::setPreviousSibling):
+        (WebCore::RenderObject::setNextSibling):
+        (WebCore::RenderObject::isSetNeedsLayoutForbidden):
+        (WebCore::RenderObject::setNeedsLayoutIsForbidden):
+
 2015-09-03  Alexey Proskuryakov  <ap@apple.com>
 
         Test Russian ".рф" domain support
index cbc0b90..8cdcc18 100644 (file)
@@ -252,24 +252,6 @@ public:
     virtual bool createsAnonymousWrapper() const { return false; }
     //////////////////////////////////////////
 
-protected:
-    //////////////////////////////////////////
-    // Helper functions. Dangerous to use!
-    void setPreviousSibling(RenderObject* previous) { m_previous = previous; }
-    void setNextSibling(RenderObject* next) { m_next = next; }
-    void setParent(RenderElement*);
-    //////////////////////////////////////////
-private:
-#ifndef NDEBUG
-    bool isSetNeedsLayoutForbidden() const { return m_setNeedsLayoutForbidden; }
-    void setNeedsLayoutIsForbidden(bool flag) { m_setNeedsLayoutForbidden = flag; }
-#endif
-
-    void addAbsoluteRectForLayer(LayoutRect& result);
-    void setLayerNeedsFullRepaint();
-    void setLayerNeedsFullRepaintForPositionedMovementLayout();
-
-public:
 #if ENABLE(TREE_DEBUGGING)
     void showNodeTreeForThis() const;
     void showRenderTreeForThis() const;
@@ -280,7 +262,6 @@ public:
     void showRegionsInformation() const;
 #endif
 
-public:
     bool isPseudoElement() const { return node() && node()->isPseudoElement(); }
 
     bool isRenderElement() const { return !isText(); }
@@ -859,6 +840,12 @@ public:
     RespectImageOrientationEnum shouldRespectImageOrientation() const;
 
 protected:
+    //////////////////////////////////////////
+    // Helper functions. Dangerous to use!
+    void setPreviousSibling(RenderObject* previous) { m_previous = previous; }
+    void setNextSibling(RenderObject* next) { m_next = next; }
+    void setParent(RenderElement*);
+    //////////////////////////////////////////
     void addPDFURLRect(PaintInfo&, const LayoutPoint&);
     Node& nodeForNonAnonymous() const { ASSERT(!isAnonymous()); return m_node; }
 
@@ -879,6 +866,15 @@ protected:
     static void calculateBorderStyleColor(const EBorderStyle&, const BoxSide&, Color&);
 
 private:
+#ifndef NDEBUG
+    bool isSetNeedsLayoutForbidden() const { return m_setNeedsLayoutForbidden; }
+    void setNeedsLayoutIsForbidden(bool flag) { m_setNeedsLayoutForbidden = flag; }
+#endif
+
+    void addAbsoluteRectForLayer(LayoutRect& result);
+    void setLayerNeedsFullRepaint();
+    void setLayerNeedsFullRepaintForPositionedMovementLayout();
+
     void removeFromRenderFlowThread();
     void removeFromRenderFlowThreadIncludingDescendants(bool);
     Node* generatingPseudoHostElement() const;