2009-01-04 Darin Adler <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23103: Safari's auto-fill no longer works for <select> elements
        https://bugs.webkit.org/show_bug.cgi?id=23103
        rdar://problem/6472061

        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLSelectElement _activateItemAtIndex:]): Implemented this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index dbed3e8..52fb465 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,14 @@
+2009-01-04  Darin Adler  <darin@apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        Bug 23103: Safari's auto-fill no longer works for <select> elements
+        https://bugs.webkit.org/show_bug.cgi?id=23103
+        rdar://problem/6472061
+
+        * bindings/objc/DOMHTML.mm:
+        (-[DOMHTMLSelectElement _activateItemAtIndex:]): Implemented this.
+
 2008-01-04  Adam Treat  <treat@kde.org>
 
         Reviewed by George Staikos.

diff --git a/WebCore/bindings/objc/DOMHTML.mm b/WebCore/bindings/objc/DOMHTML.mm
index 59f2d7f..baf5774 100644 (file)
--- a/WebCore/bindings/objc/DOMHTML.mm
+++ b/WebCore/bindings/objc/DOMHTML.mm
@@ -36,6 +36,7 @@
 #import "HTMLDocument.h"
 #import "HTMLInputElement.h"
 #import "HTMLObjectElement.h"
+#import "HTMLSelectElement.h"
 #import "Range.h"
 #import "RenderTextControl.h"
 #import "markup.h"
@@ -155,11 +156,12 @@
 
 @end
 
-@implementation DOMHTMLSelectElement(FormAutoFillTransition)
+@implementation DOMHTMLSelectElement (FormAutoFillTransition)
 
 - (void)_activateItemAtIndex:(int)index
 {
-    // FIXME: Needs implementation for non-NSView <select>!
+    if (WebCore::HTMLSelectElement* select = [self _HTMLSelectElement])
+        select->setSelectedIndex(index);
 }
 
 @end