REGRESSION (r129211-r129218): http/tests/loading/redirect-with-no-location-crash...
authorzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Sep 2012 14:53:08 +0000 (14:53 +0000)
committerzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Sep 2012 14:53:08 +0000 (14:53 +0000)
https://bugs.webkit.org/show_bug.cgi?id=97404

Reviewed by Philippe Normand.

Tools:

Print out the 'didReceiveTitle' information when dumping frame load callbacks.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewTitleChanged):

LayoutTests:

Remove WebKit2-specific failure expectation and GTK-specific baseline for the test in title.

* platform/gtk-wk2/TestExpectations:
* platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk-wk2/TestExpectations
LayoutTests/platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt [deleted file]
Tools/ChangeLog
Tools/DumpRenderTree/gtk/DumpRenderTree.cpp

index 6736f86..6634492 100644 (file)
@@ -1,3 +1,15 @@
+2012-09-24  Zan Dobersek  <zandobersek@gmail.com>
+
+        REGRESSION (r129211-r129218): http/tests/loading/redirect-with-no-location-crash.html failing on GTK Linux 64-bit Release WK2 (Tests)
+        https://bugs.webkit.org/show_bug.cgi?id=97404
+
+        Reviewed by Philippe Normand.
+
+        Remove WebKit2-specific failure expectation and GTK-specific baseline for the test in title.
+
+        * platform/gtk-wk2/TestExpectations:
+        * platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt: Removed.
+
 2012-09-24  Christophe Dumez  <christophe.dumez@intel.com>
 
         [EFL] Rebaseline several test cases in Skipped list
 2012-09-24  Christophe Dumez  <christophe.dumez@intel.com>
 
         [EFL] Rebaseline several test cases in Skipped list
index cab0680..a3a57df 100644 (file)
@@ -425,8 +425,6 @@ webkit.org/b/39160 security/block-test-no-port.html [ Failure ]
 # https://bugs.webkit.org/show_bug.cgi?id=64135
 webkit.org/b/64135 fast/dom/frame-loading-via-document-write.html [ Failure ]
 
 # https://bugs.webkit.org/show_bug.cgi?id=64135
 webkit.org/b/64135 fast/dom/frame-loading-via-document-write.html [ Failure ]
 
-webkit.org/b/97404 http/tests/loading/redirect-with-no-location-crash.html [ Failure ]
-
 # Unexplained failures
 Bug(GTK) accessibility/accessibility-node-memory-management.html [ Failure ]
 Bug(GTK) accessibility/accessibility-node-reparent.html [ Failure ]
 # Unexplained failures
 Bug(GTK) accessibility/accessibility-node-memory-management.html [ Failure ]
 Bug(GTK) accessibility/accessibility-node-reparent.html [ Failure ]
diff --git a/LayoutTests/platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt b/LayoutTests/platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt
deleted file mode 100644 (file)
index bf3afc2..0000000
+++ /dev/null
@@ -1,11 +0,0 @@
-main frame - didStartProvisionalLoadForFrame
-main frame - didCommitLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
-main frame - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
-main frame - didHandleOnloadEventsForFrame
-frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
-main frame - didFinishLoadForFrame
-
index cbfb080..2360703 100644 (file)
@@ -1,3 +1,15 @@
+2012-09-24  Zan Dobersek  <zandobersek@gmail.com>
+
+        REGRESSION (r129211-r129218): http/tests/loading/redirect-with-no-location-crash.html failing on GTK Linux 64-bit Release WK2 (Tests)
+        https://bugs.webkit.org/show_bug.cgi?id=97404
+
+        Reviewed by Philippe Normand.
+
+        Print out the 'didReceiveTitle' information when dumping frame load callbacks.
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (webViewTitleChanged):
+
 2012-09-24  Simon Hausmann  <simon.hausmann@digia.com>
 
         [Qt] Fix build with latest Qt 5
 2012-09-24  Simon Hausmann  <simon.hausmann@digia.com>
 
         [Qt] Fix build with latest Qt 5
index ad27436..f38d9ae 100644 (file)
@@ -943,6 +943,11 @@ static gboolean webViewScriptConfirm(WebKitWebView* view, WebKitWebFrame* frame,
 
 static void webViewTitleChanged(WebKitWebView* view, WebKitWebFrame* frame, const gchar* title, gpointer data)
 {
 
 static void webViewTitleChanged(WebKitWebView* view, WebKitWebFrame* frame, const gchar* title, gpointer data)
 {
+    if (gTestRunner->dumpFrameLoadCallbacks() && !done) {
+        GOwnPtr<char> frameName(getFrameNameSuitableForTestResult(view, frame));
+        printf("%s - didReceiveTitle: %s\n", frameName.get(), title ? title : "");
+    }
+
     if (gTestRunner->dumpTitleChanges() && !done)
         printf("TITLE CHANGED: '%s'\n", title ? title : "");
 }
     if (gTestRunner->dumpTitleChanges() && !done)
         printf("TITLE CHANGED: '%s'\n", title ? title : "");
 }