Switch back to partitioning (rather than blocking) prevalent origins without interaction
authorbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Sep 2017 19:47:50 +0000 (19:47 +0000)
committerbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Sep 2017 19:47:50 +0000 (19:47 +0000)
https://bugs.webkit.org/show_bug.cgi?id=177452
<rdar://problem/34632618>

Reviewed by Chris Dumez.

Temporarily revert to "partition-only" behavior, due to site compatibility issues with
full blocking.

* platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::setPrevalentDomainsToPartitionOrBlockCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp

index aef8180..90704e1 100644 (file)
@@ -1,3 +1,17 @@
+2017-09-25  Brent Fulgham  <bfulgham@apple.com>
+
+        Switch back to partitioning (rather than blocking) prevalent origins without interaction
+        https://bugs.webkit.org/show_bug.cgi?id=177452
+        <rdar://problem/34632618>
+
+        Reviewed by Chris Dumez.
+
+        Temporarily revert to "partition-only" behavior, due to site compatibility issues with
+        full blocking.
+
+        * platform/network/cf/NetworkStorageSessionCFNet.cpp:
+        (WebCore::NetworkStorageSession::setPrevalentDomainsToPartitionOrBlockCookies):
+
 2017-09-25  Alex Christensen  <achristensen@webkit.org>
 
         Separate form submission from PolicyChecker infrastructure
index 4933eba..c6b40bd 100644 (file)
@@ -257,9 +257,11 @@ void NetworkStorageSession::setPrevalentDomainsToPartitionOrBlockCookies(const V
     }
 
     for (auto& domain : domainsToBlock) {
-        m_topPrivatelyControlledDomainsToBlock.add(domain);
-        if (!clearFirst)
-            m_topPrivatelyControlledDomainsToPartition.remove(domain);
+        // FIXME: https://bugs.webkit.org/show_bug.cgi?id=177394
+        // m_topPrivatelyControlledDomainsToBlock.add(domain);
+        // if (!clearFirst)
+        //     m_topPrivatelyControlledDomainsToPartition.remove(domain);
+        m_topPrivatelyControlledDomainsToPartition.add(domain);
     }
     
     if (!clearFirst) {