[MSE] Fix runtime errors caused by mediasource IDL attributes.
authorjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Oct 2013 20:35:01 +0000 (20:35 +0000)
committerjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Oct 2013 20:35:01 +0000 (20:35 +0000)
https://bugs.webkit.org/show_bug.cgi?id=123352

Reviewed by Eric Carlson.

Due to http://webkit.org/b/123178, MediaSource classes must add a GenerateIsReachable
(and also a JSGenerateToJSObject) attribute to avoid runtime asserts and crashes.

* Modules/mediasource/MediaSource.idl:
* Modules/mediasource/SourceBuffer.idl:
* Modules/mediasource/SourceBufferList.idl:
* Modules/mediasource/WebKitMediaSource.idl:
* Modules/mediasource/WebKitSourceBufferList.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Modules/mediasource/MediaSource.idl
Source/WebCore/Modules/mediasource/SourceBuffer.idl
Source/WebCore/Modules/mediasource/SourceBufferList.idl
Source/WebCore/Modules/mediasource/WebKitMediaSource.idl
Source/WebCore/Modules/mediasource/WebKitSourceBufferList.idl

index 52ecf87..851ff14 100644 (file)
@@ -1,3 +1,19 @@
+2013-10-25  Jer Noble  <jer.noble@apple.com>
+
+        [MSE] Fix runtime errors caused by mediasource IDL attributes.
+        https://bugs.webkit.org/show_bug.cgi?id=123352
+
+        Reviewed by Eric Carlson.
+
+        Due to http://webkit.org/b/123178, MediaSource classes must add a GenerateIsReachable
+        (and also a JSGenerateToJSObject) attribute to avoid runtime asserts and crashes.
+
+        * Modules/mediasource/MediaSource.idl:
+        * Modules/mediasource/SourceBuffer.idl:
+        * Modules/mediasource/SourceBufferList.idl:
+        * Modules/mediasource/WebKitMediaSource.idl:
+        * Modules/mediasource/WebKitSourceBufferList.idl:
+
 2013-10-25  Jacky Jiang  <zhajiang@blackberry.com>
 
         [BlackBerry] Browser crashed at PlatformGraphicsContext::addDrawLineForText() when trying to upload a video to youtube
index 6a89654..a2c7d1e 100644 (file)
@@ -32,6 +32,7 @@
     Conditional=MEDIA_SOURCE,
     ActiveDOMObject,
     EventTarget,
+    JSGenerateToJSObject,
     JSGenerateToNativeObject,
     Constructor,
     ConstructorCallWith=ScriptExecutionContext,
index 5e06b3d..abdf3b6 100644 (file)
@@ -33,6 +33,7 @@
     NoInterfaceObject,
     ActiveDOMObject,
     EventTarget,
+    JSGenerateToJSObject,
     JSGenerateToNativeObject,
     OperationsNotDeletable
 ] interface SourceBuffer : EventTarget {
index cfd7639..5f1e397 100644 (file)
@@ -32,7 +32,9 @@
     Conditional=MEDIA_SOURCE,
     NoInterfaceObject,
     EventTarget,
+    JSGenerateToJSObject,
     JSGenerateToNativeObject,
+    GenerateIsReachable=Impl,
     CallWith=ScriptExecutionContext,
     OperationsNotDeletable
 ] interface SourceBufferList : EventTarget {
index da84614..208a8dc 100644 (file)
@@ -32,6 +32,7 @@
     Conditional=MEDIA_SOURCE,
     ActiveDOMObject,
     EventTarget,
+    JSGenerateToJSObject,
     JSGenerateToNativeObject,
     Constructor,
     ConstructorCallWith=ScriptExecutionContext,
index 95db58c..069310f 100644 (file)
@@ -31,7 +31,9 @@
 [
     Conditional=MEDIA_SOURCE,
     EventTarget,
+    JSGenerateToJSObject,
     JSGenerateToNativeObject,
+    GenerateIsReachable=Impl,
     OperationsNotDeletable
 ] interface WebKitSourceBufferList : EventTarget {
     readonly attribute unsigned long length;