Unreviewed, add FIXMEs referencing https://bugs.webkit.org/show_bug.cgi?id=150958 and
authorfpizlo@apple.com <fpizlo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 Nov 2015 00:13:57 +0000 (00:13 +0000)
committerfpizlo@apple.com <fpizlo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 Nov 2015 00:13:57 +0000 (00:13 +0000)
https://bugs.webkit.org/show_bug.cgi?id=150954.

* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::createGenericCompare):
* b3/B3ReduceStrength.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@192088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/b3/B3LowerToAir.cpp
Source/JavaScriptCore/b3/B3ReduceStrength.cpp

index d5e7e03..afb6311 100644 (file)
@@ -1,3 +1,12 @@
+2015-11-05  Filip Pizlo  <fpizlo@apple.com>
+
+        Unreviewed, add FIXMEs referencing https://bugs.webkit.org/show_bug.cgi?id=150958 and
+        https://bugs.webkit.org/show_bug.cgi?id=150954.
+
+        * b3/B3LowerToAir.cpp:
+        (JSC::B3::Air::LowerToAir::createGenericCompare):
+        * b3/B3ReduceStrength.cpp:
+
 2015-11-05  Aleksandr Skachkov  <gskachkov@gmail.com>
 
         Using emitResolveScope & emitGetFromScope with 'this' that is TDZ lead to segfault in DFG
index d7cdb20..ef137ee 100644 (file)
@@ -804,6 +804,10 @@ public:
             Value* right = value->child(1);
 
             if (isInt(value->child(0)->type())) {
+                // FIXME: We wouldn't have to worry about leftImm if we canonicalized integer
+                // comparisons.
+                // https://bugs.webkit.org/show_bug.cgi?id=150958
+                
                 Arg leftImm = imm(left);
                 Arg rightImm = imm(right);
 
@@ -931,6 +935,9 @@ public:
                 Value* left = value->child(0);
                 Value* right = value->child(1);
 
+                // FIXME: We don't actually have to worry about leftImm.
+                // https://bugs.webkit.org/show_bug.cgi?id=150954
+
                 Arg leftImm = imm(left);
                 Arg rightImm = imm(right);
                 
index b61fc7b..919f54e 100644 (file)
@@ -470,6 +470,9 @@ private:
             break;
 
         case LessThan:
+            // FIXME: We could do a better job of canonicalizing integer comparisons.
+            // https://bugs.webkit.org/show_bug.cgi?id=150958
+
             replaceWithNewValue(
                 m_proc.addBoolConstant(m_value->child(0)->lessThanConstant(m_value->child(1))));
             break;